Received-SPF: pass (google.com: domain of linux-kernel+bounces-46719-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 31 Jan 2024 10:33:14 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Kunwu Chan <chentao@kylinos.cn>
Cc: jlayton@kernel.org, neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com,
        tom@talpey.com, linux-nfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfsd: Simplify the allocation of slab caches in
 nfsd_file_cache_init
Message-ID: <ZbpoOtZlxt7gWEyI@tissot.1015granger.net>
References: <20240131065653.133965-1-chentao@kylinos.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240131065653.133965-1-chentao@kylinos.cn>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?USQWjHmgXA5OmjK2IX03Z26UmPfy2gUFQUyjp1/a3m8ZGNLxrrBSO35tn3P2?=
 =?us-ascii?Q?SKXExm8tCJH2eaB5tgz0YhVQuKlNvRz8rpkaXiKEdHtnxt6Ync/IsbVfCVbX?=
 =?us-ascii?Q?Bh9Oe4iz+kDy3uiWJHA4xsmMcksnpNxt64PzqPLKPpgBtL3OLsgexIEAboul?=
 =?us-ascii?Q?dUx30M5WOCKSc0RZLU7de78OuKQ+Ve/xG98Wtwhd616gpTjgwj3cEOMEIkaR?=
 =?us-ascii?Q?hOyuuRDn2dugKn8wsfkM/9kk0F0ZkcH2wVL46uYgaushAajoDQSxfmcHNu0F?=
 =?us-ascii?Q?Z9QlR/S9mBnYeyDm3CS0FBVNagOd3kVgsMfA9xvhA09ntGZsmIqEbxizNhW7?=
 =?us-ascii?Q?FUvBv09OwHedOhrhy+i7PHJ0hhmTSKF+S9ZtLKBbSgboVA050a9R5/95SMwV?=
 =?us-ascii?Q?/ZybOEq+P4vH0nFU0+riomer0Loc2rNaczI7BW/K5rXOkWCfsBnQsk3HJevQ?=
 =?us-ascii?Q?EDijuEmld8tO0VYs+IvizI+LXjR6TvIOzOSYMzml5nFJQ6r7Bn/+/lTcTscn?=
 =?us-ascii?Q?gAtynj16X0oku9VzVBFM8VnHt9Uz3uqyaA+B7cpwplZ4ufo7RaHb/JP+Xvtd?=
 =?us-ascii?Q?rPdqNUIejVep+VyNKTPnJVjuhOVQ+ZlqTIyl6xoNAPcTnjoXvSRVtcJuUo/J?=
 =?us-ascii?Q?lrZWg9T7HBIMvIQmV8gDRN2CzMYcqDR4beC1TW22D6i9qCFRPlN2VoeJxTO1?=
 =?us-ascii?Q?lH8xXrBvPEDKp4Pe/dLC5p0IsiWe+mT2NUQMdCQQge4sSU6787sqglWianJL?=
 =?us-ascii?Q?13j+hkNGO0bKLPN2aUGGFmbGPpGd2uSj3JQJLh+ODj+1GKyzJsAy8auakr1y?=
 =?us-ascii?Q?LAYWtMCMXqQBnvDqE+kSTNeZWKS9jCfhq5eerjTxIMlkefKvDPWd2L0IZhcP?=
 =?us-ascii?Q?/cOX+vt61uUKaQBfnsba4ihlKyD9JNjjb7Od+vMA3jkWgPFZuDaRSyCMmoki?=
 =?us-ascii?Q?7ENCH3KI61p2L3rzP5vfjsyUo8HfeOPTDf6xWxiehaFwQ9hIL0hkNaRNvcei?=
 =?us-ascii?Q?hd4LPIyH9iEYx5R1UUuB5Pc/2NJuEcHqzZ8gGcFQRy6l1C9aRf5qeW0VmsLh?=
 =?us-ascii?Q?91vn+LFiTju2rsuPk1940mc0Df4qrx6g7JQ4Usf+Tzedx/Rxe/yaZgb2Mog7?=
 =?us-ascii?Q?oUlG9tQk5+SuQvcIEAyI877sFzbwB+BIEfF0TCBc5yypnLnuK6MYYi2rqQKe?=
 =?us-ascii?Q?Wx5h/pzjfNJ3s7Q6RXGnWnPYbqKBlV3ML9sr1LhFC/J/sxnOGqUPQFnLYuEp?=
 =?us-ascii?Q?FPsM1yBmwd85F7MtELO2fd1MlgSJ0XyJrhWV2nOA4JlFuO/JqUCvilNd+AjP?=
 =?us-ascii?Q?at44fRL+Ze2uWA50arhXnZvAL28ArmbhhxFF1TlGWTLvDHk2VVpPajc06pT+?=
 =?us-ascii?Q?ysnbnWn8jc4f4LEoJX9XmLzifksUNcYruA5w2RNDBnpqwGU47085PYMTkd1Y?=
 =?us-ascii?Q?smfbnjOQTghlTYHNjBP+7PHD197cC0MerIzNgCIajDCPs+vGn5jVbxf8DSLZ?=
 =?us-ascii?Q?jAHltR7AbQ7syMLsVYzFYeHVYoGDNpCdSrZ5kH4okaPE6OV+RYKBHBKmB7LJ?=
 =?us-ascii?Q?jpbCMbiJRtVMslBPBwBRGiSvmFG3zDkxcSRrnZ7qTI1B3yPG7rRIHryG4k2X?=
 =?us-ascii?Q?Ww=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	0ZcsNZ/tgt3h8+RK1B1MuH19RkcbXSaxDATLujPgdAz8s3qQf61Lnb5gBoWIQt6MgdOgFf1xKFn8uULYzQrr5bjSPqSFXaQCL16/8GX5px9cyTr7yt9LZitU3jdXZ3aJNhbvZpaYceeos85k/Als+rSuDm5WQ6G8ukGJNY+Y4ESE/6jxQAVnHLsb2/5fUszMR3AsFYpbgEO+ognZ4Qx2i3Iwvt4mPc/21d/gVUW/iTi9aJUeGdzrLJPWBLCcC8oM3RLdi0jnb8MaGgIIQ7GFtdxjBar4ssK5CGD2yDchjizHJzjAPAgj4T3dJ10VEHDYoG53NGUYevERTT+cszmUbyatjmDoeWn3XuSFdlv9gKpqLzr6maYph7LzlSKmTelSZHXgMj5hYkVXjUfctl0wUPQeZUYRUM2SVB4wqIa82qpbpqzZg8JGJkDMNhUllX6dZFQk/2RIbuzP+N21+7fRHFjvsS0QAlSo7dmbI+X43YyVgh3bCYNwUBhBs9GDSbm1XMM2/z9NL4Lq19DZOKKh5bRi9qFrJq7u3o212KwlVG9Uq3/kGLR92AK3qkjluT2YCu1rS+GgQMf/9tCAsor9/1ddtzVho5wvWxGENjW8Qyw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41cd954e-6928-4b63-7211-08dc2271f238
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 15:33:17.1652
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GwBIhGGVNq+4gze4lyAkNd1HbTRRpBTyv1XZm3nDyWyQMb19lcWwp4AyWzLUl9572ANdUEMv7e7wERiTs3kn3w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5540
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-31_08,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 spamscore=0 mlxlogscore=939 adultscore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401310120
X-Proofpoint-GUID: kJ8Rbr5519SIEOcEWeiJ4ZoBQhILpCfQ
X-Proofpoint-ORIG-GUID: kJ8Rbr5519SIEOcEWeiJ4ZoBQhILpCfQ

On Wed, Jan 31, 2024 at 02:56:53PM +0800, Kunwu Chan wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
> 
> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> ---
>  fs/nfsd/filecache.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 8d9f7b07e35b..f3a642fd0eca 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -722,15 +722,13 @@ nfsd_file_cache_init(void)
>  		return ret;
>  
>  	ret = -ENOMEM;
> -	nfsd_file_slab = kmem_cache_create("nfsd_file",
> -				sizeof(struct nfsd_file), 0, 0, NULL);
> +	nfsd_file_slab = KMEM_CACHE(nfsd_file, 0);
>  	if (!nfsd_file_slab) {
>  		pr_err("nfsd: unable to create nfsd_file_slab\n");
>  		goto out_err;
>  	}
>  
> -	nfsd_file_mark_slab = kmem_cache_create("nfsd_file_mark",
> -					sizeof(struct nfsd_file_mark), 0, 0, NULL);
> +	nfsd_file_mark_slab = KMEM_CACHE(nfsd_file_mark, 0);
>  	if (!nfsd_file_mark_slab) {
>  		pr_err("nfsd: unable to create nfsd_file_mark_slab\n");
>  		goto out_err;
> -- 
> 2.39.2

Applied to nfsd-next (for v6.9).


-- 
Chuck Lever