Received-SPF: pass (google.com: domain of linux-kernel+bounces-46744-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 31 Jan 2024 10:56:01 -0500
From: Frank Li <Frank.li@nxp.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, imx@lists.linux.dev,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Serge Semin <fancer.lancer@gmail.com>
Subject: Re: [PATCH 2/6] PCI: dwc: Change arguments of
 dw_pcie_prog_outbound_atu()
Message-ID: <Zbptka6O7T1tdTuZ@lizhi-Precision-Tower-5810>
References: <20240130-pme_msg-v1-2-d52b0add5c7c@nxp.com>
 <20240131154115.GA587326@bhelgaas>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240131154115.GA587326@bhelgaas>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?4oO1Tx9K7ty192MYZsOtiLU9oVCffK9t5OBr8DYWDS8UEc33XKvN/xp61I21?=
 =?us-ascii?Q?bN0ZtXKX3aEfYjrC88Qw2XTrugxD+PI4Xv43YohDEKILuDirqt45L6LDmpwl?=
 =?us-ascii?Q?seY0bFuBD7ihakT/X3H7Q0mCLewE3liB75Ok7JrkNCUYx4b0rvXXnQhBlBq+?=
 =?us-ascii?Q?3ff+vOz7BSBS+mkjL9zTEU+jU/mJhndSzt3tzBxWPbQ2mM9JgKhgSgkHb5AA?=
 =?us-ascii?Q?nlrYjlIcUk+gsKcw7EBG5OENRZuMb9D0XYM5UWrQn6CNaqh7HLUsAu4rJqzL?=
 =?us-ascii?Q?vfcmUJQN0NyFWL/i10ar4Qg0EKSd0/eoSdPgKIJLXLy8z8Fee/EjlzAnnGkd?=
 =?us-ascii?Q?Eo5OLTTICPZSa0sA+96BT/UArWB6ZI1m+wyDBdvLWH3lCjcJlLqh1VwXYZoF?=
 =?us-ascii?Q?vRztqXd5ulqb0OKnmt5VuzAnEzD3xusteSfgy/sRt1By/27w8PGdEPb+Szxx?=
 =?us-ascii?Q?qWEdEAx1nj6nO2E+i5YHp1XO3322oJt1Ubf7VIjcbYBa/OnaeqoZNY6777RB?=
 =?us-ascii?Q?8AnWsRqUiBAhNJp7eUbPJmxe18UuFD3yWMM5ICqWLyIVtu+pf4u67p9BHYkI?=
 =?us-ascii?Q?zjtuEWl0ucDMiTxDE0raY5OloFtwe1iiL8omrNhxFLfM8vi+m61Qwmc5gvIR?=
 =?us-ascii?Q?nckJblhHO7ZFXOIKsj19Eajocqlka/78k6CVahPNrOlDkJSw0JjypQVJQh4x?=
 =?us-ascii?Q?1hvlIKBbcZZoAsXkUaXeG6xU2qfdmhRVkTKTQCt1WJVhAei+x21OYOkk4nao?=
 =?us-ascii?Q?QqYF5FkI/2WjXsmt38yd9VW6odrLa/0169PjzHhgGSojTon8aENikDflLuF/?=
 =?us-ascii?Q?TozQ95Nb2Cx202bOb7+vpTZZX93EsMK7Hnuvx5wcU0Jf40i7UiAumqKGq5xA?=
 =?us-ascii?Q?dzAJaB43JWVAMm6v9r+FdQfZSG4gKnDuFUCz89BIHUqZ5xbW0QxrxzBJkMYs?=
 =?us-ascii?Q?9E/GNOg2DnEbkvxBW9SSRU4TEx8+bFELQFWwLMup0UOTX7m0S8SxR/RASpzv?=
 =?us-ascii?Q?T0wMUm3FBn0fNIbU4EcJ3jHfJpSz9s0TGOEoebGAHGx8xFmugv2xUJ9SXkIA?=
 =?us-ascii?Q?cm9fMNQoDQeC0zlkHHqqNp1phAVkGNJVaGEiuB4NYS8ATn1t8sp+MHLg/nKm?=
 =?us-ascii?Q?stBazi6OUIBTN7mK0XLEGGxYgNagFJuyUQzLdqarI0xa6o2BnJP+FZRDmwKt?=
 =?us-ascii?Q?Uz64ogZNtkxAcyhQDE3Jk4FlYYPOgKOsO/CbPOg5YWfpNAe+D6yLtsSCJY7z?=
 =?us-ascii?Q?7d8+CO7ND8gcuaKk5Wb7i4XLkZjWYGl3aEsU7ShPaq5BtiDBhu0RTjWpXvj5?=
 =?us-ascii?Q?D08QaibiYrD+5oOx/ci2PZC53qDgK+U+8O3QkctwqEuakuqKiAESAOxKY4q9?=
 =?us-ascii?Q?L65Y0FHNARMi6cfAnyy8vL/krNs8mr3WELBwebPLMJ1v7RsHpukl3BMKnsKH?=
 =?us-ascii?Q?lM4/WE1MT6WnDBNkgE9wjjJ0CJgQSI+RYb5IjQwgURbapVhp6nqvxB0n5dRt?=
 =?us-ascii?Q?iMVbICisCENL8joecSDyAOlET7/jtlhHg1PScqAFBCzJfPV5qP0lH0ybVWj2?=
 =?us-ascii?Q?blxwk/F0trA0h8uP5K7ywrF2G/Dkhf9Wbg5FxyTR?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 626f9811-7dc8-40bf-3aad-08dc227523a9
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 15:56:08.5886
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rcEOabnoJu1nLBgG/z+Gb/ii7v+wSkZBzgpxeDbcqtZg1/YdYdtwLLtsTolr0UrCmpy8C8PgP+51qiTNVopqXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7262

On Wed, Jan 31, 2024 at 09:41:15AM -0600, Bjorn Helgaas wrote:
> Nit: could the subject line be more specific than "change arguments"?
> E.g., something about collecting dw_pcie_prog_outbound_atu() arguments
> in a struct?  If you know that's the fundamental change, it's a lot
> easier to read the commit log and the patch because you know the goal.

How about 
"Consolidate arguments of dw_pcie_prog_outbound_atu() into a structure"

Frank

> 
> On Tue, Jan 30, 2024 at 07:45:27PM -0500, Frank Li wrote:
> > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > 
> > This is a preparation before adding the Msg-type outbound iATU
> > mapping. The respective update will require two more arguments added
> > to __dw_pcie_prog_outbound_atu(). That will make the already
> > complicated function prototype even more hard to comprehend accepting
> > _eight_ arguments. In order to prevent that and keep the code
> > more-or-less readable all the outbound iATU-related arguments are
> > moved to the new config-structure: struct dw_pcie_ob_atu_cfg pointer
> > to which shall be passed to dw_pcie_prog_outbound_atu(). The structure
> > is supposed to be locally defined and populated with the outbound iATU
> > settings implied by the caller context.
> > 
> > As a result of the denoted change there is no longer need in having
> > the two distinctive methods for the Host and End-point outbound iATU
> > setups since the corresponding code can directly call the
> > dw_pcie_prog_outbound_atu() method with the config-structure
> > populated. Thus dw_pcie_prog_ep_outbound_atu() is dropped.
> > 
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ...