Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1770888rdb; Wed, 31 Jan 2024 08:33:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IH98aq0VnTv9/Td1gXyK/5WZltAboQlZ2bbaVt5RauKS3EQvGLbctocNiUMY1XY3iabFeTw X-Received: by 2002:a05:6214:c84:b0:686:9441:ac30 with SMTP id r4-20020a0562140c8400b006869441ac30mr2578086qvr.22.1706718812782; Wed, 31 Jan 2024 08:33:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706718812; cv=pass; d=google.com; s=arc-20160816; b=cjFvMIejaOXguce4vTrvoOLZJ8m+BihD+XiZm7tJDdfIU/0FelgZbIaSn2OSgZNuiK nSiNHtBgZOBJ4rn/2Mq8iwcQrDbCAaAI8wQBkg3LxigRnkUFGIN2JH9MWXGd3wRth+e6 3RB6QcO0W0wYW6BLo/IIrYFAoWS5GTgGXB3tGExqqMAK5aa7fE+ULWDVpetlQPjSpotD jYg8ivcV1IPDiYtTFqne4UCfzsrsRecTvEQjrORtT5kVZ/Kxid1Ac5SAnDCobc9ywPMG Xxiv3c01cl0MqcTclWaHqV8imYbLCg/A5rqEBiLreUFTzh4vVQSZiAvr9qBFPmfOyQgS Iv/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=06CnC95K9PmzhG31ADLf33POfJorZze5P236X81Bd6I=; fh=xKnkJ8kEdekC/9SO0Tlh7GAZ3BHKINpfVLKegjth8kA=; b=pNCSaHFTDFTaiseP/A80IE4XgzOjVH03diH5FYdxOld0/IYJjqJ587LCyTMCfDLv+r VfaqB0Xyc1sd1cI0dNk7+QQ0lO84JMFzkhz0h04FFtIGXba3zVJOPeRdeFTR8gvzYG54 mwzDgMoRIjv7MIgrTE+77ee5/hKTFiWzUrivcZL3YcWrTj1EpQDA5LGr/QBbHRkW5k9a v2H4Btx5Mo+MxEeEt1JM4jEbGKsYzlScw2WzYtWBo21Idb8TPxbbilHD2h2yqrYosvdV QyNA1JrvfRrDCIO2RweDvZfgD0yu8xCgQYGEsd0o/TXlj9IUE6x75/bdW944doaOaetO ludA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fTh9EJrR; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-46809-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46809-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com X-Forwarded-Encrypted: i=1; AJvYcCU55iUbrZbrAPPAj5p8gkzqootgzMsi4rq1RZwFdzMNnq2t5U+MG2iqz4rMJ/OJMHF43HFlis9gRYzNBWTMZmx9ZSDq0cuji0VJA8WBNQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id dv27-20020a05620a1b9b00b007833f260edesi5398230qkb.487.2024.01.31.08.33.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 08:33:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-46809-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fTh9EJrR; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-46809-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46809-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 766F31C26A15 for ; Wed, 31 Jan 2024 16:33:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5286012A145; Wed, 31 Jan 2024 16:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="fTh9EJrR" Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E86E6AB6 for ; Wed, 31 Jan 2024 16:33:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.55.52.93 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706718793; cv=none; b=GLghRr/ramlOzLNpr1jvcsP2thULeAb8+aVAK2kqxmItiVgFFKPFGM2MjBc9eBgMBNh5QMdWUtPVv1JQUnzp9Ygn0RsxDq7xsWOgCCe2Wn5ZDisz9fxLDm+5TrXR4JE5WCEL3aXxUqYwj249aI75BCuiknNe+sja1utH0bVEGBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706718793; c=relaxed/simple; bh=QWDq0A863bmtoFjRx3k/dC+YwBlL22liPpTOfNOnU+U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SCCOy4caoL9j2H3roA6pNP/3cKTaz9QVXFTr3qHa1aDBUsLG8puEdpgFbNExnd6gqR6A/tvV7R4RdKRV3Bbp3QCOPklyMX6P5PdIEFnYg3HcsTNzGlpudiVA6U+TrSoWHdFN0AV1bSUqUlhXDI/NWW0kQgIojA/P8SizUZk+4L4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=fTh9EJrR; arc=none smtp.client-ip=192.55.52.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706718790; x=1738254790; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=QWDq0A863bmtoFjRx3k/dC+YwBlL22liPpTOfNOnU+U=; b=fTh9EJrRvwXBMTP2VVsPhZw66xb6+MsxvqEQfhdS1pS0ZgqDznC9/5eu P15SUZeRagMAwU0NVA5DuIvPvi3w42IIlcasQZvVp7bskvKWtqe14Iyhb ZU3WQW2yY4oRDaso4mMD3LQiXxrHsupId8FpxUTNFNpEDWxMw7Wb7mEa0 JEdcfchvZL3SgWQLTfnjqtfCYu/I+uGnrzR1wZfzQJiU3KWiZCGTevKPE QCHlFUNXb3PfJwi2tu7MFrMDi1R0CVZJ5FJnEvi2GQvK9qYmVR7kORKCf Hk4eZna627e1U78E4CnfJ1GHOG8gOk1uSwP61YJmQthRXByaT70ON1s+I Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="400785587" X-IronPort-AV: E=Sophos;i="6.05,231,1701158400"; d="scan'208";a="400785587" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2024 08:33:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10969"; a="907940266" X-IronPort-AV: E=Sophos;i="6.05,231,1701158400"; d="scan'208";a="907940266" Received: from dspeerx-mobl.amr.corp.intel.com (HELO [10.212.131.185]) ([10.212.131.185]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2024 08:33:08 -0800 Message-ID: <6709a57c-48a0-4ddd-b64e-a1e34ae2b763@intel.com> Date: Wed, 31 Jan 2024 08:33:07 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC V1 5/5] x86: CVMs: Ensure that memory conversions happen at 2M alignment Content-Language: en-US To: Vishal Annapurve , x86@kernel.org, linux-kernel@vger.kernel.org Cc: pbonzini@redhat.com, rientjes@google.com, bgardon@google.com, seanjc@google.com, erdemaktas@google.com, ackerleytng@google.com, jxgao@google.com, sagis@google.com, oupton@google.com, peterx@redhat.com, vkuznets@redhat.com, dmatlack@google.com, pgonda@google.com, michael.roth@amd.com, kirill@shutemov.name, thomas.lendacky@amd.com, dave.hansen@linux.intel.com, linux-coco@lists.linux.dev, chao.p.peng@linux.intel.com, isaku.yamahata@gmail.com, andrew.jones@linux.dev, corbet@lwn.net, hch@lst.de, m.szyprowski@samsung.com, bp@suse.de, rostedt@goodmis.org, iommu@lists.linux.dev References: <20240112055251.36101-1-vannapurve@google.com> <20240112055251.36101-6-vannapurve@google.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240112055251.36101-6-vannapurve@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/11/24 21:52, Vishal Annapurve wrote: > @@ -2133,8 +2133,10 @@ static int __set_memory_enc_pgtable(unsigned long addr, int numpages, bool enc) > int ret; > > /* Should not be working on unaligned addresses */ > - if (WARN_ONCE(addr & ~PAGE_MASK, "misaligned address: %#lx\n", addr)) > - addr &= PAGE_MASK; > + if (WARN_ONCE(addr & ~HPAGE_MASK, "misaligned address: %#lx\n", addr) > + || WARN_ONCE((numpages << PAGE_SHIFT) & ~HPAGE_MASK, > + "misaligned numpages: %#lx\n", numpages)) > + return -EINVAL; This series is talking about swiotlb and DMA, then this applies a restriction to what I *thought* was a much more generic function: __set_memory_enc_pgtable(). What prevents this function from getting used on 4k mappings?