Received-SPF: pass (google.com: domain of linux-kernel+bounces-46817-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Aaron Conole <aconole@redhat.com>
To: Brad Cowie <brad@faucet.nz>
Cc: netdev@vger.kernel.org,  pshelar@ovn.org,  davem@davemloft.net,
  edumazet@google.com,  kuba@kernel.org,  pabeni@redhat.com,
  shuah@kernel.org,  dev@openvswitch.org,  linux-kselftest@vger.kernel.org,
  linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: openvswitch: Test ICMP related
 matches work with SNAT
References: <20240131040822.835867-1-brad@faucet.nz>
Date: Wed, 31 Jan 2024 11:44:29 -0500
In-Reply-To: <20240131040822.835867-1-brad@faucet.nz> (Brad Cowie's message of
	"Wed, 31 Jan 2024 17:08:22 +1300")
Message-ID: <f7tcythmp02.fsf@redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Brad Cowie <brad@faucet.nz> writes:

> Add a test case for regression in openvswitch nat that was fixed by
> commit e6345d2824a3 ("netfilter: nf_nat: fix action not being set for
> all ct states").
>
> Link: https://lore.kernel.org/netdev/20231221224311.130319-1-brad@faucet.nz/
> Link: https://mail.openvswitch.org/pipermail/ovs-dev/2024-January/410476.html
> Suggested-by: Aaron Conole <aconole@redhat.com>
> Signed-off-by: Brad Cowie <brad@faucet.nz>
> ---

I tested this on a patched kernel and as well as an unpatched kernel and
got the following:

6.5.5-200: TEST: ip4-nat-related: ICMP related matches work with SNAT          [FAIL]
6.7.0    : TEST: ip4-nat-related: ICMP related matches work with SNAT          [ OK ]

Thanks for adding the test case!

Tested-by: Aaron Conole <aconole@redhat.com>
Acked-by: Aaron Conole <aconole@redhat.com>