Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1783085rdb; Wed, 31 Jan 2024 08:56:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHXx5FYP9q53Zo8Y9yoHiVEzIhdPAXBiM+DX4Afb6EIRMpX2Je5QVoqfy9ugMYw0aKvJZvN X-Received: by 2002:a05:6402:792:b0:55f:6fd:8ac1 with SMTP id d18-20020a056402079200b0055f06fd8ac1mr1615371edy.37.1706720212915; Wed, 31 Jan 2024 08:56:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706720212; cv=pass; d=google.com; s=arc-20160816; b=go52t0S1UEsw+Jkm6FDYxlb7zT16UVuRBtnbYxqUKqo0HwBF390Q0qLHl6M1UGy6N6 RBOVbMTNnZrQGh17PA3gy4WLlkgNVGtHPp6vV3K/Mz/6EWhomtbRhud2Al8xb7Cq1vcN cLKhXaktqt5EWWc6M9WeZSSMdpuFAiBrf0m2JgkIvleMwXce1e4sRrjwlunIAtr4Gsis f7SyNlXgm2P1NbvG53KqdQsBuzpOPtmofHLXuh8tKPPq6iphiQykYIlfsc0Eq0cIcAig UW/J/st+ix73wShnZsHXQBDzdUVoqYiWQrZ+T814BLc9mFvSU9zz536qRSjtCHON/K1A n4hg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ie3PhGRiXvQeG1Gh04m6530Qq4FFKWgoWAI1nGfqhTU=; fh=0JcC1jMVccaJijV3STujpAlTqmbXvfwIrxW9i+z+S0k=; b=Xu7QbCCZSt3HAVXwc3SplDuEyadgyyILM+jInKQ/cGY6XUCwHX0VOhVmpxnZqX+5/C M+kDeWd2iBJT2+eiRz5i0bn8wOvuzy5SgmwXWn44csyFEb5PJHLimniuog1iCqxX55vn dp8iNMQlKc/VmkikCbX7H/+c7JoMcv+xiaVSGSVUBIDFerckfv8x34MxXjgp8UQo5c2p r5pmetQ8Ta1BcEMxJfwCB+T083CpOeVka89qiFwHgKzvHM4eNyQR/WmOHRaWnsYPI2fn 0DWDSdXikeGnfEoFV3kgR2fwyrlpPDeEKQT9YGC0YroupVkSS0ZbqEDozalSVCGe31hN bwGg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RuKpwUpG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-46842-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46842-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCVrwY7xetSHWqhjGPbfoWDKEffTQaws+WxgTuLSYGWhK+FA+mE7SO5dRIE3INXo41X9OHKujPZeQMMjS1yIAKD0HA90Ncg5VCHzyqYPZw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z13-20020a056402274d00b0055f8cc92f07si650535edd.214.2024.01.31.08.56.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 08:56:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-46842-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RuKpwUpG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-46842-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-46842-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F13FB1F25EE4 for ; Wed, 31 Jan 2024 16:56:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 96A2D12F5A9; Wed, 31 Jan 2024 16:53:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RuKpwUpG" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACF9712F58B; Wed, 31 Jan 2024 16:53:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706719986; cv=none; b=gisDFqdlll80jUVYA3Vvc/w+BNkwyMgi4P31iCYINn7udbNHw51ywFMLwgZG7AaaYVYDvOIgYDwZEcwOtKH6TlKaYuAlYh1JKFHG38DO9BI6vtvZQINJhcWywD3G2Wd5d+m3JY6BsfPYRUBiJXtjB+IJPz9HO3Ymva/ItkHoRbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706719986; c=relaxed/simple; bh=zy8loWPlJ2ue1zAlO45Uz6DlMoGbTgu9KTb2TSAx9Dg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DF6cn84P/QV3dxqcSZo/PiVd306DCd8VHrlx3HEyRUXmkxrhOcIGkgEzN1zKls2e5wrMeAUjIzZUDuJ1Uux1k7CfkyNphjFVSqs8rjcfNvoENrZ/vQDgmNcDsoG/r041Yl0YFxduaKvNTVLZ5pyp5sTq9/mVTKY1Oi9w6N6i890= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RuKpwUpG; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED486C433C7; Wed, 31 Jan 2024 16:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706719986; bh=zy8loWPlJ2ue1zAlO45Uz6DlMoGbTgu9KTb2TSAx9Dg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RuKpwUpGGfnUqH+2fMz5oQqgPYtX3W74FoLl2ZbQGgeOPWmKc9hM3Z+7XWpKqU953 WGLdeII21u1OcZMGbIUUOe/MH0JK87A4waxOJjcitWIjjB+vb/x/Nio1OoVNZEpu1J zZ2Eac2xjV1toXWsOvl5777MshK/9fK9q40TUyJFolPu3GwsIT+bOpEz2WN5NAtClz L/BZye/SSIA2i68ZUahanCs14gxwxViXk1X/BOScv2xpJVLazsVIpX18YkJ9n+LLzC R/2xeZB9IEipsLsJUAe65ZC0JIvJOCTOj4wRIn7UMG5y/3E8owHLKH+xoLOwNA4yOm xheeuNt3FXQIQ== Date: Wed, 31 Jan 2024 17:52:58 +0100 From: Simon Horman To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Joerg Roedel , Will Deacon , Greg Kroah-Hartman , "Rafael J. Wysocki" , Magnus Karlsson , Maciej Fijalkowski , Alexander Duyck , bpf@vger.kernel.org, netdev@vger.kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/7] dma: compile-out DMA sync op calls when not used Message-ID: <20240131165258.GA401365@kernel.org> References: <20240126135456.704351-1-aleksander.lobakin@intel.com> <20240126135456.704351-2-aleksander.lobakin@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240126135456.704351-2-aleksander.lobakin@intel.com> On Fri, Jan 26, 2024 at 02:54:50PM +0100, Alexander Lobakin wrote: > Some platforms do have DMA, but DMA there is always direct and coherent. > Currently, even on such platforms DMA sync operations are compiled and > called. > Add a new hidden Kconfig symbol, DMA_NEED_SYNC, and set it only when > either sync operations are needed or there is DMA ops or swiotlb > enabled. Set dma_need_sync() and dma_skip_sync() (stub for now) > depending on this symbol state and don't call sync ops when > dma_skip_sync() is true. > The change allows for future optimizations of DMA sync calls depending > on compile-time or runtime conditions. > > Signed-off-by: Alexander Lobakin Hi Alexander, This seems to cause x86_64 allmodconfig builds to fail: ../drivers/media/platform/ti/omap3isp/ispstat.c:82:35: error: ‘dma_sync_single_range_for_device’ undeclared (first use in this function); did you mean ‘dma_sync_sgtable_for_device’? 82 | dma_sync_single_range_for_device); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | dma_sync_sgtable_for_device ../drivers/media/platform/ti/omap3isp/ispstat.c:82:35: note: each undeclared identifier is reported only once for each function it appears in ../drivers/media/platform/ti/omap3isp/ispstat.c: In function ‘isp_stat_buf_sync_magic_for_cpu’: ../drivers/media/platform/ti/omap3isp/ispstat.c:94:35: error: ‘dma_sync_single_range_for_cpu’ undeclared (first use in this function); did you mean ‘dma_sync_sgtable_for_cpu’? 94 | dma_sync_single_range_for_cpu); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | dma_sync_sgtable_for_cpu