Received-SPF: pass (google.com: domain of linux-kernel+bounces-46845-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 31 Jan 2024 16:54:42 +0000
From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Naresh Solanki <naresh.solanki@9elements.com>,
	Peter Rosin <peda@axentia.se>, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, mazziesaccount@gmail.com,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: iio: afe: voltage-divider: Add
 io-channel-cells
Message-ID: <20240131-stylized-defile-d8fe346ab197@spud>
References: <20240130115651.457800-1-naresh.solanki@9elements.com>
 <1c855a34-8a0d-491e-bfd2-24635b41c86f@linaro.org>
 <20240131163516.000043df@Huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="h8APYS+PcgeCvIXI"
Content-Disposition: inline
In-Reply-To: <20240131163516.000043df@Huawei.com>


--h8APYS+PcgeCvIXI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 31, 2024 at 04:35:16PM +0000, Jonathan Cameron wrote:
> On Wed, 31 Jan 2024 09:29:59 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>=20
> > On 30/01/2024 12:56, Naresh Solanki wrote:
> > > voltage-divider is always an iio consumer at the same time it is
> > > optionally an iio provider.
> > > Hence add #io-channel-cells
> > > Also update example.
> > >  =20
> >=20
> > Fix
> > wrapping
> > and
> > proper
> > sentences. Each sentence finishes with full stop.
> >=20
> > ...
> > >    output-ohms:
> > >      description:
> > >        Resistance Rout over which the output voltage is measured. See=
 full-ohms.
> > > @@ -75,12 +82,17 @@ examples:
> > >              spi-max-frequency =3D <1000000>;
> > >          };
> > >      };
> > > -    sysv {
> > > +    p12v_vd: sysv { =20
> >=20
> > No, drop label.
> >=20
> > >          compatible =3D "voltage-divider";
> > >          io-channels =3D <&maxadc 1>;
> > > +        #io-channel-cells =3D <1>;
> > > =20
> > >          /* Scale the system voltage by 22/222 to fit the ADC range. =
*/
> > >          output-ohms =3D <22>;
> > >          full-ohms =3D <222>; /* 200 + 22 */
> > >      };
> > > +    iio-hwmon {
> > > +        compatible =3D "iio-hwmon";
> > > +        io-channels =3D <&p12v_vd 0>; =20
> >=20
> > The same question as for v2. Drop unrelated example.
>=20
> Conor requested an example of the device acting as a consumer and a provi=
der.
> Might have meant in the patch description?
>=20
> Conor?

I wanted it in the property description to help with understanding when
to use it. I don't think the extra example nodes actually help you
understand what it is doing, only how to write one yourself once you
know you need it.

Thanks,
Conor.

--h8APYS+PcgeCvIXI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbp7UQAKCRB4tDGHoIJi
0qUKAP0Ww48y8Vpl0AK0ojq0GTFz+pnr+vWFetK6V8fbSyQ0YwEAg+sb0e5EXttx
Yc5wqU6OG+ali+z2CNC/Op4kdAyPMAE=
=i3bX
-----END PGP SIGNATURE-----

--h8APYS+PcgeCvIXI--