Received-SPF: pass (google.com: domain of linux-kernel+bounces-46908-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <9d6b00f9-98bf-43d2-86c5-55e45ea8d821@amd.com>
Date: Wed, 31 Jan 2024 09:30:53 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net v3] octeontx2-af: Initialize maps.
To: Ratheesh Kannoth <rkannoth@marvell.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com,
 horms@kernel.org, kuba@kernel.org, pabeni@redhat.com, sbhatta@marvell.com,
 gakula@marvell.com, hkelam@marvell.com, sumang@marvell.com
References: <20240131024118.254758-1-rkannoth@marvell.com>
Content-Language: en-US
From: Brett Creeley <bcreeley@amd.com>
In-Reply-To: <20240131024118.254758-1-rkannoth@marvell.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c1h6ZzdVYTU0d2QxMDhsMjZHcmVML2J1Qyt4bzVwaGdrRnBldEtNNGlQYzV5?=
 =?utf-8?B?dk9aaXpZLzZPeit6dVdheCtmUG9XcUc3S0gvMFIvTzJFdmZhS2VEcUlSUUJ3?=
 =?utf-8?B?Z2JwakJOQXFzVEc1djlqRDBhY3phNFgxRWhmSjlaK3Qvemc0NzVUMm1kS1h1?=
 =?utf-8?B?Tm93RTRoVmRwODBWWmRCSEUrWFNQOExiUlUvVW5yekhMWHI3MDJPTzdyWmRa?=
 =?utf-8?B?MXBvQkV6Qk45aFpGckJVMFdTcHBGZ3EzRVZqN3NuQmhYT2J6aVdieEk0dGxL?=
 =?utf-8?B?RGFRMks4OEpBNW11Q2Ryb1VoZ0ZuS0Y0cmVSNzB1SUZPM01SS0lCdTgrc3pa?=
 =?utf-8?B?MDFEcGpncXczaUFaYUNIb0JmS2l1LzhHdDBJTVZLcHdzY0ZrdWo5M3NJUkZv?=
 =?utf-8?B?UFV2eUhYQ0taMVo0bDVnbnMraUJQUytNSlFWYnpqZ1FJWnJtNVZaKzQvUlRm?=
 =?utf-8?B?bFZkdk1CWTBXd0NJM3BLUENOYnppL3BkME93eUI3MFdycnVoanZBVEwydGhR?=
 =?utf-8?B?eGg5OC8yQ3k4YWtCT1BKSHpzYzZaRVZ5U3NvK29STmt2RStnUzE4WG4yWWJ6?=
 =?utf-8?B?TUJ2dHREZTVPMUhUdmxqR1RTaUlMMnNubGorV0hLVDZzR1MrOWJ5OGE4eWM5?=
 =?utf-8?B?Z3dCcjNxT3MvNTFYVWozcXg1akx3OGU4SzRnUEZNVWJWTWc4VmJkTzZ5RkZl?=
 =?utf-8?B?TjZ4S2E5TkQxajZ6TTZaSnZGQ1hoOG9kTmErSVdQMjJoREtSbnhqcENPYkpG?=
 =?utf-8?B?enIrbWJaSEszRkNDNk9xZm85VUV3cGpRUkV5SnZ3dFFnTW9PQ1p1aDB1VGpN?=
 =?utf-8?B?cVRzbDFJazBKdEJtaHZBblBHWGFuVGFxeEZlSjFMUklXMlIrc2ZEM1dnNG9F?=
 =?utf-8?B?U0MyVFZpYjhKUUxQK0RySjdycE84S2FEcXNJVk5GM0JJREp5b3VZZmNLeHh4?=
 =?utf-8?B?R0d6Lzc2VWFjQlFTZUpQWkJMYlRMMWdseEtqUjE5dkZzSmR2R0F0UGNnMEtG?=
 =?utf-8?B?OXROQ1dSRStOS00wN0xEOVpET2NTTVM0NGp5SnpiUG1ZazJ1Q05ZSTJ4YWVV?=
 =?utf-8?B?UkU3Vmp6WWVXdTEvUWc2SXhzdUFYeGc4elgzUGlaM09CT2ZGcW4zZjEwbUFs?=
 =?utf-8?B?ZXhRUlRFaU1wbGpQZ1FOZytMakVqbC96aUlCTmx6V2NkVDA5aFBrdkZSeE12?=
 =?utf-8?B?YjEwZHJ3cmYvVm52K2FxbmJuUDJPTkZBei9TQnJLVWdRbnhNWmpnNXBteGVN?=
 =?utf-8?B?T090V0grM1ZkVXYrZEZiYnc4RmtvWEJYVTk0RmFpd3ZINWpyV0doYitDSVhY?=
 =?utf-8?B?ellwYXFYNjkzL0xTMDc0ODMyZzJOQTNaTmFtNXhxeWNGczJ0eHJMeU1wRXZF?=
 =?utf-8?B?ZWFYd1M4SHpsMGRjN1Myb2Q1VHF4dkpKRWc5dTMwcDkwQ09nay9yVXczcXFS?=
 =?utf-8?B?RzI4aFFZZGxEUkpDMHR6UCtJZFhhclYxNEorc2F4TW91V003OFRGWlI5WXZH?=
 =?utf-8?B?V2w2Y0RJMWY3K090VGgvSVFFL1RhNDZxaVJacUZWTVFBMWYrUlFITGhrc2p0?=
 =?utf-8?B?MWtWSFdaSmE3K1k4QnQwb1N0d0lRK3Z6NDI4Yno2OXFxclhvSWNuNkV1RDhh?=
 =?utf-8?B?c3ovNDYwYVhtUDZQZkc2d0Q0cmRUQ0tWTEFpeWtwTzdWR0ZGcm9wYURjRWNY?=
 =?utf-8?B?bmN4RlpydmVRMVJNN1lJVVJkU2tXczZ6b3gzQUZndXJhdDBxY1Y3ZWpWVFJ2?=
 =?utf-8?B?U1hTSXdqbGxqQ0YzLzkwUVpTaVlJS3BBVEJ2M0tkV1dtem53a2N0Y2NWNVhp?=
 =?utf-8?B?TTJQaTdiYmpnVjY5a0ZVNm56UG9OaktXMFNhT3lpUmIzb1BBdmxKZDFkdXRH?=
 =?utf-8?B?dmRjZDBJaFkvRm9QSlMyaVMxS1ZsRnFFUXRjeC9xR0d2dSs5Q0RJaUxabG9k?=
 =?utf-8?B?MDMrUGNQQ1RoWHppWkxuNlA1c1VmL2R5em9qQWtVOTdZRitHMUloYXBCZ1NW?=
 =?utf-8?B?eFF5bkpOVEpzZnFvbFQ2UklwcjdlZE1QTGhEOTBYMURPN0c5U0d2SnR6LzF4?=
 =?utf-8?B?VW5WNVpXUmlFZ2R4RGtCd1k0SzVTeGxPWmZRTjB5SHYyaVp1S2dzMmJudUMr?=
 =?utf-8?Q?JueiSbykoBu/wDGUWF0FOoerI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5592039d-e540-40e8-d2c7-08dc228260d9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB7982.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 17:30:54.6924
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bWhKRkzT/nq/tf6X9smLz8CtUriuyNcWVxsBoTp8PyQm5CIEZfbCO4RvbBx+31g6Cmq+gQqMaIiCysVDFQqoug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6583

On 1/30/2024 6:41 PM, Ratheesh Kannoth wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> kmalloc_array() without __GFP_ZERO flag does not initialize
> memory to zero. This causes issues. Use __GFP_ZERO flag for maps and
> bitmap_zalloc() for bimaps.
> 
> Fixes: dd7842878633 ("octeontx2-af: Add new devlink param to configure maximum usable NIX block LFs")
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> ---
> 
> ChangeLogs:
> v2 -> v3: Used GFP_ZERO for normal map arrays
> v1 -> v2: Used bitmap_zalloc() API.
> v0 -> v1: Removed devm_kcalloc()._
> ---
>   .../ethernet/marvell/octeontx2/af/rvu_npc.c   | 26 ++++++++++---------
>   1 file changed, 14 insertions(+), 12 deletions(-)

LGTM.

Reviewed-by: Brett Creeley <brett.creeley@amd.com>

> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> index 167145bdcb75..6a8f0efd96a5 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> @@ -1850,8 +1850,8 @@ void npc_mcam_rsrcs_deinit(struct rvu *rvu)
>   {
>          struct npc_mcam *mcam = &rvu->hw->mcam;
> 
> -       kfree(mcam->bmap);
> -       kfree(mcam->bmap_reverse);
> +       bitmap_free(mcam->bmap);
> +       bitmap_free(mcam->bmap_reverse);
>          kfree(mcam->entry2pfvf_map);
>          kfree(mcam->cntr2pfvf_map);
>          kfree(mcam->entry2cntr_map);
> @@ -1904,13 +1904,11 @@ int npc_mcam_rsrcs_init(struct rvu *rvu, int blkaddr)
>          mcam->pf_offset = mcam->nixlf_offset + nixlf_count;
> 
>          /* Allocate bitmaps for managing MCAM entries */
> -       mcam->bmap = kmalloc_array(BITS_TO_LONGS(mcam->bmap_entries),
> -                                  sizeof(long), GFP_KERNEL);
> +       mcam->bmap = bitmap_zalloc(mcam->bmap_entries, GFP_KERNEL);
>          if (!mcam->bmap)
>                  return -ENOMEM;
> 
> -       mcam->bmap_reverse = kmalloc_array(BITS_TO_LONGS(mcam->bmap_entries),
> -                                          sizeof(long), GFP_KERNEL);
> +       mcam->bmap_reverse = bitmap_zalloc(mcam->bmap_entries, GFP_KERNEL);
>          if (!mcam->bmap_reverse)
>                  goto free_bmap;
> 
> @@ -1918,7 +1916,8 @@ int npc_mcam_rsrcs_init(struct rvu *rvu, int blkaddr)
> 
>          /* Alloc memory for saving entry to RVU PFFUNC allocation mapping */
>          mcam->entry2pfvf_map = kmalloc_array(mcam->bmap_entries,
> -                                            sizeof(u16), GFP_KERNEL);
> +                                            sizeof(u16),
> +                                            GFP_KERNEL | __GFP_ZERO);
>          if (!mcam->entry2pfvf_map)
>                  goto free_bmap_reverse;
> 
> @@ -1942,7 +1941,8 @@ int npc_mcam_rsrcs_init(struct rvu *rvu, int blkaddr)
>                  goto free_entry_map;
> 
>          mcam->cntr2pfvf_map = kmalloc_array(mcam->counters.max,
> -                                           sizeof(u16), GFP_KERNEL);
> +                                           sizeof(u16),
> +                                           GFP_KERNEL | __GFP_ZERO);
>          if (!mcam->cntr2pfvf_map)
>                  goto free_cntr_bmap;
> 
> @@ -1950,12 +1950,14 @@ int npc_mcam_rsrcs_init(struct rvu *rvu, int blkaddr)
>           * counter's reference count.
>           */
>          mcam->entry2cntr_map = kmalloc_array(mcam->bmap_entries,
> -                                            sizeof(u16), GFP_KERNEL);
> +                                            sizeof(u16),
> +                                            GFP_KERNEL | __GFP_ZERO);
>          if (!mcam->entry2cntr_map)
>                  goto free_cntr_map;
> 
>          mcam->cntr_refcnt = kmalloc_array(mcam->counters.max,
> -                                         sizeof(u16), GFP_KERNEL);
> +                                         sizeof(u16),
> +                                         GFP_KERNEL | __GFP_ZERO);
>          if (!mcam->cntr_refcnt)
>                  goto free_entry_cntr_map;
> 
> @@ -1988,9 +1990,9 @@ int npc_mcam_rsrcs_init(struct rvu *rvu, int blkaddr)
>   free_entry_map:
>          kfree(mcam->entry2pfvf_map);
>   free_bmap_reverse:
> -       kfree(mcam->bmap_reverse);
> +       bitmap_free(mcam->bmap_reverse);
>   free_bmap:
> -       kfree(mcam->bmap);
> +       bitmap_free(mcam->bmap);
> 
>          return -ENOMEM;
>   }
> --
> 2.25.1