Received-SPF: pass (google.com: domain of linux-kernel+bounces-47017-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 31 Jan 2024 14:34:11 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: jeffxu@chromium.org, Jonathan Corbet <corbet@lwn.net>
Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com,
        sroettger@google.com, willy@infradead.org, gregkh@linuxfoundation.org,
        torvalds@linux-foundation.org, usama.anjum@collabora.com,
        rdunlap@infradead.org, jeffxu@google.com, jorgelo@chromium.org,
        groeck@chromium.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-mm@kvack.org,
        pedro.falcato@gmail.com, dave.hansen@intel.com,
        linux-hardening@vger.kernel.org, deraadt@openbsd.org
Subject: Re: [PATCH v8 0/4] Introduce mseal
Message-ID: <20240131193411.opisg5yoyxkwoyil@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	jeffxu@chromium.org, Jonathan Corbet <corbet@lwn.net>,
	akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com,
	sroettger@google.com, willy@infradead.org,
	gregkh@linuxfoundation.org, torvalds@linux-foundation.org,
	usama.anjum@collabora.com, rdunlap@infradead.org, jeffxu@google.com,
	jorgelo@chromium.org, groeck@chromium.org,
	linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com,
	linux-hardening@vger.kernel.org, deraadt@openbsd.org
References: <20240131175027.3287009-1-jeffxu@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240131175027.3287009-1-jeffxu@chromium.org>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?p67a1Q8mt99+mjgTPMKOxVHgIZz78nMmk5T5QA9hLFBPS2EHqgsbM5VH4X/h?=
 =?us-ascii?Q?+Zo6uWfdp1DhtesJsDKYDCEInpfWbHRtDwv9zw188IprXhPH4VMzIr0jEmy0?=
 =?us-ascii?Q?Iv+fvux6yzVAV/gVPeDdQVxj0PYMfzHDdgMxrSf88qbGNJE6bc/K7N4v6Kqm?=
 =?us-ascii?Q?+cIs+wmS9NldjzNgmqG2BXJKOVFkblaB0C+YsXD0BVXTSY/yNwxJHdiCU/on?=
 =?us-ascii?Q?YxNSHz+4HaJ1PAoH2JJHSy67NpOEXR98E2XzKyjTjhfU5hm8qO6s1J5QjnZf?=
 =?us-ascii?Q?eL89CAlbsPugw91PIiYcpAfHvG4fY8m6b77g9qZ3pZbYKeASu/86G57Fpc1k?=
 =?us-ascii?Q?ep7eYu1UcoU4Ggs3N2Ttf0z2AWRrSVMMSHtoiOvV50h1HCVHpYXAyR+gxSDi?=
 =?us-ascii?Q?sk5egzZxMSud3HtK6sSaLiiDJobtr5MuTaCPu5M6Tc4dO02fDVW/7tCE9/u7?=
 =?us-ascii?Q?wCqUVUNQLpZiYFEeabyQmLLn3YV3c3Sq1NdViy9I+z3xo12JRGZrXK8dBXRJ?=
 =?us-ascii?Q?EiAsQKWPSxMhDpFDokcJY2dqx/fLkkcF1yYzhofTD0rMPkDeF0lfXimZULl7?=
 =?us-ascii?Q?vDs073ookl7epTlLHG3w9rxYp5hRcqzA5+vF1y4BIQVThmOpvTEEmYEWVh+B?=
 =?us-ascii?Q?vOLXlu5/zBZ9xvTris+KQMSf0RGlQpCVUbwn/Xj1Mj1UqukyW5sarGvVg0Nl?=
 =?us-ascii?Q?0USFM6HeOPDnuimwtOC2hNhqfTIKnUBWLvaPUTZ1l0Sd9Ti/5hzi/bQj/q2E?=
 =?us-ascii?Q?zegi2DsWev4fHyCYVdrNHIXhTBHHWU9ZXhmev+Yb5gOdEUVHhXC/uW8E4LuE?=
 =?us-ascii?Q?aMHUekuYCWdeQ8sGLpAlfxZ+HG41gCbe4tLtvGMJmTfbZL1ehwUDh2QIrAJL?=
 =?us-ascii?Q?9SEuz+XdFn6n4tshRWf3kxdgQHoFlBKqkPYgfpHfe3eeeghRLl4M/6lUAPIl?=
 =?us-ascii?Q?8sUnC1QoZunwDLUzvSz9H4ZXumKYOzzhwUxyUcMjVhpsKMvOJd5dyQuiofNn?=
 =?us-ascii?Q?J6nIr3MEmBhoefZppTkVBLyledom+wPuj3MxnEt0zatvMwp5pK5SN2+3xEBR?=
 =?us-ascii?Q?wAlyT8+Lv2HWbQjIIUCpeBNSyqNumzYKVAQX8mQyk1P9aljym0Pw7slLvWJe?=
 =?us-ascii?Q?XPbcTyIrDGqBPsodU0L6zE2uZbTylqojmfVcJ37FcfPaX6WgjG9s1GKkBlun?=
 =?us-ascii?Q?y8jHlRuTrIkXJ/y+RJBzm4J4Gs5c6W6F4ig5SWKY7Datcn3kUkVqNio1GpJo?=
 =?us-ascii?Q?lbjPD7UVeJXGS3B6WX6TW+EfVODL23urgCGqCD9/2pnXqptNx1tkb4YVM2mO?=
 =?us-ascii?Q?OPI+420B4r2po4GdNjq13+Aa/lNx8weqMMIqRMxxq3gztYPyKYTFMx2jfclT?=
 =?us-ascii?Q?YlA0Ba4ECPLkKTjeyJ0y33ZNWTysUCtUalmGJkqKaOKj48PWP4iPfcgt7pLZ?=
 =?us-ascii?Q?L3/m0GRRYK24SUo7pUGKhlJwWq9N75AtBDB06vrqcvYze/lpfaJUwbBLBIFd?=
 =?us-ascii?Q?mok3+xRJ6RrlyVysgar7/PJyYe81Wm+zRCt9eDNRplt3x+1JtzPR4luyPJea?=
 =?us-ascii?Q?lYdAjFbtPicKnrbt9oR/aBb/cUP5YdYWbsm0MlsG?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	75eHMY5VgBiTEzlb/DGd/X4AS4bGLhKc+e7VXPSuOOlBSd66GVk6+LwhyQH4DYfW9fbM5fW+JUEMY04JvfrRhzwhKVa+NzYF8w9aIyMDgw29CR25yzzjXAFPAZ6tfJE7ClDpp5iRIQSnWOwfwVDtCsvWKkIGkeyohG8J3e7qxEz2/KFCQweztG3EQ3PIumscsTwxckan/o381joF8mSUEIBlaMvw/oeDB05bK8PPyU/ybVYQ45WUKSCevYNsxatbIWYyLJ3sHuyHM2ZzqYpZlR+NEY8rxG0z5xyAo67k692uInd4KOlyOUvnoEXMqEdEYxt/FH+r4H+AmLLLnHjVWF6cAxWwMa+beu8eFX49KlC1mEvCSRaTxaApwZ3EAZCm4RBWAiDrSTFlsAmhmaY1q50ZfdHPDbZyLQsYYcnRoT2haWmDBjCzbuEpCFrCldtrw79mzF4STbMriomA7ltvBMpSpHELgz2w8NEJaZJGP7SkL+9tGL9rgO1JweeHSac09Ruk2ZDit+wCv8at7eJCtvsUvLSN01unkgnqHj9CeCykb70JvDm6a7qEsLRoJSTD4E6kEJXEKaOdTZNinDDKaR86gbAhvlL1YtbgzE6uiVw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6130f7b7-5c07-4e7b-b383-08dc22939b3f
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 19:34:14.1140
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yHSj346ZKaVf+Vb45YgdJovnCRb2beXFAwZjRIozhQ+d8EEahkKU4D4JCz0kgcvrcfvt4zAkbMLW4YfaEfimqg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB6963
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-31_10,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401310152
X-Proofpoint-ORIG-GUID: vx0WQ03b81jOxykXoCZJAie_FubG6TUL
X-Proofpoint-GUID: vx0WQ03b81jOxykXoCZJAie_FubG6TUL

Please add me to the Cc list of these patches.

* jeffxu@chromium.org <jeffxu@chromium.org> [240131 12:50]:
> From: Jeff Xu <jeffxu@chromium.org>
> 
> This patchset proposes a new mseal() syscall for the Linux kernel.
> 
> In a nutshell, mseal() protects the VMAs of a given virtual memory
> range against modifications, such as changes to their permission bits.
> 
> Modern CPUs support memory permissions, such as the read/write (RW)
> and no-execute (NX) bits. Linux has supported NX since the release of
> kernel version 2.6.8 in August 2004 [1]. The memory permission feature
> improves the security stance on memory corruption bugs, as an attacker
> cannot simply write to arbitrary memory and point the code to it. The
> memory must be marked with the X bit, or else an exception will occur.
> Internally, the kernel maintains the memory permissions in a data
> structure called VMA (vm_area_struct). mseal() additionally protects
> the VMA itself against modifications of the selected seal type.

.. The v8 cut Jonathan's email discussion [1] off and instead of
replying there, I'm going to add my question here.

The best plan to ensure it is a general safety measure for all of linux
is to work with the community before it lands upstream.  It's much
harder to change functionality provided to users after it is upstream.
I'm happy to hear google is super excited about sharing this, but so
far, the community isn't as excited.

It seems Theo has a lot of experience trying to add a feature very close
to what you are doing and has real data on how this went [2].  Can we
see if there is a solution that is, at least, different enough from what
he tried to do for a shot of success?  Do we have anyone in the
toolchain groups that sees this working well?  If this means Stephen
needs to do something, can we get that to happen please?

I mean, you specifically state that this is a 'very specific
requirement' in your cover letter.  Does this mean even other browsers
have no use for it?

I am very concerned this feature will land and have to be maintained by
the core mm people for the one user it was specifically targeting.

Can we also get some benchmarking on the impact of this feature?  I
believe my answer in v7 removed the worst offender, but since there is
no benchmarking we really are guessing (educated or not, hard data would
help).  We still have an extra loop in madvise, mprotect_pkey, mremap_to
(and mreamp syscall?).

You also did not clean up the loop you copied from mlock, which I
pointed out [3].  Stating that your copy/paste is easier to review is
not sufficient to keep unneeded assignments around.

[1]. https://lore.kernel.org/linux-mm/87a5ong41h.fsf@meer.lwn.net/
[2]. https://lore.kernel.org/linux-mm/86181.1705962897@cvs.openbsd.org/
[3]. https://lore.kernel.org/linux-mm/20240124200628.ti327diy7arb7byb@revolver/