Received-SPF: pass (google.com: domain of linux-kernel+bounces-47015-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 31 Jan 2024 14:27:29 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: John Garry <john.g.garry@oracle.com>
Cc: mcgrof@kernel.org, russ.weight@linux.dev, gregkh@linuxfoundation.org,
 rafael@kernel.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, keescook@chromium.org, masahiroy@kernel.org,
 nathan@kernel.org, nicolas@fjasle.eu, linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org,
 linux-kbuild@vger.kernel.org
Subject: Re: [PATCH RFC 2/4] tracing: Use uts_release
Message-ID: <20240131142729.2fe870ed@gandalf.local.home>
In-Reply-To: <20240131104851.2311358-3-john.g.garry@oracle.com>
References: <20240131104851.2311358-1-john.g.garry@oracle.com>
	<20240131104851.2311358-3-john.g.garry@oracle.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 31 Jan 2024 10:48:49 +0000
John Garry <john.g.garry@oracle.com> wrote:

> Instead of using UTS_RELEASE, use uts_release, which means that we don't
> need to rebuild the code just for the git head commit changing.
> 
> Signed-off-by: John Garry <john.g.garry@oracle.com>

Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve

> ---
>  kernel/trace/trace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 2a7c6fd934e9..68513924beb4 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -13,7 +13,7 @@
>   *  Copyright (C) 2004 Nadia Yvette Chambers
>   */
>  #include <linux/ring_buffer.h>
> -#include <generated/utsrelease.h>
> +#include <linux/utsname.h>
>  #include <linux/stacktrace.h>
>  #include <linux/writeback.h>
>  #include <linux/kallsyms.h>
> @@ -4354,7 +4354,7 @@ print_trace_header(struct seq_file *m, struct trace_iterator *iter)
>  	get_total_entries(buf, &total, &entries);
>  
>  	seq_printf(m, "# %s latency trace v1.1.5 on %s\n",
> -		   name, UTS_RELEASE);
> +		   name, uts_release);
>  	seq_puts(m, "# -----------------------------------"
>  		 "---------------------------------\n");
>  	seq_printf(m, "# latency: %lu us, #%lu/%lu, CPU#%d |"