Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1918710rdb; Wed, 31 Jan 2024 13:13:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IG28Dson/ueiCtM5jnM6MXzSJeBhYvIBEesnnynqBWFXjE5xb+C49MvpukuFX0EmKq9YNby X-Received: by 2002:a9d:7a82:0:b0:6e1:377e:c427 with SMTP id l2-20020a9d7a82000000b006e1377ec427mr3042345otn.13.1706735610362; Wed, 31 Jan 2024 13:13:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706735610; cv=pass; d=google.com; s=arc-20160816; b=e7k/mV0W7zR7xHnlE3hFAC66IlDzsh1P3jhebmhA8aGztkQGdj21zwVSXj43L/Eaak uvDQSyycn8Q8i2sKSEQL0YeXn5bTPl57Pyl4BNI06ojz4BpNMOh0TzOM5ZDmsHXDRhXt 0hRYiX00jKoVzkY+RWqOeoB/x7kyjPr6BVvabxeEyDTAMHfRaMLD2WAq2dBaqqHnIK82 HF1ejXgMyIGWWi+G19t7d+A7KRfYX36FuYrQ3yQ1/IKEWm73LfqP0B59nG4964b8yGJx dIPpohH0Oxn8SS2KeM6EOo3QMVM0RsnVQNP+IvoteXvJM0ujfSaiDiLFMFSWURBGkZER d0jQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=CeBv//p4KifhhJq8A/dJibUw8SEEng+UVVtN4T8ou1A=; fh=WLGp5b1IN6yqgzzvDs0wGobQx+IfwwBmg3S9lVyEjLY=; b=T1PnD/smdkSj20xp9n8qOsd2fGEEal4wB0LjvLBCudlv1VLRc3xRSGT242hMjy/0j1 vcaXVgp++AHqIvlM59w5i5mc1bjUuJxuqzxyh2BpZ7Cky27dvCsa1KcInPeAS/4HOwqu Df+zGe11PqrhhoVyJv7POEKw0h0cVVTiizuJ8LeHyQHF+j5REA6EQ2t1PvYJ3XBzPVPA tQs2qpUify760RCPiPkSJxnjTF9mUh3A84QcTJD0oOz88ssQhEmljwKu/Y1GRJCmOta3 CLUorLlEcOhliYkTrsPVlefQg8yq+++DqiEnoJPOX8U/YWCtMgNZB3LPrHVzpDvWGiEz aCyw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="mHYp/br4"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-47115-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-47115-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCVi8OkItO0V7Nsn9qWae2w6LsoqLj/3MtWIh/gO9VVehpLmooCLSrmxAgJflEwMjG5HVG0M4YYCn2LFTwSYy0I0nsiB6rJgLYGQCTlD5w== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id c22-20020a05622a025600b0042bec0c4534si1472338qtx.76.2024.01.31.13.13.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 13:13:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-47115-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="mHYp/br4"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-47115-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-47115-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 09AE01C22F9E for ; Wed, 31 Jan 2024 21:13:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4F07239AD0; Wed, 31 Jan 2024 21:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mHYp/br4" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE9F39864; Wed, 31 Jan 2024 21:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706735584; cv=none; b=A59lYTifGr7UlFIEaxR6pEiWxGbP/waGUKLoVnxXYGvVDeelRPih9QSYZOrKZ2lGbLtCP1A0OkLgt4uPbC7H2MZF01l12nD+7HbnW4bu0N5DHJhepTNq4uuJWqOA6fFxWFLtaLNQEEwPhsx8dSwZY11JmWip4K9O9Hv61G76ems= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706735584; c=relaxed/simple; bh=KpeAZao1g931gOPKrARuB7csMwiSRG+PLjdP6UwwNN0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pnuWhNme7rjnOQAenMDjPV3jCGbZU79vdoc5s7dQi3iDjDX4d1UQqaPuQ1WD9mN91vWZxSEc3Ncf4/Idwy8/LWzqSG3e68vrPutpZXeeUE0MIkovpV+kkDN/WFXos7dpihG//LVFW/0WMj5CmdZYy0zUdKgp7r7+XGVD0q4MNsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mHYp/br4; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2990BC43394; Wed, 31 Jan 2024 21:13:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706735583; bh=KpeAZao1g931gOPKrARuB7csMwiSRG+PLjdP6UwwNN0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mHYp/br4PIDgr2Q2UoE2YGQ9ybcMX5UUpZjaqU4OWWRx3mz93/SKLXjbGoMBcqGtJ HzH+OOvNl1XNol3OrCKwFgZVB5YZ/czTicEfZwCOO3r30cN7qCdZL9YYzDhhuY2+wx WX7CYjDJ5Rf8IdaXwg7R99cFfEn485JP9llYEuzEUYGewIzg/vvrE2l6t3xoFYLd1O 4sC/m+sJXDsu/0g+faGE4XrVPbT3PeneVq5q4gD6CDUEUw1pZaqdyT3qI+DLHjG2xw ZobrCtsxoRmenhAMZPVTSRgwwZCvVdLzp8fOV/SPY1NthbyXZAgUVfW91qKJM5dPe7 wxnnYftoxanVw== Date: Wed, 31 Jan 2024 13:12:58 -0800 From: Jakub Kicinski To: Takeru Hayasaka Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, mailhol.vincent@wanadoo.fr, vladimir.oltean@nxp.com, laforge@gnumonks.org Subject: Re: [PATCH net-next v6] ethtool: ice: Support for RSS settings to GTP from ethtool Message-ID: <20240131131258.47c05b7e@kernel.org> In-Reply-To: <20240131134621.1017530-1-hayatake396@gmail.com> References: <20240131134621.1017530-1-hayatake396@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 31 Jan 2024 13:46:22 +0000 Takeru Hayasaka wrote: > .../device_drivers/ethernet/intel/ice.rst | 21 ++++- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 82 +++++++++++++++++++ > drivers/net/ethernet/intel/ice/ice_flow.h | 31 +++++-- > drivers/net/ethernet/intel/ice/ice_lib.c | 37 +++++++++ > include/uapi/linux/ethtool.h | 48 +++++++++++ Could you split the uAPI changes and the driver changes to two separate commits? You should post them as a patch series, but combining them into a single commit makes the uAPI addition to easy to miss. -- pw-bot: cr