Received-SPF: pass (google.com: domain of linux-kernel+bounces-47150-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 31 Jan 2024 21:18:39 +0000
From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Bastien Curutchet <bastien.curutchet@bootlin.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Herve Codina <herve.codina@bootlin.com>
Subject: Re: [PATCH 1/2] dt-bindings: net: Add TI DP83640
Message-ID: <20240131-tummy-imperfect-e6d6f0e245e9@spud>
References: <20240130085935.33722-1-bastien.curutchet@bootlin.com>
 <20240130085935.33722-2-bastien.curutchet@bootlin.com>
 <20240130-impulsive-widow-9142a069b7fd@spud>
 <20240131210521.GA2289883-robh@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Bq6+OXQmC9EZt/Z+"
Content-Disposition: inline
In-Reply-To: <20240131210521.GA2289883-robh@kernel.org>


--Bq6+OXQmC9EZt/Z+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 31, 2024 at 03:05:21PM -0600, Rob Herring wrote:
> On Tue, Jan 30, 2024 at 05:56:37PM +0000, Conor Dooley wrote:
> > On Tue, Jan 30, 2024 at 09:59:34AM +0100, Bastien Curutchet wrote:

> > > +  ti,fiber-mode:
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > +    enum: [0, 1]
> > > +    description: |
> > > +      If present, enables or disables the FX Fiber Mode.
> > > +      Fiber mode support can also be strapped. If the strap pin is n=
ot set
> > > +      correctly or not set at all then this can be used to configure=
 it.
> > > +       - 0     =3D FX Fiber Mode disabled
> > > +       - 1     =3D FX Fiber Mode enabled
> > > +       - unset =3D Configured by straps
> >=20
> > I don't like these properties that map meanings onto numbers. We can
> > have enums of strings in bindings that allow you to use something more
> > meaningful than "0" or "1".
>=20
> Tristate properties are fairly common pattern where we need=20
> on/off/default. I've thought about making it a type. I don't think we=20
> need defines for it.

I think a type would be a good idea. I am not at all a fan of any of the
properties people introduce along these lines.

--Bq6+OXQmC9EZt/Z+
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbq5LwAKCRB4tDGHoIJi
0lI/AQC3UAgbedwiOpgsa6R6YtOYcSd54lJHs8nkKy0iGJO8BAD+J2aHBvSvPKsi
RA3BCzfTvU1ni4uZu9VFa3MgfCsZzgw=
=GQXc
-----END PGP SIGNATURE-----

--Bq6+OXQmC9EZt/Z+--