Received-SPF: pass (google.com: domain of linux-kernel+bounces-47188-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <28b1d750-fa74-4279-b292-e36cea995e80@infradead.org>
Date: Wed, 31 Jan 2024 13:44:04 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 00/28] Fast kernel headers: reduce header dependencies
Content-Language: en-US
To: Max Kellermann <max.kellermann@ionos.com>, linux-kernel@vger.kernel.org
References: <20240131145008.1345531-1-max.kellermann@ionos.com>
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240131145008.1345531-1-max.kellermann@ionos.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Hi Max,

On 1/31/24 06:49, Max Kellermann wrote:
> This patch set aims to reduce the dependencies between headers, in
> order to have cleaner code and speed up the build.  It continues
> previous efforts by other developers.
> 
> As a preparation, the first patch adds "#include" directives to source
> files that were missing previously, but due to indirect includes, this
> was never noticed.  After the cleanup, many missing directives would
> result in a compiler failure.
> 
> The second patch removes superfluous "#include" directives, some of
> which may be a leftover from refactoring patches.

[snip]

> Max Kellermann (28):
>   include: add missing includes
>   include: remove unnecessary #include directives

How were these (a) missing and (b) unnecessary includes
found or determined?
Did you use some tool for that? If so, which one?

thanks.
-- 
#Randy