Received-SPF: pass (google.com: domain of linux-kernel+bounces-47190-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <345a86d1-fb17-43cd-8547-d9379d897189@amd.com>
Date: Wed, 31 Jan 2024 15:45:36 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/6] ACPI: CPPC: enable AMD CPPC V2 support for family 17h
 processors
Content-Language: en-US
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1706690577.git.perry.yuan@amd.com>
 <3a2a5bb22f9ec853cc8762fa1795a75fa1106f22.1706690577.git.perry.yuan@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <3a2a5bb22f9ec853cc8762fa1795a75fa1106f22.1706690577.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RkpFMkQvRlN3bktKVUFrWG11cHFBcXpuMWZIdjMxSU9JMVlqRGUzVzA1UHVi?=
 =?utf-8?B?bC9SMSsxQTNsOHFIZzJ3ZHV6bHowQ2Q2Qy83K2JDanBhL1FIcm9lUlMvcVRM?=
 =?utf-8?B?SEhqaEJYbHBLczQ4RkdEZkFKdG1ZV2Y2UTBSQ3pocEZBVVQzY0huRnM0UnVW?=
 =?utf-8?B?VkprRnFtNndmTFJqNXlXNWY4dXd2dlhEbTQ0bUtOUWVDRGhxRndyUDFKMG5a?=
 =?utf-8?B?MW1IcnhsUUdoekdyL1BzS3FHWHRZbG5xL0NUTy80T3g3WE84RUw0K1loWjFX?=
 =?utf-8?B?NDd3UDNlNFZZeUwrVE1BTjZLUzhnTlU4UG5Kc0c2Y1J0dDRIVnlDM0RWS1pX?=
 =?utf-8?B?YzR6SC9GK0lXVUtWdDAvUk52dFFOM3o2R0M2bnR0eEtNNlhXNDQ3NWMwQ2Fp?=
 =?utf-8?B?aXJKeG02dFB6eVM3NDRCQ3hESUxuVnQ4QVQ1TENJNFhoOTBLZUlTT0dUNHhq?=
 =?utf-8?B?Q3pLMkl6QW9hT0htMVJtWUgrQmpjV0NxYnRpTHhTWUZMTjdRRnZPY0w4Z2NX?=
 =?utf-8?B?RGJlRUR6SkFzNFVWSnUrUFhlM3BGODdGMnlnUmdsZUNXU1pzaS9zWFNkanh0?=
 =?utf-8?B?UHRnVEZ0bE1jc1NRODBJKzNwSEovMUc3MVFLQzZFbzBNSG16KzVmZUlHN213?=
 =?utf-8?B?bWJKQnE0dHNHSVRIemVzRlRZdENCZ3dvQ0o4OTUzcHdCZ0FEVDhpeFZ1cnhT?=
 =?utf-8?B?amFHSTM3MWJFZ3J0enFCNHdmWmIxb0FBSFgxd2xQeXdXYmN3SGg3NUJwdG5l?=
 =?utf-8?B?UGJobVJvYkhaamNJL2N1QzJpWFdCMElMcVpuRmpiNXFFanF0ZkN0b2dZNElP?=
 =?utf-8?B?WnlLS1h0TnlhRWhldzJ4RVdGTWlvTlcybjVVeW82LzdqUk03Vm55UGk1U1Ji?=
 =?utf-8?B?NWE2QnlEWFJOYkd4aUNRR0hWY2hCdzVscWxpb0xxTWtidHVFNmE5WTNmcVhN?=
 =?utf-8?B?cGxOWkc4LzVtaUlEKytZeDU4TC9lQ3VVWXVzNGlHVEE5UmUxOUtydE1KaTRa?=
 =?utf-8?B?Q29jMWw3RVdnUW5KOUZ2ZGoxVDN1enUyUnZlSDZUV0s1U0dKNUJZQm5QaTNL?=
 =?utf-8?B?a3Ivc3BhbjVkakMrMmtCVmRmRG1sZUN1TjFLSGVLa3UrUXplYVJXZzVudmtO?=
 =?utf-8?B?ckdwdzlOUXBOZ0lCZ2RWZHdpQ0RDcTlmMllKN3VveWQ4NmllRjd0QlVKQ0V6?=
 =?utf-8?B?ZjB2L2EzTER3SWFNNlQ4R2xIQndzS0JTM25SS3pjbHRJYm5DL3Aydi9RaE53?=
 =?utf-8?B?YWtxZkwxZDVPRFlZc1hsNTM1UFFoVjdlVTI5emk4bU1xWHlzek1Ka2tIQ0lu?=
 =?utf-8?B?NlZ2UFpRMXRmSlBPVVlBUTI0MnlXaXpReEpaT3NQTDdUazl4VGs1MjdHSDFP?=
 =?utf-8?B?R3AzcmE3TjlxeGJLdmwvdGhlUFpHMVdjd2pSdlNYOFd0UERHd3ppRXpVakxs?=
 =?utf-8?B?Y3hGM0YxQ0N0WnJCMCs3T2FwS2F5aXVYbnNJM3gvcVkvVlNrYXFkeFIvckw3?=
 =?utf-8?B?ZlEwQ0d4Z1grVnlXMVBGUHlCaW9OZFN6ZGhTNmkwUDduN3JOT1I0a3JKa0FP?=
 =?utf-8?B?ejFDRGFmOUZvQy9vNDJmcVFjdG1rRk0zQ2xucjh4K1REOURwUG4wM1RHTlBT?=
 =?utf-8?B?aVZrSU1ZMVo2cU1BN0JlVm9rZzhWY0Z0RVByU3N0YkEwUEtUN3FLR3pPWXFE?=
 =?utf-8?B?aG5JU0FPb3MwTmZ2c1RKMjlzcUQ1dEMyVWlYcWZyL0tQVHpOVUFRaU9Xa1BL?=
 =?utf-8?B?Q1ZJdkQwSTNxUHFjaEtIS0piZVVVYWYyeWZwZ2lDL1VkMENHNGovWEZBOE9D?=
 =?utf-8?B?KzZINUhYMWY3NWpZWGxpcXpCK3d4aVBmUzdqTkN1V3BVODNGVVpYMHpKeExF?=
 =?utf-8?B?bG16TVZTUCt4SW82NkFTVHVxSTUwWkVkcnFlOEE4T2lGRVFUVjRpblFUU1hY?=
 =?utf-8?B?WjBIeEZmTHlETEZPdEM5YjZ6MEZ0WTN3RkJRalBnRFRKUjhkN29WdEFITGtT?=
 =?utf-8?B?ajJlVHN4SHZoOFp2RzNTazVxUmlzVzgybEQvbDRzVm5qcEoyckpJbmJjQ1BQ?=
 =?utf-8?B?M1NkNTNRa0MxdEV1UFpEZ3dVTDh1dnNvZGwrOHZFNXdhZ1FiUFpwNmZacllY?=
 =?utf-8?Q?995hqWvQcBAKeaQD4t7wVhLOa?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a5a85d2-841e-47cd-d7da-08dc22a5f69d
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 21:45:38.3925
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m0SRsgWTfGfClnvtd2bK/KYp6h04KBvSYiIcNCLs9EkMgjwGo73VesgZy3R21yy4ba/22TMOUE8no/NA4VRJPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9334

On 1/31/2024 02:50, Perry Yuan wrote:
> As there are some AMD processors which only support CPPC V2 firmware and
> BIOS implementation, the amd_pstate driver will be failed to load when
> system booting with below kernel warning message:
> 
> [    0.477523] amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled
> 
> To make the amd_pstate driver can be loaded on those TR40 processors, it
> needs to match x86_model from 0x30 to 0x7F for family 17H.
> With the change, the system can load amd_pstate driver as expected.
> 
> Reported-by: Gino Badouri <badouri.g@gmail.com>
> Issue: https://bugzilla.kernel.org/show_bug.cgi?id=218171
s/Issue/Closes/
> Fixes: fbd74d1689 ("ACPI: CPPC: Fix enabling CPPC on AMD systems with shared memory")
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>

One minor change above.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   arch/x86/kernel/acpi/cppc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c
> index 8d8752b44f11..ff8f25faca3d 100644
> --- a/arch/x86/kernel/acpi/cppc.c
> +++ b/arch/x86/kernel/acpi/cppc.c
> @@ -20,7 +20,7 @@ bool cpc_supported_by_cpu(void)
>   		    (boot_cpu_data.x86_model >= 0x20 && boot_cpu_data.x86_model <= 0x2f)))
>   			return true;
>   		else if (boot_cpu_data.x86 == 0x17 &&
> -			 boot_cpu_data.x86_model >= 0x70 && boot_cpu_data.x86_model <= 0x7f)
> +			 boot_cpu_data.x86_model >= 0x30 && boot_cpu_data.x86_model <= 0x7f)
>   			return true;
>   		return boot_cpu_has(X86_FEATURE_CPPC);
>   	}