Received-SPF: pass (google.com: domain of linux-kernel+bounces-47192-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a7d69dc6-a4b3-4d30-a666-66328e10fb89@amd.com>
Date: Wed, 31 Jan 2024 15:46:45 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/6] cpufreq:amd-pstate: fix the nominal freq value set
Content-Language: en-US
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1706690577.git.perry.yuan@amd.com>
 <0c7a38077a19e5055926947ea6ed64bfb7686345.1706690577.git.perry.yuan@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <0c7a38077a19e5055926947ea6ed64bfb7686345.1706690577.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q3ErM3UvUHRDTUJpTWwxVTZ5aXkwbGR5RnRWeE5YZnVCVS85MUZUVTRhNnlU?=
 =?utf-8?B?YWFCR0ljRjYvNDFrNktnSlV1RExSZWRzcFJYbElMTTdydzVNZ2J5MytNS29O?=
 =?utf-8?B?YTNhYVdBT3ljRmlhdzUyMUxHSmxsdGNlTG9MdTlrNFJ0OE5pQVMwZFdBcGdU?=
 =?utf-8?B?YjFoYTlOWmEwTTRzNG1HOERKOEM0d0VCTDBxd0YvdkNyV28zRWN5NVBSSjBs?=
 =?utf-8?B?SDBqczNTc2R4dmtyY0gxcStJLzd4RjRQb1N0b3d5dWI5M1RmVGYzbzA1Nmdt?=
 =?utf-8?B?aGwvc1UwT2RIYUgrcURRTnBSa2dCdGJZQ2FWSW1CenhQVGdPcmJCZGMvTTNl?=
 =?utf-8?B?dVMrNDUrZ0dTZVB2S2d2aHZod3JUL3BNcm1ZRThRbmJwbGdQdVovNzJQVEJS?=
 =?utf-8?B?cElkaGxGTlJIUVRmTHJ3LzRqYjFvM3VmdExXNUxoanhscEhTUDZ4SC8zSUtq?=
 =?utf-8?B?V05naXVaRXJuWkoySU9YUTJBUnNZNGY3c3Y0K09IbzVEMk1adm9UM2U2dSt0?=
 =?utf-8?B?eVNzMWJYZkJIREZhcm83K1Y5UDFUV2RlNlhZWjk0d1FnSFh1WmhRdlpKc2ZY?=
 =?utf-8?B?NytPRHNtN09xb0w5Y2o0VUdITTJwcnJDa24wbGJJTmQrdmJBRGVpNGNtN3BM?=
 =?utf-8?B?K1RacVVYL2tQV3lxZWc3RHQyN3h5dWxZaVBxNUEveTJGNXA0d09EclZRSE5o?=
 =?utf-8?B?Q2gzV05iWnRTNk9JYUx3S1MrMmtROGNLc3RodlQ4eWppTGp4Rk5YUG42S3pw?=
 =?utf-8?B?eFNtNDZ5NDBEQjcwRXJnY0tMSVRrUjRyZFFQQW1ueERja0VIeGl3UE1CcGFS?=
 =?utf-8?B?R3FPMGdXVzNzcXJsa1R0Zm1lRW5UWWd0TEVtLzRtcnZsbFJjOTdJZlZUNU9u?=
 =?utf-8?B?Y3RBVjZjSlhTMGFaRFBCT2M1NHVCVUQxdWRWbk0rUDFrVlNTL3hsSzhJK1pH?=
 =?utf-8?B?V1AwcjFqYXJvM2cyWk9MYktmY3RzZUptQkszcDJvazdLYW4rU3RYK3NITThy?=
 =?utf-8?B?dlJaMUZMOWZ3cWVlYlo5VjFBaHNVSW84R0xDbnJLUVdxYUY5TEZZU09aeXFt?=
 =?utf-8?B?QnE1QkpqMVJ5M1Bta3ZTQzVUUjFxckJlQ1ovYmtvVkorSnRTWTY1UElEKzNM?=
 =?utf-8?B?eXNSbEYxS2F6WGxJZXBtSWRIdW4rNHUvdkJUQkpDZE1GQWZicEJ6WVRUNWFk?=
 =?utf-8?B?d0daNmhZVEcrSEJKaHhCcXV6bmV3RmhaY1doZFkrWTJtMEd3MDJtd0s0cXJE?=
 =?utf-8?B?RmpYa0ZlSEI3ejYzUGJYd1JmU0Z6dU9EM1czcHNsMGU2c3Y4bUM4eFp1V1B0?=
 =?utf-8?B?a0VuWHNyREY3TlZ0SDl3MXhLaVFlcFZqKzIvOVAvekE3cm5FY0NKVU1zODFK?=
 =?utf-8?B?SU5UUUNQR1JhNkhkVGpZSlFvVE5WNmJLYTZGNklLUEJTOXVLRUUxekZvWEIv?=
 =?utf-8?B?blFucnpTaytMNmkranpXWnR5RFl0dmRReEpITlZHcDBBcWpDL0lZV25CUDI4?=
 =?utf-8?B?RlRGME5xOCtVRmNMSCtKMEJieHVldGZFN0VaanZ6UHlqUEp6bDFkY0tKbFlj?=
 =?utf-8?B?MG9jcEtiVFBVUUlXYVlIR1l4M1h1N1BLQURJZkJ5TEJEMnB5a0RLN1gwMFdE?=
 =?utf-8?B?U1lNTHFNYTY1MU1acnpYNkg0MHpyeGZZaU9mNXdxdUM1UGJhY3FVNHRlbDFK?=
 =?utf-8?B?aDVkRWR3Ukg3SGs5TENVemJ3bzRDVWR5RmphWGdRVUp0YW9oUE9VYWh3SjJP?=
 =?utf-8?B?bnRUdVowSURUNTNNb0duSTJYZzNXbUowbHlrSUhXbzl6N3pmN0MzdjlZTWRS?=
 =?utf-8?B?c2NBcHRvVVNGWjRQWWZORTFiYy84cDhyN3FjVWZoOEJFNVBpNytKSW14ZFBP?=
 =?utf-8?B?MTg3djQrOGVMWHVKejVQWTdJLzFYQ1JDZFFzczJEMms0WHNwS3UvQlA4QVR2?=
 =?utf-8?B?ZnVVOFVjKzN4QXUrK2RYQmtsM055OVNqLzNZei9aMFA5OHBITVIzY3NERjZ6?=
 =?utf-8?B?S0NocVdlYzZQSFdoM09LdVY5OEhYckhPUDlxRk82bXQxcW5QSjlMYk9la3JI?=
 =?utf-8?B?bWk1SXhmbkJSNjB3TFhiNWl5M29UbmZJbTJLRGRmQ3JwUnowdGVGYkdzUnJX?=
 =?utf-8?Q?eUTiICfQJCP3WY+ERPOEkOgxI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73149032-f602-4ab5-086b-08dc22a61f2f
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 21:46:46.4074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YSMcn5XhPnJdas+bZmr8uJYduOsSXLWo6Dn6KI02re/CjRuKRul4VtxE5bQ4wZErUdlOvHv6tJoME/jUd4VYqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8538

On 1/31/2024 02:50, Perry Yuan wrote:
> Address an untested error where the nominal_freq was returned in KHz
> instead of the correct MHz units, this oversight led to a wrong
> nominal_freq set and resued, it will cause the max frequency of core to
s/resued/reused/
> be initialized with a wrong frequency value.
> 
> Cc: stable@vger.kernel.org
> Fixes: ec437d71db7 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors")
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
One minor change above.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 2f8656f75a1d..9291a22bd3cc 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -625,8 +625,7 @@ static int amd_get_nominal_freq(struct amd_cpudata *cpudata)
>   	if (ret)
>   		return ret;
>   
> -	/* Switch to khz */
> -	return cppc_perf.nominal_freq * 1000;
> +	return cppc_perf.nominal_freq;
>   }
>   
>   static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)