Received-SPF: pass (google.com: domain of linux-kernel+bounces-47194-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <67d61b66-4e3b-4b59-af3e-151c2af937bc@amd.com>
Date: Wed, 31 Jan 2024 15:47:29 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/6] cpufreq:amd-pstate: initialize nominal_freq of each
 cpudata
Content-Language: en-US
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1706690577.git.perry.yuan@amd.com>
 <5d5822a829045c02a37d6dac81756be1312a1ac5.1706690577.git.perry.yuan@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <5d5822a829045c02a37d6dac81756be1312a1ac5.1706690577.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dk5ULzVER3AzcHdpWDRJUjl6TG1jUHNXUnIzWE8rS3dKd011dy90Um1kL2xq?=
 =?utf-8?B?aENxZmF3czhNaGU1OUdqVFkvUWFETC84VVpZT3lFR3NBR2RYSERTNmxvc3JZ?=
 =?utf-8?B?WDNDTDloZi8rZ2twdVo4SHVHWmRETS91NjNnVldEYnBYclFxMElsRytKTGcr?=
 =?utf-8?B?c0M5V0xrblZtSGNBUHFwc0NobzF0SGRKRnp1S2xqUEJkMmQ2ZGhVWG5SQ3Mx?=
 =?utf-8?B?TWdlQ21qSHZCTDNaSUM3T2hUb3Q0cXdZZ3hwdkhUcW9jWllLdkVaUi9lV0I4?=
 =?utf-8?B?NGJRVlB6cVpjTEtPZ1Z3T1M5YTdWVG5VeGZLcmFrRy9ZY2ZTT0wrblVnb0Fs?=
 =?utf-8?B?N1QvREFOWmg0ZVhnUUFVRHA2SC9VOTg3KzNKTjJuZnlTdnBiSjhUMEZYcW1k?=
 =?utf-8?B?Q0FLdzlXMWJDalpibGViQkFEZGdySy9QUVB3M0NaRWVjU3Y2dmUrcjBId0Vl?=
 =?utf-8?B?TmMwMys5THAzaExoOVU1UEJpZFlRcFFmVHZIZmFwVnRQeWMxZXRYTXg3a2lO?=
 =?utf-8?B?MjYxa0VjMkc0UkZ3VW1sWG9NMjhjY284WjdMc1ZSQnRscXFVWDNlRjhQMzhm?=
 =?utf-8?B?eWxiR0hUMXFxZkx6aWdGcHZpSVp4QmNPOGtxUHZaRW4vTHpJbENjeTQwbkdK?=
 =?utf-8?B?ajhkNE1PR0lQaVBKQ0x2RmIxbUI5dVpYSmRpNUJmS3UxUVc3Rk5yQnJyQ2pV?=
 =?utf-8?B?S00xR3M0TkxBeHBlUlB0VXZCUG9lTFc2WTVrY1NFd04xeFltWExMMk9GUzg2?=
 =?utf-8?B?TWJhVXRmODBOazh0SXpjUEZsZ0RRc0RjdUt2WXNTUTNnbmg3K1BVckR0ZmRv?=
 =?utf-8?B?VkpkcjhFYVlRMDRwMUw5ZDhUMlh0cm4xZmFZVjhXeDNSSlNQTHNjb21KN2NI?=
 =?utf-8?B?a1dVd3h6VkRCV3JkRmQvOWtQeGt1YTUxZWtFTFZkelNSaEkzMnVidStIMEc2?=
 =?utf-8?B?L2gzTjlzTkhXaytuQUlWbnBFUEZOY1dXMlVNMnl6bGZsR2F5dXN4elhxd0Zt?=
 =?utf-8?B?aXpIUVVQa3lYV1RHZU04S0Njc1JZK0hybTJZVmNwbUJ1N2lDM3hlcWgxMDht?=
 =?utf-8?B?TG1ScTg3MUloNEZtMHJSR0NqZWJ3YWNhRk80VTNyMVRZUVpZaHNFMTVieENJ?=
 =?utf-8?B?SnVuUXBURnpiWWxMU0JubVo3K3dOVlFBaCtuZEVtdDFYUXN2elJKeFZMdkVL?=
 =?utf-8?B?aGNYZTJSOFFoY2hsR0syblpmbE5qR3ZyeEtBckF2N212cWZVQVZaQ1FJbWRZ?=
 =?utf-8?B?SEhkeHhCaGFQSmRQejFGN2VlUHRETkF3QnNoN3JSK1BmWmFJQm5pUmhEeFVs?=
 =?utf-8?B?SUYxaml5V2VsMzZQQmRxTDlSK09XQm9VZ3VQbzFTKzYzQkh6UTR3NFJZTUZt?=
 =?utf-8?B?c0UrVTZUTlREbEc3aE12ZTBCOGJMc2dKYTdwSk1Yams3bGdMc25WVVRIdDlF?=
 =?utf-8?B?SE9GVDRkRmsvTzcwdWJFaUM4d0VwTzlLRmxXb0RNcUR3V095Rm9jT2g3MDBO?=
 =?utf-8?B?T0t1ZnI5ZW1pOUVIVG1vdjVUSHozNTFVcFJQNzl1Rm1vajJIZEhhM204RStF?=
 =?utf-8?B?OUNLbHVNaGpSejdpWGFtdXFZR0xkUmxuQnh5bUFVTHFRaGQ0L2Jrdm8rMVBj?=
 =?utf-8?B?MTBlNjZqYjh5R2pUL2pGd3l0MVExeFBBMnZzam9MaFd6a2wwNmF2cGlXbXRU?=
 =?utf-8?B?YVZSaHpQcEMzN0JwT3A1UzdKWllDREN5c1lNWW1vU3QvVitDK0czNk1ZR3ZD?=
 =?utf-8?B?SDRxVXRTQll3ZGkwL0VBU0laZlZQcVpGS1QvOXphTWFBRlBFSnVJTnJzRG9D?=
 =?utf-8?B?VE9ROW5YTWs2cUpDSGdCWHhIOFVQTkNIdnl4cU1qOUphY0hHUDgyZm9hbXps?=
 =?utf-8?B?R0o0K2RkZ2lzdnFjdlE1bmE4M0syZVBOQXZ6aEdaY296TzlqWjU2cjVzV0lK?=
 =?utf-8?B?RmtyT3RxLytGUUh0aENoVWpGQzkzNFJsTXdCK3RpVDg0b1BRSEZsRUtpTURP?=
 =?utf-8?B?Q1JrZk4vemxPdEFvaG9ZNFdDWEEvMXY3TEFieWVzdmIzRVlzNmZWYlllRmg5?=
 =?utf-8?B?YkxBTFJjS0MyN01hZ2laenFuQURJV1ZpbGt4MGhlUThybGJ5MENlQUdGZzlW?=
 =?utf-8?Q?7pv9wLsCSJ4gBefJGzaf4keqm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c04febd6-53be-4f87-0ba8-08dc22a6392c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 21:47:30.0467
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7us52TOv3R+xwznI9wfXuADgJWBv1rxNhsGPr11zKoLDKda4KPTe3ImwRS3ywgOK4cmc4OFQp38/RR6eJ7cjNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8538

On 1/31/2024 02:50, Perry Yuan wrote:
> Optimizes the process of retrieving the nominal frequency by utilizing
> 'cpudata->nominal_freq' instead of repeatedly accessing the cppc_acpi interface.
> 
> To enhance efficiency and reduce the CPU load, shifted to using
> 'cpudata->nominal_freq'. It allows for the nominal frequency to be accessed
> directly from the cached data in 'cpudata' of each CPU.
> It will also slightly reduce the frequency change latency while using pstate
> driver passive mode.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 26 ++++++++++++++------------
>   1 file changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 9291a22bd3cc..db7b36afdce2 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -600,7 +600,7 @@ static int amd_get_max_freq(struct amd_cpudata *cpudata)
>   	if (ret)
>   		return ret;
>   
> -	nominal_freq = cppc_perf.nominal_freq;
> +	nominal_freq = READ_ONCE(cpudata->nominal_freq);
>   	nominal_perf = READ_ONCE(cpudata->nominal_perf);
>   	max_perf = READ_ONCE(cpudata->highest_perf);
>   
> @@ -639,7 +639,7 @@ static int amd_get_lowest_nonlinear_freq(struct amd_cpudata *cpudata)
>   	if (ret)
>   		return ret;
>   
> -	nominal_freq = cppc_perf.nominal_freq;
> +	nominal_freq = READ_ONCE(cpudata->nominal_freq);
>   	nominal_perf = READ_ONCE(cpudata->nominal_perf);
>   
>   	lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf;
> @@ -712,13 +712,15 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>   	amd_pstate_boost_init(cpudata);
>   
>   	min_freq = amd_get_min_freq(cpudata);
> -	max_freq = amd_get_max_freq(cpudata);
>   	nominal_freq = amd_get_nominal_freq(cpudata);
> +	cpudata->nominal_freq = nominal_freq;
> +	max_freq = amd_get_max_freq(cpudata);
>   	lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata);
>   
> -	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) {
> -		dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n",
> -			min_freq, max_freq);
> +	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq || nominal_freq == 0) {
> +		dev_err(dev, "min_freq(%d) or max_freq(%d) or nominal_freq(%d)	\
> +			value is incorrect\n",	\
> +			min_freq, max_freq, nominal_freq);
>   		ret = -EINVAL;
>   		goto free_cpudata1;
>   	}
> @@ -755,7 +757,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>   	/* Initial processor data capability frequencies */
>   	cpudata->max_freq = max_freq;
>   	cpudata->min_freq = min_freq;
> -	cpudata->nominal_freq = nominal_freq;
>   	cpudata->lowest_nonlinear_freq = lowest_nonlinear_freq;
>   
>   	policy->driver_data = cpudata;
> @@ -1266,12 +1267,14 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>   	amd_pstate_boost_init(cpudata);
>   
>   	min_freq = amd_get_min_freq(cpudata);
> -	max_freq = amd_get_max_freq(cpudata);
>   	nominal_freq = amd_get_nominal_freq(cpudata);
> +	cpudata->nominal_freq = nominal_freq;
> +	max_freq = amd_get_max_freq(cpudata);
>   	lowest_nonlinear_freq = amd_get_lowest_nonlinear_freq(cpudata);
> -	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq) {
> -		dev_err(dev, "min_freq(%d) or max_freq(%d) value is incorrect\n",
> -				min_freq, max_freq);
> +	if (min_freq < 0 || max_freq < 0 || min_freq > max_freq || nominal_freq == 0) {
> +		dev_err(dev, "min_freq(%d) or max_freq(%d) or nominal_freq(%d)	\
> +				value is incorrect\n",	\
> +				min_freq, max_freq, nominal_freq);
>   		ret = -EINVAL;
>   		goto free_cpudata1;
>   	}
> @@ -1284,7 +1287,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>   	/* Initial processor data capability frequencies */
>   	cpudata->max_freq = max_freq;
>   	cpudata->min_freq = min_freq;
> -	cpudata->nominal_freq = nominal_freq;
>   	cpudata->lowest_nonlinear_freq = lowest_nonlinear_freq;
>   
>   	policy->driver_data = cpudata;