Received-SPF: pass (google.com: domain of linux-kernel+bounces-47213-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 31 Jan 2024 21:52:02 +0000
From: Mark Brown <broonie@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Lai Jiangshan <jiangshanlai@gmail.com>,
	linux-kernel@vger.kernel.org, Naohiro.Aota@wdc.com,
	kernel-team@meta.com
Subject: Re: [PATCH v4 09/10] workqueue: Implement system-wide nr_active
 enforcement for unbound workqueues
Message-ID: <6f9b1f85-560a-402f-a813-7962218dce96@sirena.org.uk>
References: <20240125170628.2017784-10-tj@kernel.org>
 <CAJhGHyAuoGNmaaDa0p+wiJMprXYVYnVV75PS4+kPy-fsPJVH8w@mail.gmail.com>
 <ZbfrEx9nnkr0FnZE@slm.duckdns.org>
 <CGME20240130223021eucas1p1172b060d53847b8b77f6455d6257528e@eucas1p1.samsung.com>
 <91eacde0-df99-4d5c-a980-91046f66e612@samsung.com>
 <ZbnGbC8YM0rcI8Jm@slm.duckdns.org>
 <20240131041205.GA3517117@dev-arch.thelio-3990X>
 <ZbnIzqmClhAvPxKC@slm.duckdns.org>
 <20240131042031.GA3946229@dev-arch.thelio-3990X>
 <ZbnLk7pZbcODRNER@slm.duckdns.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="8J6gE/oZudS89Qo6"
Content-Disposition: inline
In-Reply-To: <ZbnLk7pZbcODRNER@slm.duckdns.org>


--8J6gE/oZudS89Qo6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 30, 2024 at 06:24:51PM -1000, Tejun Heo wrote:

> Ah, I see. How about the following?
>=20
> Thanks.
>=20
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 9221a4c57ae1..31c1373505d8 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -1510,7 +1510,7 @@ static void wq_update_node_max_active(struct workqu=
eue_struct *wq, int off_cpu)
> =20
>  	lockdep_assert_held(&wq->mutex);
> =20
> -	if (!cpumask_test_cpu(off_cpu, effective))
> +	if (off_cpu >=3D 0 && !cpumask_test_cpu(off_cpu, effective))
>  		off_cpu =3D -1;

This commit was also breaking at91sam9g20ek (and still is in today's
-next), the fix here gets that booting again:

Tested-by: Mark Brown <broonie@kernel.org>

--8J6gE/oZudS89Qo6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmW6wQIACgkQJNaLcl1U
h9A8PggAhbi2pIn/tX3EJG4jko4rmlpT5Iq2q59qN57s02VMcGKN/LdKhO7TBCF1
V/ezYDG9a3maiQKWRJd+3nc/ZKVDFdjEUprvnR2Y7lvNqQcOeionUookfqA3EIhj
qVBEV0jnBMXtVwOs18JMN8rwwLnNwcSXshnvdQZwzDX4yNO3x/KXsoEShnjrbsB/
7uRq1KTdafnPvB4ADVLf3L7NOdqEDfjexaXdxEcvBWhA14HDs99ZWiQPASd0EDa9
LD4uFS5MLTf7oah6wVKXCDRumYeAQXqvjh8/bH//WsHPFOk1Sb2ADliE3v380SQg
a5174RT31J+WnI4krNRlDs7ERIoZuw==
=fiOl
-----END PGP SIGNATURE-----

--8J6gE/oZudS89Qo6--