Received-SPF: pass (google.com: domain of linux-kernel+bounces-47212-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <9f6bea2e-7291-4cf8-a407-8c13653ca10e@amd.com>
Date: Wed, 31 Jan 2024 15:51:33 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 5/6] cppc_acpi: print error message if CPPC is unsupported
Content-Language: en-US
To: Perry Yuan <perry.yuan@amd.com>, rafael.j.wysocki@intel.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, gautham.shenoy@amd.com,
 Borislav.Petkov@amd.com
Cc: Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com,
 Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1706690577.git.perry.yuan@amd.com>
 <a6c3790105fa30e89f39f0dccc7d699f5c1c30b7.1706690577.git.perry.yuan@amd.com>
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <a6c3790105fa30e89f39f0dccc7d699f5c1c30b7.1706690577.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YVh6WlBaNjZjcEt2ZjQ2THhjRmsveFo0SEFsR291L2JYa0FHL1c4QWt1cHJJ?=
 =?utf-8?B?SFMxaGhzVnJnQWpJS252d3RTWW5qeVc2VkRFY0tuQURiTmorZFMybXJ5Nnpx?=
 =?utf-8?B?a3hKV2pnVG9sM0xRemlkZERCcmp4YjhLQ2R6YkZXUTUwMDl0dEgzczRYbkk5?=
 =?utf-8?B?MkJCcWZGWmxqK3VGTi9VVlowMVNMWXNEcVJ1RU12ckR0RE9mSHAxNFJzMUNm?=
 =?utf-8?B?UmYyRnZtSGp5d3JtOEZvQmVlWUg5R0VhMU5ya2M0MnZydS85WEVaRzNiQVBu?=
 =?utf-8?B?cmF4LzdXcWJRamlIczVLdjVGdDlyV2JNSWJ4ZkMyVGk1Z2IwSHdyMVRWV1B4?=
 =?utf-8?B?ZjFEVGZtRHZzRW9aMDdDdUducFc0SUQ2bGE5Z2M0Yyt5cEw0QXYzek9KV0lm?=
 =?utf-8?B?LytJcmd0aWRpdEZwbHhyVTBoUVJUc0NuenZGZVdCcmg1TU5PQ00ycFpwRXNL?=
 =?utf-8?B?UUFtTUhsWnJ5Znh5NmlRSjdQRmV0OU5jeXVMbXNPclFFclkvdEMxSFdUWlBs?=
 =?utf-8?B?RUp6aXhGa3NuTU1PRk9PMTJCdGtTbGlJdEFxUEFBSXlDTjFxbENtR2ZtTEhK?=
 =?utf-8?B?ZGZwTEtGVGpqMCtHWklaMjR5eWE2YzNVQUNkWEFiZjdoWWhKbGo3dzQwZVJF?=
 =?utf-8?B?YzV2L3RmYmZKUkMzME8zdzVXdHRnN2VxbUlaVW5Db2hRdTFKK2k1ajI0ZGdD?=
 =?utf-8?B?YlIzcUw5dXdOS1hQR05TN0lBRllmUDBwb1FtVDZjTFczaWVZMEoydXd5MVBj?=
 =?utf-8?B?dG15UDJ6VzdndEtqUUhjKzFLSWxQb1dqcHhxTnZ2Z0NCZ08zeng4ZkdPSCt0?=
 =?utf-8?B?d2x3SGhNTGMzYTdORXlkK0dLaGI1amV5QlJlQ0lhVHdlTmxIUEEyNjZTZXlU?=
 =?utf-8?B?eXpOZU01SStKTjJKN2JZMnVKNzNIazlHVUhDVHFFMDZWa1cyZk9pTXE5Tk5n?=
 =?utf-8?B?MHl0RXBSYVZTUDFHZDhYb0Z0MEtkMGhHTWVpQWMrdCsxL3ZQUzZzY0RQWmVs?=
 =?utf-8?B?WmFLZXo3YzVaQ0NtVEZCU3g0R1cxZkZsY0c1YTIxNEN3V0FxbDJlR1ErYS93?=
 =?utf-8?B?ZkpvWWtJek9NeFdKYlo4QlpxRUdUbU55dWF0NnlNbHVWV09PSVAyV1ZVMVFn?=
 =?utf-8?B?Q2d2RHZtSitrdUVxRk5Pb20ra29QOEZFeDNLOUNSc1YvK1JxQmY1NTdhbDZr?=
 =?utf-8?B?cVpWVUViRE1SZGxxMDRBTW14WGFtWmZFY1ZXTWE0VEMzTVJaK1ljM1JSeEs5?=
 =?utf-8?B?VnpOcDQydGU1RjJTQXZSMnpPNlJ5MnJNcG8rczZRRng5U2gxRzNhU2lkSGpS?=
 =?utf-8?B?OWtOTm5jV0gvc3krVFQ2NjFzT0JjQUlJN3BqMjg3aUpnbDNvREMxd253cW4v?=
 =?utf-8?B?MU43c2VMMXcweXl2aWNlOC9jODI5aVVTelBhM0VhK0p4UWFXbUFoai9XSDFh?=
 =?utf-8?B?V3BPb2QxOC9XQkk4YmxYc0ZvUHUwbU1KZ0VESUt2VnVNU0VUUDBWVTh6UTFW?=
 =?utf-8?B?YTFkY2xqQW55VzdKNlhXcEdSWnc4VnFOVDRHRUxCTVRnYUJJQ2k1ZDIvbjZm?=
 =?utf-8?B?MEsyOGZoU3J5eVVkVTBQOGJwMFdiL1VWL1pTWlZRWTJ6OS9JSXU1NFlkYTgy?=
 =?utf-8?B?MTRoZiszMSsvZnZmeEFPMm5TQkEyVldKUk1vS0dFREZBL1h4NnFGMU5jNUFq?=
 =?utf-8?B?RElwV003Q2V2SzZtSVlpRER0RnE5MzRHdkViZ3ZuUE1TYURrUnRCZnk0bUdz?=
 =?utf-8?B?MTBJbzYvWTdIa3RJSzJ6R1VrdkdJKzBZZEN3YWF0WWlDTnp4NCtCQnRLOXBi?=
 =?utf-8?B?TmtmM1FKZmNXQzJsVUxwbmoxcFNTcjEvanE0UnNSL0dhbGtFckFORjZadnIz?=
 =?utf-8?B?MnFybFlpWHl6NElKc21Ta0o0QTZSZGVFU29rWUNKbU5IRmhIaS9Rc00zSTlR?=
 =?utf-8?B?SktKOVB5YzV5ZmFIV1ZocThHcUZzaTFwbFJLVThZZThsV2d1cHV4U0QyS2Zs?=
 =?utf-8?B?TEpTeG1HZFpHNFpMdUtPekVERm5QT0RWVDdLQ2N5SjhwakRWSlF3eGhQZU12?=
 =?utf-8?B?elB0RlczSG13LzkyMzJDZEdTbU9oWkRqUGRhdFF1TVhLZXFjaEZzdzQzMnJh?=
 =?utf-8?Q?6p9xOILIM5kXOaID+KhRRxyHp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1c23047-f14f-4590-97fd-08dc22a6cbcf
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2024 21:51:36.0560
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: idtFhHtrCNdr5ggtXbvyeR0yIivcD6FVg5AGJHjn1zwpLG3jNX3sLoArkfDqH55dYE3qLBC1PI8xze5VzetJHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7630

On 1/31/2024 02:50, Perry Yuan wrote:
> to be more clear what is wrong with CPPC when pstate driver failed to
> load which has dependency on the CPPC capabilities.
> 
> Add one more debug message to notify user if CPPC is not supported by
> the CPU, then it will be easy to find out what need to fix for pstate
> driver loading issue.
> 
> [    0.477523] amd_pstate: the _CPC object is not present in SBIOS or ACPI disabled
> 
> Above message is not clear enough to verify whether CPPC is not supported.
> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   drivers/acpi/cppc_acpi.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 7ff269a78c20..217c11c12b57 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -676,8 +676,10 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
>   
>   	if (!osc_sb_cppc2_support_acked) {
>   		pr_debug("CPPC v2 _OSC not acked\n");
> -		if (!cpc_supported_by_cpu())
> -			return -ENODEV;
> +		if (!cpc_supported_by_cpu()) {
> +				pr_debug("CPPC is not supported\n");

I would argue this doesn't add any value to a user.  To help a user it 
should be "CPPC is not supported by the CPU".

> +				return -ENODEV;
> +			}

This whitespace is wrong

>   	}
>   
>   	/* Parse the ACPI _CPC table for this CPU. */