Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1979282rdb; Wed, 31 Jan 2024 15:37:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IHB8spT/E4267VU8veu85WU7d7gVT+zcHILCzrNn8FnvE8ZkUqD2q6ffsGr5SIg7LoB98io X-Received: by 2002:a0d:eb48:0:b0:602:d17a:7cb8 with SMTP id u69-20020a0deb48000000b00602d17a7cb8mr3235879ywe.11.1706744223853; Wed, 31 Jan 2024 15:37:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706744223; cv=pass; d=google.com; s=arc-20160816; b=T+0n/EcsgbqCAFeIJmtcax7kiLlBDRhtX0UXL9YPNlNaCkzghVCKmICn/TMFfuKsx/ jGarGPwEPT6Dwv54oukPCzpUjP9O1HfnRFVr4Zv/I7RSYE8B1Kl4BBqx3W4T4/D6TXbJ nHlzQ+s8H2B625c+c44liDEPuJ2ghH7LrGTgnm47CwgKnKIid+ulw7QcmaVMjA9+A7Ip 5m8h09dGmbI9K89yl8gYRDUPXr6c+7K33T8IzqC0C3S23T5Jh986WOJmZtE45aDpgVvA mpYV2BPZ8ZnAdSOgCp20al/liCb5Eikjcj9vnN0b1LfmhILfRXyv5tie+eHo/6TjNC+v FIBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=SRM+ZkTQopoKjEIsOT0GRbY/yEckJ1SCXR2I6jeUaqk=; fh=N/utkcGN6DBxUZnnlaBkQIDQsezK5MXgm6JusClZz8w=; b=y8nBhkJB5C0zS/v8hkEz5p1nD7LriRQ8jKaM5/7pOrdXNqRZ57xOjkDoR9w+OX1l2m /qZPyjyL3s2yg80s3QdZOVbt6FhlijfzL8pTwPjmhdM6MLMKGeTZ3T8qHWYbyBAsaXJC y5OJvS+f0G73ZQRaOzRd9wlOdbpEF7tCbxAuobLPVFLFBT3MSi+8nq24SaYQKSxSOBjf Q8PsOMxV3k+AucCzzOzhyxXZHgg6WKRsDPH38qMUlvVhVQ6tkeE3IZ9/OEK7//opjzYM KS6Yegt0NqsN+ixafFoaq43cZJh2EfoG3EyiS4VwRKAflT84j5jF4esNl1iLWmtKMQZx DPKQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Mhgnv3KH; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-47373-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-47373-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=1; AJvYcCXcZU0SLQPuST8Y0hoPkVhU/O9zOgBOjRG0PzxsYm7tVmw93ax4da206Hg0bGjnkjevu04DnrNknu0jcfDQAS86YDU+YciYcR3oTG0H6w== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id h26-20020a05620a21da00b00783fc517e95si7964097qka.413.2024.01.31.15.37.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 15:37:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-47373-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Mhgnv3KH; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-47373-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-47373-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4D6981C22E8F for ; Wed, 31 Jan 2024 23:37:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ED6A8405FD; Wed, 31 Jan 2024 23:25:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mhgnv3KH" Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C171C3B195 for ; Wed, 31 Jan 2024 23:25:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706743543; cv=none; b=hxTfHLXrqLG4ec2t7UiyEdxi0gFUmTd7uOwVCfUbEcQEtCUvBj70Ayx5oBumFLQH6eol8u+RNkCdYckgqHo3Tomn8qbVJCspkC7U+W1CuMRK8llLT7r3C4DFojsqNEcSnD9zThVLzO9prrH4ht1kgn5xhcRfsYT2Y3CntPg1QCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706743543; c=relaxed/simple; bh=SRM+ZkTQopoKjEIsOT0GRbY/yEckJ1SCXR2I6jeUaqk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=BwDetnutfxAaESY/j7H/bEJmSNI9LvYQSgKGXC+yGth5ITNhb35BeIbZDB3V2DsUC4FVuKT0hYquHB4R1rfmKtYLUbM1kp4iBstXaPV1UWVD4nkdyifZ7NFfE142P+bjhk5YAQyE7PbUs4UpvrtaKpCm5XYDyGRGB/vMAoWwsUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mhgnv3KH; arc=none smtp.client-ip=209.85.166.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-7bed8faf6ebso13621639f.2 for ; Wed, 31 Jan 2024 15:25:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706743541; x=1707348341; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SRM+ZkTQopoKjEIsOT0GRbY/yEckJ1SCXR2I6jeUaqk=; b=Mhgnv3KHFMLUVgP2YJxrdiiuA0BPCnQzQkgKndiJWhSHTwmdlZaWvMTX/Y/+rYoVSl DntqYZvFvusNXX1YPzz/bG3d4lDYadcJhgqFto1uGO8hPXjWqUR8TDp4p+9/G3QQXkbo cIsGk76Epok0nOP0LDR1jOBnyKwrNmasV1YkhYDgBJDcGwziAdtNnsGgbU56vomawlem C7Yjh95uj+bOUlcCvCAJqqj/qYEjB4b7yN+jN/+Pv6yJZiyQg+SpUIIUpk6LYDi4OZu4 kxBYRpXTLGEcMM3CdlN4js3sJ305e3HJm21cVbzLCC10/AwaZbWV8kgjt/NygKBwyVhK IOqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706743541; x=1707348341; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SRM+ZkTQopoKjEIsOT0GRbY/yEckJ1SCXR2I6jeUaqk=; b=HhjQ7wsPiMHkYmMO64YxC8s9H1WJ9NignKZqYIIbc212gXXtsqJi6kidwLjzrhlKUR HpIE2a1C/FCnqvMEWJY6i4TWFxs2m05C6+2EjexhiyDEzMa6IDhCdFq5AYjFgq6mJ/1x xMaa9zkqBC7ZZp8OpqUJGEhrUsGPEntlb1q+8e0z1h1OmS+63fLG4Ekr2o92Gw5X20kA iS1lwpMz2PDE27pI8zI93pxJ7kPsDKITDeRf5iVM+WqqMiCCKiD6RKRNl1QXfE7aswkB ui2pWGEM1Mh16FP1wkLgF8nrk7yScx0+ofFG2p7RF3ik3x8BEqo4TqhGsTlLxIL/suzg sGRw== X-Gm-Message-State: AOJu0Yz0LrZU+8U+3zB0ZhVvHsE3CtazSXqCzgtPWclD+yiNIL1RGy8B cNTIJ5Pb+zPIBqiXVBkpcJOD9yNZix2/lQnfo0k1cfYten4v0nHv+3uvbQxJhFLsALDeZvs2GUU 0P09VuZB/vYTCKNwOJxMtY2Fph5c= X-Received: by 2002:a05:6602:3143:b0:7c0:26d5:8a68 with SMTP id m3-20020a056602314300b007c026d58a68mr2803806ioy.8.1706743540796; Wed, 31 Jan 2024 15:25:40 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-18-hannes@cmpxchg.org> In-Reply-To: <20240130014208.565554-18-hannes@cmpxchg.org> From: Nhat Pham Date: Wed, 31 Jan 2024 15:25:30 -0800 Message-ID: Subject: Re: [PATCH 17/20] mm: zswap: function ordering: compress & decompress functions To: Johannes Weiner Cc: Andrew Morton , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 29, 2024 at 5:42=E2=80=AFPM Johannes Weiner wrote: > > Writeback needs to decompress. Move the (de)compression API above what > will be the consolidated shrinking/writeback code. > > Signed-off-by: Johannes Weiner Reviewed-by: Nhat Pham