Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp1981570rdb; Wed, 31 Jan 2024 15:42:54 -0800 (PST) X-Google-Smtp-Source: AGHT+IECWDcoN5lBiKPB/o42JSSXbYY79A56L1IKEebcjOi7rEZ2F0Bncl1PXtTH2pNXidMQcEBG X-Received: by 2002:ac8:59d2:0:b0:42b:e340:e45c with SMTP id f18-20020ac859d2000000b0042be340e45cmr942961qtf.6.1706744574531; Wed, 31 Jan 2024 15:42:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706744574; cv=pass; d=google.com; s=arc-20160816; b=WEc1eqIlUywMr7XcI+Wpawgx2k6C2sJQrozEnY528NrVjq0WDbtadXTKgNAICy2eTI ZmfROGOzBAbIRfnlb9V4EFwpcpGY/65lAhYlUvArnZREpSKSSWXdGkGwPvDp9vpU8xet cDWXP33qHHJiUaA7XZ1sa5iuSbrBGC1Huwcaz8bKKJBvAzgZFhBc6//biDDZVuq3EGVC BEGOobtEYGeqJlTlNdeiYib3piMZQrQq5ZtYeCg32d69Ba0r3+DhvEeeRnfi4PRKjX7w cH1I1LG/IHdYMZNwSCsr3BFzkt0kVrOivsaFZBqZjhrHbm+/F4cKX7oJQN5+Cr924ATi OgcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=8L4jEua2PKYDRUm8Nwkw1/0a+FDetF9qtz2GcaOTMnw=; fh=0SXbD4lGGq+fQ1o2dygVy6BX+DTy8XphfJkuAc0ICSY=; b=Ac7grZGjU8sKGJoxbFqDwn8vCIqKE6sEgTuNWEDavR09L8heZGOlN4CpWkzD3D1+5a BsBJpuhWeex45i3xIJGbBB+0RWlqVoNJlG6ZlJERopSFgbbKD5rV8mLMrkFZfURdy/rE D6jSk97WkGHSA1U5GwEKrL+7VxsHO9M5B1BiUWADwAeg0f2aqKaCOkc8jAE4Cw+3wthO bCnhYHxDY+P7n68O+WCSUyytvI+nn/uX2Aa9yunJT/yDI3szz8LMDVB7jkMHgWydOc7Z QQ5w+XLbe1/RMdS7VxZ4xzMVLzV4+Bdirf2w3l/EMY3typ4D49moCe7PhYHQMYfvtAeY idCg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=YPdDSW85; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-47386-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-47386-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com X-Forwarded-Encrypted: i=1; AJvYcCUVhFw36C/mwg6Jgt5PirIFTP4mGoePsh4+8In1+O/BGenGcLtj+uYpIyEhB+dDPuqhUpfyr93cCEr9zzZJy652NAOW0bmeKz4X1WlaAg== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id y10-20020ac85f4a000000b0042a2e4e2341si13180296qta.780.2024.01.31.15.42.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 15:42:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-47386-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=YPdDSW85; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-47386-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-47386-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 047C91C2243D for ; Wed, 31 Jan 2024 23:42:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6B9683A8DC; Wed, 31 Jan 2024 23:37:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YPdDSW85" Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36EC31E48B for ; Wed, 31 Jan 2024 23:37:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706744271; cv=none; b=RHZ8e1HMLl6ZOvAnnYYeG0v6mzMVyFk6ufUfCvmAn/bMc//jTXU2ih8nxw3nWWdraiTyJ7PI6mXTCEO32+/eMDyCDozcmUSQj8O1vicFV+N7kkJACTW69HIgqRGzlJbAD48ld2ZTv1eMgeLCJPKN0Ri7AO6G0aVGfXCUKBNORp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706744271; c=relaxed/simple; bh=8L4jEua2PKYDRUm8Nwkw1/0a+FDetF9qtz2GcaOTMnw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=lkX0gxgE6xlEQDH73bInZt+ztW3jE8TRqx/FGyO89plTDdEuS9vwdvTXjpejvy3rp+Gtaj7A8gbO8uxlp34zNHpVYfsj6kyr6nsQ0F2Dc49/T5WHszTb93QiFT+ctKMprkT6YBzduKRpAhGdJCv4NELln5MgNyfFhFxN2mTmSDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YPdDSW85; arc=none smtp.client-ip=209.85.166.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-f48.google.com with SMTP id ca18e2360f4ac-7bff28b2937so13917439f.1 for ; Wed, 31 Jan 2024 15:37:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706744269; x=1707349069; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8L4jEua2PKYDRUm8Nwkw1/0a+FDetF9qtz2GcaOTMnw=; b=YPdDSW85NsXCHrenOIOw26EK8nsuJaJT763w8t+E/syMgcTb97F8eRI9J2LYsCyb/L UhKUi4pWksRpm2KuegCrCr8C/ZmvbvXdTE0TwNhQNnnpJRbESQiXFeHHX6tf/RsgNZDZ 6GG9uKn0JHimJrLRJbupykw9Dgi4JGdOD4fLmaz5GMhQk/U+qChcBAUztJZ9Mqt4HFJd PkCCXleLREcPvB2Er1EgrvmPGhz49CxTazJAlg1NBxIX13hZB2O92JeVwUKn1sLPJtTx MKKRBoug2PMKvp6B/qZTR5xjy/sfhWKwUAJnRTsJYwT0dLcq+xXgxnL/RA8YW7NieThe hxoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706744269; x=1707349069; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8L4jEua2PKYDRUm8Nwkw1/0a+FDetF9qtz2GcaOTMnw=; b=msEMvmsY7Jo0xkTozDCmfa4931ap5tlJe4jGb3mxhu3ZCs3hjPnHS9is5ndGCcy79h OjNelbM0SNFqmifRy5sRTU8l/RGymtEw9OpttJqkOr8zmPJZ80zuVQqozQu/M4x54pgF CIcnRYEI/vixdjObAAIp+znx7EO+DOAFrqhjPF5m1I3hJtlPzwGfllOmIwj3jaHyeO7p tqoIh0gOTv2Y30ZvfUApjjE7bLZJNg+jbd/Z0QbEVL/GxlkU5f8Zpps+rqx7PSe/C/Xz //Ig6BnpKNwRJLZVtBnTMHOoKMWCPxZzZYSMuW8Hg9HXArmtrU8qpIZHIeS4l5QpKLVb JFag== X-Gm-Message-State: AOJu0YxEAnNPQi9RSX02yj5InCUDVKnVX4iTSO5TfOtYOn8QZ2WjFJ88 seRSjzftrsAcqHmCFegiSYZDxfiDvVP72nZS1ha/IpTkw0UHDrVLQZrJKK8ArwEAAZUtECro3o7 gZYoQROHk3fHepMXCh3DFPgSfvJQ= X-Received: by 2002:a5e:8304:0:b0:7bf:b56c:ac25 with SMTP id x4-20020a5e8304000000b007bfb56cac25mr572354iom.0.1706744269379; Wed, 31 Jan 2024 15:37:49 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-21-hannes@cmpxchg.org> In-Reply-To: <20240130014208.565554-21-hannes@cmpxchg.org> From: Nhat Pham Date: Wed, 31 Jan 2024 15:37:38 -0800 Message-ID: Subject: Re: [PATCH 20/20] mm: zswap: function ordering: shrink_memcg_cb To: Johannes Weiner Cc: Andrew Morton , Yosry Ahmed , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 29, 2024 at 5:42=E2=80=AFPM Johannes Weiner wrote: > > shrink_memcg_cb() is called by the shrinker and is based on > zswap_writeback_entry(). Move it in between. Save one fwd decl. > > Signed-off-by: Johannes Weiner Reviewed-by: Nhat Pham Nice! I just went through all the patches. LGTM.