Received-SPF: pass (google.com: domain of linux-kernel+bounces-47404-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <487ac3ad-2343-451b-a84e-153d0b01dee4@kernel.org>
Date: Thu, 1 Feb 2024 08:59:36 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] block: print warning when invalid domain set to
 ioprio
Content-Language: en-US
To: Zhaoyang Huang <huangzhaoyang@gmail.com>,
 Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
 "Martin K . Petersen" <martin.petersen@oracle.com>,
 Hannes Reinecke <hare@suse.de>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "steve.kang@unisoc.com" <steve.kang@unisoc.com>,
 "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
 Bart Van Assche <bvanassche@acm.org>
References: <20240131121401.3898735-1-zhaoyang.huang@unisoc.com>
 <ZbpCo+90OsXJwFWV@x1-carbon> <ZbpGDFUGQoaRQWHq@x1-carbon>
 <CAGWkznGOjsA3eGRt4i-1XAt=39ce7vaN7=zciimLJOMg=HD7Zw@mail.gmail.com>
From: Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <CAGWkznGOjsA3eGRt4i-1XAt=39ce7vaN7=zciimLJOMg=HD7Zw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 2/1/24 08:34, Zhaoyang Huang wrote:
> On Wed, Jan 31, 2024 at 9:07 PM Niklas Cassel <Niklas.Cassel@wdc.com> wrote:
>> This sound like either a bug in the FS or by some of your local changes
>> that you did for your other patch (ioprio based on activity).
> Yes. That's why I would like to suggest adding some information here
> to help developers find the clue quickly.

The backtrace was not clear enough ?

When a request reaches mq-deadline, the request priority is supposed to be
correct already. Your changes had a bug and broke that assumption. Please fix
that instead of adding error messages for errors that should never happen in the
first place.

-- 
Damien Le Moal
Western Digital Research