Received-SPF: pass (google.com: domain of linux-kernel+bounces-47527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Carlos Song <carlos.song@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
CC: "broonie@kernel.org" <broonie@kernel.org>, "shawnguo@kernel.org"
	<shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>, dl-linux-imx
	<linux-imx@nxp.com>, "benjamin@bigler.one" <benjamin@bigler.one>,
	"stefanmoring@gmail.com" <stefanmoring@gmail.com>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU
 mode
Thread-Topic: [PATCH v2] spi: imx: fix the burst length at DMA mode and CPU
 mode
Thread-Index: AQHaVLK6Wv7a10Us/kKnxfcUHtG6JQ==
Date: Thu, 1 Feb 2024 02:02:36 +0000
Message-ID:
 <VI1PR04MB5005EB37DD02F4E32D94336FE8432@VI1PR04MB5005.eurprd04.prod.outlook.com>
References: <20240131101916.437398-1-carlos.song@nxp.com>
 <20240131194207.GB12870@francesco-nb>
In-Reply-To: <20240131194207.GB12870@francesco-nb>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?dSpsm0wG5S2qWcCiSZYXUcHtwv4mICniGf6j/4oSzlZoXd2fLzjlJbtCap/e?=
 =?us-ascii?Q?gHh9W5w27Z0MvWJNEQICzLnP+rkiXFdixTfCbInOx1PlVeUH7x09/kBKq1vT?=
 =?us-ascii?Q?xUEsFIPIskkETc+iwoUTI0RuVE/2m/eqg2Rhk6wuYZn0untYi9IDbxEbrFoF?=
 =?us-ascii?Q?bNfiTyuky951s1jW84lUzpS0JrcEH04gPYDuiax/sF45vyEtBmLCze4w3jHQ?=
 =?us-ascii?Q?HUILrFzs0jYUGZGlmH7bC8zkEo25xc1yxC+RGrbwDSNKywyhUjhHiJiJkqf9?=
 =?us-ascii?Q?9rHgpIVUu8wv/dhcdHA3csdpOWqaKg8F3Ao2q43nfnKQsAeaLuezBswt3j4/?=
 =?us-ascii?Q?hcE8kFBYJEV3Hdbk9PKVlN+hF8LU9XfRhsGlMHh0KEpdvENeNOKWaUNYWm3l?=
 =?us-ascii?Q?OKlcMdq4ln5Idl7JgqKFotak1U0FYjtDjzYmHFwLpBqk53o5Q0amPOa1Qwtz?=
 =?us-ascii?Q?DEGlfNiOkQIm0mqngS/7joINjrEwjfBojUG8el3B5eNv7PjVep79nPTeSIYH?=
 =?us-ascii?Q?gyQ6ZWIbsFV1zA0vINEKJ6jtiBxmay79noOETJXKZSP0J/olWZxFr5LfipO4?=
 =?us-ascii?Q?tOxx+K251jTf95ikxrnSOMG9qEgn73bxM9zKb47Em1FbS5wZ6fpL82Xk3FE9?=
 =?us-ascii?Q?ImE9M936nIe9REZhzypc+eiKl1YEBLjbpsEUt3u8nBqu2kw6RW2EBiLVgWK9?=
 =?us-ascii?Q?S1WyuYAB/okhmWWrKaQ/UjeSg44dzVPfnIbYVVJC9KdQ2tlUWV2RJEQx/nHd?=
 =?us-ascii?Q?CQW6AMukDfpzDi4QRlJotjFwpAanqjaL4whn8wBbqDfFKaiaNrKg7c2RzZ7D?=
 =?us-ascii?Q?zRX2opQ8qEUQIL2UzmJop4FB0Ow9av8h8uX2RBnyxZ0fRfh8TzsO5TiZs4M8?=
 =?us-ascii?Q?OKjTgdh9gUloHe7jVSQlBUUIScIMz83TCYwkWo/dluP/SVZaFapM5GpizvQy?=
 =?us-ascii?Q?ZUZTY1L48qJt3T5iCNC+j/rq4+Yf58ER5YW9ImpnN8NKkU7KS8wJYvYOM0GS?=
 =?us-ascii?Q?nXvFWrxRD9acmhUrA0F5Kj4uAmfmOH+lNY9fw/SzzWyb0GeArSTgRqon+XOV?=
 =?us-ascii?Q?vX3xJT4g66oJRbIbG2fGUYAqxAvNDhjxW+IVJOU1hca23hPwRZD027Fuhws/?=
 =?us-ascii?Q?wxZRpMzeA4D2PsVh5GONRqx1PEIuU2EZByKYK3xfrgxmy6BZbpbeoXwghocP?=
 =?us-ascii?Q?u6/CZV3aEzV42NYx/WDjXWOBt81sW/kz3vZtAsqPMT4rgTs8k7dFj1LkUFG4?=
 =?us-ascii?Q?cFMDu3Ae6sflSQ2uNG3JhvgdBcabkzHuPJcR3RKMcrRfb//nDcwBsQ5W5tpe?=
 =?us-ascii?Q?vwBGSqeKTFtu+QgvJ7D00gYHFC6T7ASN9NDmzu2Ig6R6MulL9PVWyI6kGbG8?=
 =?us-ascii?Q?ep5pjroM/ADb8DU7nILcZP9/vxv/rcrRyx0LqXbinsJ6Nf5WrF7eSfq8QisP?=
 =?us-ascii?Q?DIVc8BIWKYFD8fyZPXRIGuzSM66EChYGOiQfjlJHfUJ95PF5/lQ36g1N7R+Q?=
 =?us-ascii?Q?CeaqwflCK1Qu5ntaqR5N9AUFSDcr8JALBib/mCz1ZUzkRH5iPzy6MOgWUNA0?=
 =?us-ascii?Q?DW94xeaqsBKkMl/PWsI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5005.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3d0ba7c-fd1b-40a3-9bf4-08dc22c9dc85
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2024 02:02:36.3164
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zkS9vFM2SwxYn1bqZsiEGjShXZ6ALHhqDA81U9qFQyuXquw06qzqgJ5/W9Q/SNTfYVN1YnVr1tNL32CcSTrEhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7946


> -----Original Message-----
> From: Francesco Dolcini <francesco@dolcini.it>
> Sent: Thursday, February 1, 2024 3:42 AM
> To: Carlos Song <carlos.song@nxp.com>
> Cc: broonie@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; benjamin@bigler.=
one;
> stefanmoring@gmail.com; linux-spi@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH v2] spi: imx: fix the burst length at DMA mode =
and CPU
> mode
>=20
> Caution: This is an external email. Please take care when clicking links =
or opening
> attachments. When in doubt, report the message using the 'Report this ema=
il'
> button
>=20
>=20
> On Wed, Jan 31, 2024 at 06:19:16PM +0800, carlos.song@nxp.com wrote:
> > From: Carlos Song <carlos.song@nxp.com>
> >
> > For DMA mode, the bus width of the DMA is equal to the size of data
> > word, so burst length should be configured as bits per word.
> >
> > For CPU mode, because of the spi transfer len is in byte, so burst
> > length should be configured as bits per byte * spi_imx->count.
> >
> > Signed-off-by: Carlos Song <carlos.song@nxp.com>
> > Reviewed-by: Clark Wang <xiaoning.wang@nxp.com>
> > Fixes: e9b220aeacf1 ("spi: spi-imx: correctly configure burst length
> > when using dma")
> > Fixes: 5f66db08cbd3 ("spi: imx: Take in account bits per word instead
> > of assuming 8-bits")
> > ---
> > Changes for V2:
> > - Removed BITS_PER_BYTE defination
> > ---
> >  drivers/spi/spi-imx.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index
> > 546cdce525fc..0436e7a161ef 100644
> > --- a/drivers/spi/spi-imx.c
> > +++ b/drivers/spi/spi-imx.c
> > @@ -660,15 +660,14 @@ static int mx51_ecspi_prepare_transfer(struct
> spi_imx_data *spi_imx,
> >                       << MX51_ECSPI_CTRL_BL_OFFSET;
> >       else {
> >               if (spi_imx->usedma) {
> > -                     ctrl |=3D (spi_imx->bits_per_word *
> > -
> spi_imx_bytes_per_word(spi_imx->bits_per_word) - 1)
> > +                     ctrl |=3D (spi_imx->bits_per_word - 1)
> >                               << MX51_ECSPI_CTRL_BL_OFFSET;
> >               } else {
> >                       if (spi_imx->count >=3D
> MX51_ECSPI_CTRL_MAX_BURST)
> > -                             ctrl |=3D (MX51_ECSPI_CTRL_MAX_BURST - 1)
> > +                             ctrl |=3D (MX51_ECSPI_CTRL_MAX_BURST *
> > + BITS_PER_BYTE - 1)
> >                                               <<
> MX51_ECSPI_CTRL_BL_OFFSET;
> >                       else
> > -                             ctrl |=3D (spi_imx->count *
> spi_imx->bits_per_word - 1)
> > +                             ctrl |=3D (spi_imx->count * BITS_PER_BYTE
> > + - 1)
> >                                               <<
> MX51_ECSPI_CTRL_BL_OFFSET;
> >               }
> >       }
>=20
> Add #include <linux/bits.h> given you are using BITS_PER_BYTE
>=20
Hi,=20

Thanks for your advice!
I found that <linux/property.h> has been included in spi-imx.c driver.
And <linux/bits.h> has been included in <linux/property.h>.
So I didn't add the "#include <linux/bits.h>" on purpose.

BR
Carlos
> Francesco