Received-SPF: pass (google.com: domain of linux-kernel+bounces-47540-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <D520CF9C25E9CB81+46dd0dde-cfea-4606-a227-45892ca762ac@shingroup.cn>
Date: Thu, 1 Feb 2024 10:24:34 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] dt-bingdings: perf: Support uncore ARM NI-700 PMU
Content-Language: en-US
To: Robin Murphy <robin.murphy@arm.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, will
 <will@kernel.org>, "mark.rutland" <mark.rutland@arm.com>
Cc: shenghui.qu@shingroup.cn, =?UTF-8?B?6LW15Y+v?= <ke.zhao@shingroup.cn>,
 zhijie.ren@shingroup.cn, linux-kernel@vger.kernel.org,
 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
 Jonathan Cameron <jonathan.cameron@huawei.com>
References: <20240131065953.9634-1-jialong.yang@shingroup.cn>
 <e7bf16fc-b12d-47eb-9197-0694e6829ac8@linaro.org>
 <02B995F774AB7A9D+adfd0934-00cb-4dc3-8bf8-058b83dc2fbb@shingroup.cn>
 <ebbc9d73-9be2-49ae-98f3-0d71ce624ee4@linaro.org>
 <873A6CC450C1D0E6+75a39d6c-4fbf-4e30-8630-3226bd725901@shingroup.cn>
 <b99efbd4-7c12-485d-8688-a4ec606f0cf5@linaro.org>
 <EC1445AF2C5DB6F4+64772ecd-5e7a-42bb-aaa8-bc2857b2ab8b@shingroup.cn>
 <c68f8b00-c5df-45e1-b75a-f86ce128ddf0@arm.com>
From: =?UTF-8?B?WWFuZyBKaWFsb25nIOadqOS9s+m+mQ==?= <jialong.yang@shingroup.cn>
In-Reply-To: <c68f8b00-c5df-45e1-b75a-f86ce128ddf0@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Feedback-ID: bizesmtp:shingroup.cn:qybglogicsvrgz:qybglogicsvrgz6a-1


在 2024/2/1 0:59, Robin Murphy 写道:
> On 31/01/2024 10:18 am, Yang Jialong 杨佳龙 wrote:
>>
>>
>> 在 2024/1/31 18:16, Krzysztof Kozlowski 写道:
>>> On 31/01/2024 11:13, Yang Jialong 杨佳龙 wrote:
>>>>
>>>>
>>>> 在 2024/1/31 17:30, Krzysztof Kozlowski 写道:
>>>>> On 31/01/2024 10:26, Yang Jialong 杨佳龙 wrote:
>>>>>>
>>>>>>
>>>>>> 在 2024/1/31 15:49, Krzysztof Kozlowski 写道:
>>>>>>> On 31/01/2024 07:59, JiaLong.Yang wrote:
>>>>>>>> Add file corresponding to hx_arm_ni.c introducing ARM NI-700 PMU 
>>>>>>>> driver
>>>>>>>> for HX.
>>>>>>>>
>>>>>>>> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn>
>>>>>>>> ---
>>>>>>>> v1 --> v2:
>>>>>>>> 1. Submit dt-bindings file Seperately.
>>>>>>>
>>>>>>> Where is the driver?
>>>>>>>
>>>>>>> Please read:
>>>>>>> https://elixir.bootlin.com/linux/v6.8-rc2/source/Documentation/process/submitting-patches.rst
>>>>>>> before posting.
>>>>>>>
>>>>>
>>>>> Keep all discussions public.
>>>>
>>>> Get.
>>>>
>>>>>
>>>>>
>>>>>>>> +  pccs-id:
>>>>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>>>>> +    description: Used to identify NIs in system which has more 
>>>>>>>> than
>>>>>>>> +      one NI.
>>>>>>>
>>>>>>> No, reg does it. Drop the property. Anyway you miss here vendor 
>>>>>>> prefix
>>>>>>> and proper explanation.
>>>>>>>
>>>>>>
>>>>>> reg will tell phy address. Phy address is too long. I just want a id.
>>>>>> example: perf stat -a -e ni_pmu_${pccs-id}/cycles/
>>>>>> I will use it in user space. Not only in driver.
>>>>>
>>>>> Custom vendor property is not for that purpose. Use for example 
>>>>> IDR, DT
>>>>> aliases or something else.
>>>>>
>>>>>
>>>>
>>>> I have considered TD aliases. It's not very easy. Two places...
>>>> IDR.. I have tested. But it chouldn't correspond to the HWs.
>>>> I need it to identify NIs.
>>>> DT aliases is reachable. But no very easy.
>>>
>>> Except that "you want" I did not see any rationale, any argument
>>> explaining why this is needed and why this has to be present.
>>
>> OK. DT aliases it good.
> 
> The real way to address that particular issue is to fix perf to properly 
> associate the PMU device with the underlying hardware device. Jonathan 
> had a series doing that[1], but I'm not sure what its status is now.
> 

Good news.
In NI, we have to consider NIs and PMUs in one NI.

> Thanks,
> Robin.
> 
> [1] 
> https://lore.kernel.org/linux-arm-kernel/20230404134225.13408-1-Jonathan.Cameron@huawei.com/
>