Received-SPF: pass (google.com: domain of linux-kernel+bounces-47535-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 31 Jan 2024 21:18:50 -0500
From: Gregory Price <gregory.price@memverge.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Gregory Price <gourry.memverge@gmail.com>, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
	corbet@lwn.net, akpm@linux-foundation.org, honggyu.kim@sk.com,
	rakie.kim@sk.com, hyeongtak.ji@sk.com, mhocko@kernel.org,
	vtavarespetr@micron.com, jgroves@micron.com,
	ravis.opensrc@micron.com, sthanneeru@micron.com,
	emirakhur@micron.com, Hasan.Maruf@amd.com, seungjun.ha@samsung.com,
	hannes@cmpxchg.org, dan.j.williams@intel.com,
	Srinivasulu Thanneeru <sthanneeru.opensrc@micron.com>
Subject: Re: [PATCH v4 3/3] mm/mempolicy: introduce MPOL_WEIGHTED_INTERLEAVE
 for weighted interleaving
Message-ID: <Zbr/iv3IfVqhOglE@memverge.com>
References: <20240130182046.74278-1-gregory.price@memverge.com>
 <20240130182046.74278-4-gregory.price@memverge.com>
 <877cjqgfzz.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <Zbn6FG3346jhrQga@memverge.com>
 <87y1c5g8qw.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <ZbqDgaOsAeXnqRP2@memverge.com>
 <871q9xeyo4.fsf@yhuang6-desk2.ccr.corp.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <871q9xeyo4.fsf@yhuang6-desk2.ccr.corp.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?iz28Mpn/QGj3sJx6Tbloen01Y6PsJF/Ry1IHAAPoq7ceOmDdk4Wv6fzFFbZ/?=
 =?us-ascii?Q?UZk2ov7489vlpb06H1NTRQvqOCDVJxuo8xe1MBmThAkyR+LhyKeZzkRYHfjN?=
 =?us-ascii?Q?9epb/o4Sg1LZx5aqOfDEnkJvqV65oZee72kbyzt9eDya5Jhuem09AsW07tZW?=
 =?us-ascii?Q?XMzIlVlnsaTV1Jdz1cUgI/AYuldBHHeXuXlgiLteZoJrtBvUL/6fZbHaNuWx?=
 =?us-ascii?Q?DCeYPcozQys8Xf04Ul9qdb21Y0kztsKzuFJNV3Mb9ca6jL/aBogSkuQKReHe?=
 =?us-ascii?Q?ugM2UQn6k43j4MbM9+OmYRjU4hUCo2M5RuYrm8bcUOXQxIdZdvOX0nnvE8oa?=
 =?us-ascii?Q?9UlFB33xOzt1MyyYxHJxP4FocE5njAQaNkx1/QreTDVsMXbuH7h6Cqi561Jg?=
 =?us-ascii?Q?satXWBesYN7gGzT0ISdKiu3HlF2d8jlmfdF9XZv8zVDxFsr2YvYkwpT/gmac?=
 =?us-ascii?Q?5KSQbi/dX7sYITaOrr0zJ4QIUJjEgM5unThrgM7RXu2AaNrJ0knSwasvzB+j?=
 =?us-ascii?Q?jf1CDhDWBMljg/b5F7gHwcmNJ7+LQv2X2r2d4XQjWJzjTqaEIUXahbDYNY3D?=
 =?us-ascii?Q?tHgHQmDDRnMP+v0RWsQBu5RBBwz91W28EKygRnmxM/hx6/swL43Y4zsoewn6?=
 =?us-ascii?Q?sXaL272roMy3xcaYjtnZZO8QIVIHDsQn3IzxHip1H59tvaCCGG12NmrkAnY3?=
 =?us-ascii?Q?md3l46sV0oVzSEO3abwpYZeW0MKfnRl/qQVTykBpfXO3cBHHbnMFVbNHuUbR?=
 =?us-ascii?Q?B+BQzdScU5NJ/Jnu6m9tud5uweAWZqoKjCdFf5q+wnY4KMoG5PKIIKbr4FJu?=
 =?us-ascii?Q?uw/vKbmI9PCf1+m1tykssZL7mAvsLK1ggJkSXhBTkrUOsQl2uxNGDkdonz1F?=
 =?us-ascii?Q?2SGKMP8ujzS7+o3DwmcoYmAyqy7IZOSFNbrEJgaJgPPUjyAEKnNLhrtLID5t?=
 =?us-ascii?Q?B78zoNnBHRxHKcF7n1X2TY3LPlQp8et/BrL4TRe4D1BOapwOiR4fi4pNzbG5?=
 =?us-ascii?Q?KRE7OGV64oq1KCpOrFZdWcYVIsH1CCSZdl7Lc3EqNBiamzecAkN/TLfo6Ri/?=
 =?us-ascii?Q?EyFjl/ud5xgZkxobXInrFQfOdIxrcS4oExrExugauul0diZ9F2iRqTSeW7ty?=
 =?us-ascii?Q?kmoBoA8UxnRX1nQgeC44JL1fs/1c/NT9KAlUsyXlJliuiBx7duQjO1wqn0ug?=
 =?us-ascii?Q?Mnmr08CkDXzO3q8zVXYO0m8OBPiqfobCwym1hOCLmG2BqP9B70Oz9a7fqkE7?=
 =?us-ascii?Q?RY5mvsgFQmbMxB5mtwr3SJz3G51riEEnA9xlgNH1vIV+OhRMOKNR8Ji/A5GV?=
 =?us-ascii?Q?UM8Pw67qHxEiyw1B6Mvol9ybLuyENSTFN9BK48/zS3ktBOX2X52VYyQPSBN2?=
 =?us-ascii?Q?4Z3IDmMBVBkuQW7nqsYyHZKWK999w9n6a7q8jAuzTQWh7UtZ+h1wERngU8XS?=
 =?us-ascii?Q?hHXF56P+tNAlsgYZsMmLdzSr6gYpEz8I/O/niGzrnjm2cF3XnVNpxiyt9ooF?=
 =?us-ascii?Q?eP23PBvAqA4foLC5Ns/JOp1WLG7GoVmmg7ToDLhahg3WSao1Z8OYmRwiEXiY?=
 =?us-ascii?Q?DqeeEuerj0IG1EH/acbuMny553jcyPMRrZALJEtQEE5a3uj4u1pYe+oBFhNR?=
 =?us-ascii?Q?kw=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15b65ebd-665b-4b7e-4073-08dc22cc25e4
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR17MB5512.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 02:18:58.9553
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Si/3WD/5GXAyxiouzn5oHfyWRlwWMHXYORJrjbGm8yzRN+bA0ovFOnCdfwaSd8Z8XkKZReEbIpgwHvyKhCWjaSy9Tx02/fs7V8mCYWkTnNo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR17MB5973

On Thu, Feb 01, 2024 at 09:55:07AM +0800, Huang, Ying wrote:
> Gregory Price <gregory.price@memverge.com> writes:
> > -       u8 __rcu *table, *weights, weight;
> > +       u8 __rcu *table, __rcu *weights, weight;
> 
> The __rcu usage can be checked with `sparse` directly.  For example,
> 
> make C=1 mm/mempolicy.o
> 

fixed and squashed, all the __rcu usage i had except the global pointer
have been used.  Thanks for the reference material, was struggling to
understand that.

> > task->mems_allowed_seq protection (added as 4th patch)
> > ------------------------------------------------------
> >
> > +       cpuset_mems_cookie = read_mems_allowed_begin();
> >         if (!current->il_weight || !node_isset(node, policy->nodes)) {
> >                 node = next_node_in(node, policy->nodes);
> 
> node will be changed in the loop.  So we need to change the logic here.
> 

new patch, if it all looks good i'll ship it in v5

~Gregory


diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index d8cc3a577986..4e5a640d10b8 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1878,11 +1878,17 @@ bool apply_policy_zone(struct mempolicy *policy, enum zone_type zone)

 static unsigned int weighted_interleave_nodes(struct mempolicy *policy)
 {
-       unsigned int node = current->il_prev;
-
-       if (!current->il_weight || !node_isset(node, policy->nodes)) {
-               node = next_node_in(node, policy->nodes);
-               /* can only happen if nodemask is being rebound */
+       unsigned int node;
+       unsigned int cpuset_mems_cookie;
+
+retry:
+       /* to prevent miscount use tsk->mems_allowed_seq to detect rebind */
+       cpuset_mems_cookie = read_mems_allowed_begin();
+       if (!current->il_weight ||
+           !node_isset(current->il_prev, policy->nodes)) {
+               node = next_node_in(current->il_prev, policy->nodes);
+               if (read_mems_allowed_retry(cpuset_mems_cookie))
+                       goto retry;
                if (node == MAX_NUMNODES)
                        return node;
                current->il_prev = node;
@@ -1896,8 +1902,14 @@ static unsigned int weighted_interleave_nodes(struct mempolicy *policy)
 static unsigned int interleave_nodes(struct mempolicy *policy)
 {
        unsigned int nid;
+       unsigned int cpuset_mems_cookie;
+
+       /* to prevent miscount, use tsk->mems_allowed_seq to detect rebind */
+       do {
+               cpuset_mems_cookie = read_mems_allowed_begin();
+               nid = next_node_in(current->il_prev, policy->nodes);
+       } while (read_mems_allowed_retry(cpuset_mems_cookie));

-       nid = next_node_in(current->il_prev, policy->nodes);
        if (nid < MAX_NUMNODES)
                current->il_prev = nid;
        return nid;
@@ -2374,6 +2386,7 @@ static unsigned long alloc_pages_bulk_array_weighted_interleave(gfp_t gfp,
                struct page **page_array)
 {
        struct task_struct *me = current;
+       unsigned int cpuset_mems_cookie;
        unsigned long total_allocated = 0;
        unsigned long nr_allocated = 0;
        unsigned long rounds;
@@ -2391,7 +2404,13 @@ static unsigned long alloc_pages_bulk_array_weighted_interleave(gfp_t gfp,
        if (!nr_pages)
                return 0;

-       nnodes = read_once_policy_nodemask(pol, &nodes);
+       /* read the nodes onto the stack, retry if done during rebind */
+       do {
+               cpuset_mems_cookie = read_mems_allowed_begin();
+               nnodes = read_once_policy_nodemask(pol, &nodes);
+       } while (read_mems_allowed_retry(cpuset_mems_cookie));
+
+       /* if the nodemask has become invalid, we cannot do anything */
        if (!nnodes)
                return 0;