Received-SPF: pass (google.com: domain of linux-kernel+bounces-47552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <2fccdb02-3b66-40b9-a0d7-a79fe7c5580a@redhat.com>
Date: Thu, 1 Feb 2024 10:59:35 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] fscrypt: to make sure the inode->i_blkbits is
 correctly set
Content-Language: en-US
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-fscrypt@vger.kernel.org, tytso@mit.edu, jaegeuk@kernel.org,
 linux-kernel@vger.kernel.org, idryomov@gmail.com,
 ceph-devel@vger.kernel.org, jlayton@kernel.org, vshankar@redhat.com,
 mchangir@redhat.com
References: <20240201003525.1788594-1-xiubli@redhat.com>
 <20240201024828.GA1526@sol.localdomain>
From: Xiubo Li <xiubli@redhat.com>
In-Reply-To: <20240201024828.GA1526@sol.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2/1/24 10:48, Eric Biggers wrote:
> On Thu, Feb 01, 2024 at 08:35:25AM +0800, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> The inode->i_blkbits should be already set before calling
>> fscrypt_get_encryption_info() and it will use this to setup the
>> ci_data_unit_bits later.
>>
>> URL: https://tracker.ceph.com/issues/64035
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> Thanks, applied.  I adjusted the commit message to make it clear what the patch
> actually does:
>
> commit 5befc19caec93f0088595b4d28baf10658c27a0f
> Author: Xiubo Li <xiubli@redhat.com>
> Date:   Thu Feb 1 08:35:25 2024 +0800
>
>      fscrypt: explicitly require that inode->i_blkbits be set
>
>      Document that fscrypt_prepare_new_inode() requires inode->i_blkbits to
>      be set, and make it WARN if it's not.  This would have made the CephFS
>      bug https://tracker.ceph.com/issues/64035 a bit easier to debug.
>
>      Signed-off-by: Xiubo Li <xiubli@redhat.com>
>      Link: https://lore.kernel.org/r/20240201003525.1788594-1-xiubli@redhat.com
>      Signed-off-by: Eric Biggers <ebiggers@google.com>
>
Ack, thanks Eric.

- Xiubo