Received-SPF: pass (google.com: domain of linux-kernel+bounces-47561-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Chukun Pan <amadeus@jmu.edu.cn>
To: dmitry.baryshkov@linaro.org
Cc: amadeus@jmu.edu.cn,
	andersson@kernel.org,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	konrad.dybcio@linaro.org,
	krzysztof.kozlowski+dt@linaro.org,
	linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	robh+dt@kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: ipq6018: separate CPU OPP tables
Date: Thu,  1 Feb 2024 11:08:28 +0800
Message-Id: <20240201030828.12515-1-amadeus@jmu.edu.cn>
In-Reply-To: <CAA8EJppDQAdnceYhL_=Di0n5j3W0F2+7ntpNMxpXBXgnYoh_uQ@mail.gmail.com>
References: <CAA8EJppDQAdnceYhL_=Di0n5j3W0F2+7ntpNMxpXBXgnYoh_uQ@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi, Dmitry
> I went on and checked ipq6018.dtsi. It will need to be reworked before
> we can continue with PMIC-less devices.

> Obviously, the PMIC is not a part of the SoC. So please move the
> "qcom,rpm-mp5496-regulators" node to the board files together with the
> cpu-supply properties that reference that regulator.

Thanks a lot for your advice, now things are clearer.
My idea is as follows:

1. Add all frequencies supported by SoCs in ipq6018.dtsi

2. Move cpu-supply and mp5496 nodes to ipq6018-mp5496.dtsi

&CPU0 {
	cpu-supply = <&ipq6018_s2>;
};
..

&rpm_requests {
	regulators {
		rpm-mp5496...
		ipq6018_s2...
	};
};

> The SoC itself supports all listed frequencies, so it is incorrect to
> split the opp tables from the ipq6018.dtsi. Instead please patch the
> PMIC-less boards in the following way:

> #include "ipq6018.dtsi"
> &cpu_opp_table {
>  /* the board doesn't have a PMIC, disable CPU frequencies which
> require higher voltages */
>  /delete-node/ opp-1320000000;
>  /delete-node/ opp-1440000000;
>};

Thank you but no need. The CPUFreq NVMEM driver will give the CPU
maximum frequency based on the cpu_speed_bin and opp-supported-hw.

Thanks,
Chukun

-- 
2.25.1