Received-SPF: pass (google.com: domain of linux-kernel+bounces-47605-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 31 Jan 2024 23:18:18 -0500
From: Frank Li <Frank.li@nxp.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, Jingoo Han <jingoohan1@gmail.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Serge Semin <fancer.lancer@gmail.com>
Subject: Re: [PATCH 3/6] PCI: dwc: Add outbound MSG TLPs support
Message-ID: <Zbsbig9CFevHFBPI@lizhi-Precision-Tower-5810>
References: <20240130-pme_msg-v1-0-d52b0add5c7c@nxp.com>
 <20240130-pme_msg-v1-3-d52b0add5c7c@nxp.com>
 <TYCPR01MB86137941900C38F89EC2F321D8432@TYCPR01MB8613.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <TYCPR01MB86137941900C38F89EC2F321D8432@TYCPR01MB8613.jpnprd01.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Gh9dmGMu0Z3rhhQKNx0k0i8qvEWLQyf0vi5j2gx8tkFCxdt4CzYgaii6FoZb?=
 =?us-ascii?Q?28hP8ZpokiOdUi+bvuCjvyaaDzXXDasm5Gs1jheZg0SJXrTMvubF1MzMpz+3?=
 =?us-ascii?Q?3GEAOj1oX7h99oXLY3YwZ4/8Ehoh5amVujRJDn6QOSf4Q7I2Tz0q/b9cKoE2?=
 =?us-ascii?Q?mhkps85FwNYIOzA3D4f16Fdejvpk8/QnhpGfUGrFlSwoaItEqC/v7sOJNDeY?=
 =?us-ascii?Q?V9C11NwbpwU5ODPxPomih+KSA0SBPo5EOpr1E5rxd7y9mUYR8S8M+UC+LjO5?=
 =?us-ascii?Q?4LiNZucsqJrenBGM3vEpLRf7u5AZw6hHMonA0L3eNQqGAxS44HBaDsEJDORS?=
 =?us-ascii?Q?NxqNzhCsIYVfLwDVIF/fI0JYOvHkXBbBskdEFvEzY13/g4+lk7bqR868IxEX?=
 =?us-ascii?Q?659mHHA5INK8s6NJmd/ffk4lxcVdXrCGAvMOoLzFVPHabYKm2w5O40ikvlFx?=
 =?us-ascii?Q?WuDcVqBkMrpXpYUmlaEOZyAepkQ2Z9KAPj6XGid5Tg9REPy/ZMLZ5rt3sa4u?=
 =?us-ascii?Q?bQ5ET/i1DbNVbdp6zGxbYmAjlIm8RpSGs/SKHEdvIEX5mkhUgRFG133ff3ab?=
 =?us-ascii?Q?65XpIwvwYb6GnelfYznd+dWz6xJgHrlU6NyyAza5vQOhhaNMMaAMMi2jCQJQ?=
 =?us-ascii?Q?NENtuwYb/NM5J7pHyEEflDRgYdPjxhEnrH3HZ9v8K0YP9n9jTYTy+v5bpnDI?=
 =?us-ascii?Q?ONa75uhGLpd6sQXOI1gjBeZ69Bek43/Su7h8say1xrjNrtbfwmPsptA5pThd?=
 =?us-ascii?Q?RY1CPKyw+G647lnIdNDfDxawq6Yt43lIgrSVI4vjUnl1agL5tfqFMNU+yheb?=
 =?us-ascii?Q?+sPbb7vNs9EYTWP0xgMUrRJ1uXfxryyZ0VOcdjFqxONnIwuGmtQaBMNpQ1j9?=
 =?us-ascii?Q?o4NdUOdQxp1DXHIwYS/wz8osM15b2d9B7c23gcqerRsv4jdtqt+tIH1B2jqb?=
 =?us-ascii?Q?Nid/ehh90HtO0KrlaLFMQyGU5gtv7FncoZJ/PJ+wbHJ0PmzMN8H0l/TStV65?=
 =?us-ascii?Q?+q7LBQ+WuUyHtincStjuPn5pusN/GpZCAfL6FOVcIJhzzZjEFYBL8HlN1mor?=
 =?us-ascii?Q?LyeK4TNPKfU6e2alEOOwR89sVEYnyQdz1mzuv7K+G535oMgjj6WljjY0E5Zu?=
 =?us-ascii?Q?Y0xVeV+prHRl6DlM6ruj+4Cb14DJP2qRIy3Nbh+OhbQV0y1hf0hbDJOiIWR+?=
 =?us-ascii?Q?nBDWDkGmIXAz35UZ2a4A39/GbWeymTS2kZoiflLtfxZCSeG1KoOQgHSiQfOR?=
 =?us-ascii?Q?vfrMiscI5Vt9Z+CR/Ujv40IMNdmnrsvDANTQaSF5T2LumhwZIuvgIc5HhsZ2?=
 =?us-ascii?Q?0G23m+K99v4BSxq4MYLOOr6+8kmWT2HtDJ+lTbKGk1BDIRim3GVXQtIcX5pz?=
 =?us-ascii?Q?Ah6SvjCWPr/rH2pkAJrs9/SqWKySTHJbyJcd8QsejKPjjxIoxVFQaYeM6KMK?=
 =?us-ascii?Q?uwwognjXHERxaVCGyt0qIRMAZoce3Rzo1wz3Z4tjSsBRNcvNHxvMGdq5PbZg?=
 =?us-ascii?Q?zlONuuwwBOU8srLRazwAmgFLUk65/R6mfY3zlMC/K0FfDYWWBO9Daz4ckn+/?=
 =?us-ascii?Q?hNam5y3El14IdQFsmdY=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a8e0300-c84b-4ae1-33c8-08dc22dcd699
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 04:18:26.9741
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4pXaIMBRl7TGjuWaW+i+Z3buNAUY3MiJEfihIxbWzNCBgetjCbyPkdE75LfMRgEiASd6KdVYqC1D7r07Ty6Y1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6895

On Thu, Feb 01, 2024 at 03:07:24AM +0000, Yoshihiro Shimoda wrote:
> Hi Frank,
> 
> > From: Frank Li, Sent: Wednesday, January 31, 2024 9:45 AM
> > 
> > From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > 
> > Add "code" and "routing" into struct dw_pcie_ob_atu_cfg for triggering
> > INTx IRQs by iATU in the PCIe endpoint mode in near the future.
> > PCIE_ATU_INHIBIT_PAYLOAD is set to issue TLP type of Msg instead of
> > MsgD. So, this implementation supports the data-less messages only
> > for now.
> > 
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> 
> Perhaps, your Signed-off-by is needed here?

Yes, I will add at next version.

Frank
> 
> Best regards,
> Yoshihiro Shimoda
> 
> > ---
> >  drivers/pci/controller/dwc/pcie-designware.c | 9 +++++++--
> >  drivers/pci/controller/dwc/pcie-designware.h | 4 ++++
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> > index df2575ec5f44c..ba909fade9db1 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > @@ -499,7 +499,7 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci,
> >  	dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_UPPER_TARGET,
> >  			      upper_32_bits(atu->pci_addr));
> > 
> > -	val = atu->type | PCIE_ATU_FUNC_NUM(atu->func_no);
> > +	val = atu->type | atu->routing | PCIE_ATU_FUNC_NUM(atu->func_no);
> >  	if (upper_32_bits(limit_addr) > upper_32_bits(cpu_addr) &&
> >  	    dw_pcie_ver_is_ge(pci, 460A))
> >  		val |= PCIE_ATU_INCREASE_REGION_SIZE;
> > @@ -507,7 +507,12 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci,
> >  		val = dw_pcie_enable_ecrc(val);
> >  	dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL1, val);
> > 
> > -	dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL2, PCIE_ATU_ENABLE);
> > +	val = PCIE_ATU_ENABLE;
> > +	if (atu->type == PCIE_ATU_TYPE_MSG) {
> > +		/* The data-less messages only for now */
> > +		val |= PCIE_ATU_INHIBIT_PAYLOAD | atu->code;
> > +	}
> > +	dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL2, val);
> > 
> >  	/*
> >  	 * Make sure ATU enable takes effect before any subsequent config
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h
> > index d21db82e586d5..703b50bc5e0f1 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.h
> > +++ b/drivers/pci/controller/dwc/pcie-designware.h
> > @@ -148,11 +148,13 @@
> >  #define PCIE_ATU_TYPE_IO		0x2
> >  #define PCIE_ATU_TYPE_CFG0		0x4
> >  #define PCIE_ATU_TYPE_CFG1		0x5
> > +#define PCIE_ATU_TYPE_MSG		0x10
> >  #define PCIE_ATU_TD			BIT(8)
> >  #define PCIE_ATU_FUNC_NUM(pf)           ((pf) << 20)
> >  #define PCIE_ATU_REGION_CTRL2		0x004
> >  #define PCIE_ATU_ENABLE			BIT(31)
> >  #define PCIE_ATU_BAR_MODE_ENABLE	BIT(30)
> > +#define PCIE_ATU_INHIBIT_PAYLOAD	BIT(22)
> >  #define PCIE_ATU_FUNC_NUM_MATCH_EN      BIT(19)
> >  #define PCIE_ATU_LOWER_BASE		0x008
> >  #define PCIE_ATU_UPPER_BASE		0x00C
> > @@ -303,6 +305,8 @@ struct dw_pcie_ob_atu_cfg {
> >  	int index;
> >  	int type;
> >  	u8 func_no;
> > +	u8 code;
> > +	u8 routing;
> >  	u64 cpu_addr;
> >  	u64 pci_addr;
> >  	u64 size;
> > 
> > --
> > 2.34.1
>