Received-SPF: pass (google.com: domain of linux-kernel+bounces-47695-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: JiaJie Ho <jiajie.ho@starfivetech.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
CC: "David S . Miller" <davem@davemloft.net>, Rob Herring
	<robh+dt@kernel.org>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 4/5] crypto: starfive: Add sm3 support for JH8100
Thread-Topic: [PATCH v2 4/5] crypto: starfive: Add sm3 support for JH8100
Thread-Index: AQHaSFqmtg6Zzl/qkUuu0ddSCEXpi7Drn0sAgAgJJNA=
Date: Thu, 1 Feb 2024 03:01:59 +0000
Message-ID:
 <BJSPR01MB0659C3FE1262DF8CC7F7DA468A43A@BJSPR01MB0659.CHNPR01.prod.partner.outlook.cn>
References: <20240116090135.75737-1-jiajie.ho@starfivetech.com>
 <20240116090135.75737-5-jiajie.ho@starfivetech.com>
 <ZbNCKrTLXmPcsrSH@gondor.apana.org.au>
In-Reply-To: <ZbNCKrTLXmPcsrSH@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?IFZnV6saD2SwxTxrhk6g6+fO3GrQlNURycjFgn9y2XVO5nHJGoTxMKwnaYBr?=
 =?us-ascii?Q?5XFJaoFdRk3bFBD9iVFiPiFXbiF6wwIvDtfysYVQjmo5ygMpP1sqdaJ+JY9d?=
 =?us-ascii?Q?rQQQT28MFvSzweC6DoNNsQu2AbA6AmkxLBv41wnHtDGndfl7ltlyu0/MOdP+?=
 =?us-ascii?Q?M8+t2m6rz5eymOQWd2idu9VRKSo9Y3SjKIryQmjksl9oK3820NhzChOsaKjN?=
 =?us-ascii?Q?lEVJ4lPnflENGszDFaCz/ELivLtUIvpx4aEnA/Gb+IgjTNgS16IByVoXm3Sm?=
 =?us-ascii?Q?93bQfL7NQTeQInm9pfb2i0Veykbbinb+HF4eEBr8tACLyn0QfOoCEYuvNTwo?=
 =?us-ascii?Q?8Wo6eJlLZuGHj8qXuPAbmmHZDDKnzb/+M6qKfqmLwvMMjdUsdT5HZLdWXz40?=
 =?us-ascii?Q?G7dStdlSAp6OpVFyDkpVrgL2gt4WV20Pwg5Rg984Sa9JgbTvQvprhKhwxEAq?=
 =?us-ascii?Q?XTSDIIaI2o5xUcL16DaaRd4owPt6BB7xpMeP1GIBAwLof04OgL/R4v/O2JWr?=
 =?us-ascii?Q?vYbyR2k0IoglefeLOTJbOxnlVMIeTg9P926em8OKFPussowuquf+krK/W77s?=
 =?us-ascii?Q?oBrdqK7+vtp0NpMr9wv+2AbNh1k6V1HlMP86HQg/mjx6Ldx2hdWpn1m6ks1u?=
 =?us-ascii?Q?i5Zgf1M9VLfkMH2C70NR2MhEzFJvt6aQhJ9JJkJK1hiq+eMu6a8XAxBNg7Kj?=
 =?us-ascii?Q?ggF+2qvcr+JmCMfnitLYC58UU9sSPCeznPcsr6rnLhw2d2yPd20TnjKgcLTM?=
 =?us-ascii?Q?+NTLH9WNuJ98GSybYin7ygrwLpNjH0MisBDKJbcVd7faMpKvBZuXVz2aGxSb?=
 =?us-ascii?Q?vuzSgg77f7HpNT4+cbPEaHTeGhMc4VSshfSVjF7eNnNzgK6RfDkKPyn2IeOK?=
 =?us-ascii?Q?TuZKpC2Bwk6Yaantk6DROHxVFAIxjomfRITKs30DFTVewaFyKBckyWMXhPb8?=
 =?us-ascii?Q?Ft+FOeasjBSB0dSLWhpG4nFbQuETDaII6kbXxE6sdkQNE+9a6Uiny5rLr0Hb?=
 =?us-ascii?Q?W03wlYIgdPUAgBZlo+3wC3mw+Ve6gEprnqCJ6U7CQf1YZrbOus2e4cMdTY4L?=
 =?us-ascii?Q?GBAr62MG/LyMxTe8F0i5FTfdieK6yLeDmzDyRJCt6Vvoj5tHOWuE/WUE3Um6?=
 =?us-ascii?Q?/7LmEtL8t0FypPQHauI8GBFT/hod+odvymG594c9yVEZUd2LSVNIXrI9WtGr?=
 =?us-ascii?Q?nuoX/KJXY50RVtsoMReietQJVetyQL6WYuD3If0dbN7GguQ7SaXF2+sdrErD?=
 =?us-ascii?Q?2IL3YTrq7lFZm2qzBnB1xH8nxzhEClO79P4whgnnHlRHNFOsFZnhMGvLaSyC?=
 =?us-ascii?Q?iXFyh1Z18pddPFa8pWQfzYmzz9jd888DsTMP988zj5LpxdJhtek2qBZrvl69?=
 =?us-ascii?Q?mOdit9hLcpg7s6SR+17JlUHoaDwmBE5uqW26MusHtBKaUlk6eUyTcXUitksB?=
 =?us-ascii?Q?Pz+BCIFcZmh2l1Pvf7Gttz6U4mOq7httSO//Md3jU5ElxB7Y1TSHOdS0jMhO?=
 =?us-ascii?Q?b+qYlNAc4GSiX4XNrdGp0G1MLQnKG4VkkdALkR462YalWzxIyjGizq1pkPet?=
 =?us-ascii?Q?mH3N7gXiOqAIWgVQsSFtiiZnQJLQ8w1BTkbc+BgAZTRdMflf/mn3vDz0s9wz?=
 =?us-ascii?Q?EA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: starfivetech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BJSPR01MB0659.CHNPR01.prod.partner.outlook.cn
X-MS-Exchange-CrossTenant-Network-Message-Id: b835bf45-142c-4720-3f12-08dc22d2288e
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2024 03:01:59.8617
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6blqKGDP8VJDoQMEIjOA0SrE3nQjB70wu33yZi8Vf29ts4CP41Fod+9M365L1OyhOCRUYQ+rfzFI7HZq64Xt/z0chi+tQ3gmHvoaU1W89d8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BJSPR01MB0786

> On Tue, Jan 16, 2024 at 05:01:34PM +0800, Jia Jie Ho wrote:
> > Add driver support for SM3 hash/HMAC for JH8100 SoC. JH8100 contains a
> > separate SM algo engine and new dedicated dma that supports 64-bit
> > address access.
> >
> > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> > ---
> >  drivers/crypto/starfive/Kconfig       |  25 +-
> >  drivers/crypto/starfive/Makefile      |   3 +
> >  drivers/crypto/starfive/jh7110-cryp.c |  48 ++-
> > drivers/crypto/starfive/jh7110-cryp.h |  59 +++
> > drivers/crypto/starfive/jh7110-hash.c |  20 +-
> > drivers/crypto/starfive/jh8100-sm3.c  | 532
> ++++++++++++++++++++++++++
> >  6 files changed, 677 insertions(+), 10 deletions(-)  create mode
> > 100644 drivers/crypto/starfive/jh8100-sm3.c
> >
> > diff --git a/drivers/crypto/starfive/Kconfig
> > b/drivers/crypto/starfive/Kconfig index 0fe389e9f932..e6bf02d0ed1f
> > 100644
> > --- a/drivers/crypto/starfive/Kconfig
> > +++ b/drivers/crypto/starfive/Kconfig
> > @@ -5,7 +5,7 @@
> >  config CRYPTO_DEV_JH7110
> >  	tristate "StarFive JH7110 cryptographic engine driver"
> >  	depends on (SOC_STARFIVE && AMBA_PL08X) || COMPILE_TEST
> > -	depends on HAS_DMA
> > +	depends on HAS_DMA && !CRYPTO_DEV_JH8100
> >  	select CRYPTO_ENGINE
> >  	select CRYPTO_HMAC
> >  	select CRYPTO_SHA256
> > @@ -24,3 +24,26 @@ config CRYPTO_DEV_JH7110
> >  	  skciphers, AEAD and hash functions.
> >
> >  	  If you choose 'M' here, this module will be called jh7110-crypto.
> > +
> > +config CRYPTO_DEV_JH8100
> > +	tristate "StarFive JH8100 cryptographic engine drivers"
> > +	depends on (SOC_STARFIVE && DW_AXI_DMAC) || COMPILE_TEST
> > +	depends on HAS_DMA
> > +	select CRYPTO_ENGINE
> > +	select CRYPTO_HMAC
> > +	select CRYPTO_SHA256
> > +	select CRYPTO_SHA512
> > +	select CRYPTO_SM3_GENERIC
> > +	select CRYPTO_RSA
> > +	select CRYPTO_AES
> > +	select CRYPTO_CCM
> > +	select CRYPTO_GCM
> > +	select CRYPTO_CBC
> > +	select CRYPTO_ECB
> > +	select CRYPTO_CTR
> > +	help
> > +	  Support for StarFive JH8100 crypto hardware acceleration engine.
> > +	  This module provides additional support for SM2 signature
> verification,
> > +	  SM3 hash/hmac functions and SM4 skcipher.
> > +
> > +	  If you choose 'M' here, this module will be called jh8100-crypto.
> > diff --git a/drivers/crypto/starfive/Makefile
> > b/drivers/crypto/starfive/Makefile
> > index 8c137afe58ad..67717fca3f5d 100644
> > --- a/drivers/crypto/starfive/Makefile
> > +++ b/drivers/crypto/starfive/Makefile
> > @@ -2,3 +2,6 @@
> >
> >  obj-$(CONFIG_CRYPTO_DEV_JH7110) +=3D jh7110-crypto.o
> > jh7110-crypto-objs :=3D jh7110-cryp.o jh7110-hash.o jh7110-rsa.o
> > jh7110-aes.o
> > +
> > +obj-$(CONFIG_CRYPTO_DEV_JH8100) +=3D jh8100-crypto.o jh8100-crypto-
> objs
> > +:=3D jh7110-cryp.o jh7110-hash.o jh7110-rsa.o jh7110-aes.o jh8100-sm3.=
o
> > diff --git a/drivers/crypto/starfive/jh7110-cryp.c
> > b/drivers/crypto/starfive/jh7110-cryp.c
> > index fe33e87f25ab..fb7c19705fbf 100644
> > --- a/drivers/crypto/starfive/jh7110-cryp.c
> > +++ b/drivers/crypto/starfive/jh7110-cryp.c
> > @@ -106,6 +106,26 @@ static irqreturn_t starfive_cryp_irq(int irq, void
> *priv)
> >  	return IRQ_HANDLED;
> >  }
> >
> > +#ifdef CONFIG_CRYPTO_DEV_JH8100
> > +static irqreturn_t starfive_cryp_irq1(int irq, void *priv) {
> > +	u32 status;
> > +	u32 mask;
> > +	struct starfive_cryp_dev *cryp =3D (struct starfive_cryp_dev *)priv;
> > +
> > +	mask =3D readl(cryp->base + STARFIVE_SM_IE_MASK_OFFSET);
> > +	status =3D readl(cryp->base + STARFIVE_SM_IE_FLAG_OFFSET);
> > +
> > +	if (status & STARFIVE_SM_IE_FLAG_SM3_DONE) {
> > +		mask |=3D STARFIVE_SM_IE_MASK_SM3_DONE;
> > +		writel(mask, cryp->base + STARFIVE_SM_IE_MASK_OFFSET);
> > +		tasklet_schedule(&cryp->sm3_done);
> > +	}
> > +
> > +	return IRQ_HANDLED;
> > +}
> > +#endif
> > +
> >  static int starfive_cryp_probe(struct platform_device *pdev)  {
> >  	struct starfive_cryp_dev *cryp;
> > @@ -156,6 +176,16 @@ static int starfive_cryp_probe(struct
> platform_device *pdev)
> >  		return dev_err_probe(&pdev->dev, ret,
> >  				     "Failed to register interrupt handler\n");
> >
> > +#ifdef CONFIG_CRYPTO_DEV_JH8100
> > +	tasklet_init(&cryp->sm3_done, starfive_sm3_done_task, (unsigned
> > +long)cryp);
> > +
> > +	irq =3D platform_get_irq(pdev, 1);
> > +	if (irq < 0)
> > +		return irq;
> > +
> > +	ret =3D devm_request_irq(&pdev->dev, irq, starfive_cryp_irq1, 0,
> > +			       pdev->name, (void *)cryp);
> > +#endif
> >  	clk_prepare_enable(cryp->hclk);
> >  	clk_prepare_enable(cryp->ahb);
> >  	reset_control_deassert(cryp->rst);
> > @@ -191,8 +221,17 @@ static int starfive_cryp_probe(struct
> platform_device *pdev)
> >  	if (ret)
> >  		goto err_algs_rsa;
> >
> > +#ifdef CONFIG_CRYPTO_DEV_JH8100
> > +	ret =3D starfive_sm3_register_algs();
> > +	if (ret)
> > +		goto err_algs_sm3;
> > +#endif
> >  	return 0;
> >
> > +#ifdef CONFIG_CRYPTO_DEV_JH8100
> > +err_algs_sm3:
> > +	starfive_rsa_unregister_algs();
> > +#endif
> >  err_algs_rsa:
> >  	starfive_hash_unregister_algs();
> >  err_algs_hash:
> > @@ -213,7 +252,9 @@ static int starfive_cryp_probe(struct
> platform_device *pdev)
> >  	reset_control_assert(cryp->rst);
> >
> >  	tasklet_kill(&cryp->hash_done);
> > -
> > +#ifdef CONFIG_CRYPTO_DEV_JH8100
> > +	tasklet_kill(&cryp->sm3_done);
> > +#endif
>=20
> Please use if instead if ifdef where possible:
>=20
> 	if (IS_ENABLED(CONFIG_CRYPTO_DEV_JH8100))
> 		tasklet_kill(&cryp->sm3_done);
>=20

Hi Herbert,
I am using ifdef so unused codes wouldn't be compiled into the driver for u=
nsupported variant.
Is the compiled driver size a concern for such cases?=20

Thanks for review this.=20

Regards,
Jia Jie