Received-SPF: pass (google.com: domain of linux-kernel+bounces-47711-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7a063832-e1b5-42df-92cf-66486d4feecb@amd.com>
Date: Thu, 1 Feb 2024 12:11:15 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next 2/3] dt-bindings: net: cdns,macb: Add
 wol-arp-packet property
To: Andrew Lunn <andrew@lunn.ch>, krzysztof.kozlowski+dt@linaro.org
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 conor+dt@kernel.org, linux@armlinux.org.uk, netdev@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, git@amd.com
References: <20240130104845.3995341-1-vineeth.karumanchi@amd.com>
 <20240130104845.3995341-3-vineeth.karumanchi@amd.com>
 <824aad4d-6b05-4641-b75d-ceaa08b0a4e8@lunn.ch>
 <09ce2e81-01cc-431f-8acb-076a54e5a7e6@amd.com>
 <9b4a2c23-5a96-45eb-9bdf-cefc99f25fec@lunn.ch>
Content-Language: en-GB
From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
In-Reply-To: <9b4a2c23-5a96-45eb-9bdf-cefc99f25fec@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?aXo4cEovNWs4NS9DQUUvTnBTSU9IODNmNUtRWmk2ZnpKM3VOZS9KVGFIRzZQ?=
 =?utf-8?B?VjhtQ3Y3bU16ZVVFWlFVWm42NnNkK2NuRlp1Yko4NUVVYTZmYVEyRXNUcXlX?=
 =?utf-8?B?VHRleUFZNmNzMmdzRkFaWEpCSXBaMkpuNVRyeWl3SDI4M2hzWHBUMnFLaU1q?=
 =?utf-8?B?MHpnZWFSSTdPd1VIV0ZVU3BYVnJ2cDZraHFaakluSDlkeG9SOHNLY2dBaVBl?=
 =?utf-8?B?WTJYQ0taU21CaTdlcFVkVkFtd1YyYmVIUGwwWWVSYTNDQjVaSzhqazRYdjRO?=
 =?utf-8?B?Mm9yMndDUzBwWVhHRlo3OHNKVjA1SnMyMDJ6UjIrL1VQQlBrdDVoQmVnZVFR?=
 =?utf-8?B?b3R3bW9VdWNBWlovSVc3aG00NUdraHVwc1ZMRHJ4MVJiMXdkYjU4czdlRTRa?=
 =?utf-8?B?SkRCWnBCaWhUM1JqTU5iRWNWOUhuYXh2VHlkODJWRTF5Y0VKSWtobGh5djk3?=
 =?utf-8?B?ejdQNXB3V0NHRjM5SEpEY1VhazgwS25JTFh3OWxhWFhseVZMeTUvaVlWMk5J?=
 =?utf-8?B?aW9kQ243WjBpKzVrNkt1Q0ozUGlidXB1MDhYZXdhd2wzQTJtTE5jVzgrL0VN?=
 =?utf-8?B?WjZuQzRLN28xSFB0dzVsYWhiUzNGa0xkTnVrelVJOFBBTnlVY0tVQWRoS28w?=
 =?utf-8?B?YnYwNDRFRzZTbnlUbEVNbVBTSXp2RmNsaU5nK25IaWNIeEFXd2ZibkVscDJ4?=
 =?utf-8?B?dW94YkwvWlkxOG85R3BhNGIxSEdpbytRTitkZHVISkFNd2RPblovL3FsaXRO?=
 =?utf-8?B?ZWpEaFJEMUdtN1Jva05IbURsZmVFYjZQcVgxMHFxTTlDTGFueGg1cDBqZ2M4?=
 =?utf-8?B?ZDJLMUhwT1VMc0ZSc0Y4RHY5d2RNK0N5TzlwWkN0NmsvY2R6N2w2STdoSjhF?=
 =?utf-8?B?MGl4alFOTHFBbUMwcm1hMnZ3Q1JNazl0aEVYSkVNNW1raFRmQWh2aWd5aTZs?=
 =?utf-8?B?bTR0QzFYNWl2SEJsNHAyTGZPVjNGQXBzTWFSK0lsUzNPYWJmOUI4RjhIbHdj?=
 =?utf-8?B?YUVTMFNNQXc1Y1g2Qyt6NU5XcG4vWlhldVI2S056ZEVOSTd6aVdZZkQwS0hU?=
 =?utf-8?B?VnJUN0I4bGkrQ1ZPQVc2TXVhRWFtTWRaalZUeVFGOU55TDZrUUFUSE5MdFpP?=
 =?utf-8?B?NFhIZE5tem5WYlY5d0xzQTZZUkNMVnNCR3FvYU9haVVxOWZaOURJYysrOWg5?=
 =?utf-8?B?eklETGhlUjJaYW9EaG55NkpwS2Q0cVdwaTRiQVJPSFlwY2tOZjlJa2xlMVYr?=
 =?utf-8?B?NnpwRFNLbVI5NGJFVGlSeVY0aGN6N0ZDandXalkxTjk4R015TjZJRGFqTkhh?=
 =?utf-8?B?aW9TME5UaEt4YVEzcWVadTlDbWplSFJtRTcyNmxDT1dHVmxQbjBxdlNFa2xO?=
 =?utf-8?B?SXZyc2g3VGxGekhkblpJajNVUDR6Q3ZramoyaGE2VkFMejlGZENnaG5jTVY3?=
 =?utf-8?B?VlZES0tlUlFIQ2tiT25BNHBmVnJ0bndKNVlsNVhXRm9ZN1R2RFF4Z3d6WjBD?=
 =?utf-8?B?RkdRZy9vZUpaTUJzejdyTDUrcVZIV1RJRTgvbFU1VDdPSVBZcXFDR1NyUUhN?=
 =?utf-8?B?cXZYNlh4NkZLekoxUndYQlJwWTNIZkZQaldPL1lncTVlMllVbFNsc1I3ODRj?=
 =?utf-8?B?ZVJWS1ZaMTI5SWYyNWh1YnFxN25pQ0U2RmtDSHlqMjNWNGxLemdhUFpDWURI?=
 =?utf-8?B?Qnp6MkV4enFleDJ2M0I0Skd3Mlc1T2ZkK0FTUitaSjhHVVpjRnFCWU1yanZx?=
 =?utf-8?B?ZnNGaUFxdW1EdXp6Qk52MUVKUFc1a2dSRUdPdWozeUN2cVRJek90OTdCdUM2?=
 =?utf-8?B?a3ZEdjk0WWxhbXJMZDJlcFQ2MmdmNlNMQ1pSOWtLcGIrbVV5NEU5N1FWQ3Bp?=
 =?utf-8?B?SmFhRVRRbEJ4V2VEZ2xmcE8rSkliYk5Fc1JlZE92b3hVWXZ4RjFTWFYrU2Y0?=
 =?utf-8?B?endqRC9wajcxUGpVWHdpYXE4aVpObTY1UGJYV0NuT2hrOEFabG5aTW9HRlZM?=
 =?utf-8?B?OU8zOTlSOG5tbFJNRDZVQTJ3K0VSK1AyV09KOGdNRGREY0k3ZFVZNjl1eUNw?=
 =?utf-8?B?MmNsVXkwUmFqUjhBdzBoZ2srNWtmWFBxRG5vSlVFamNaeE92WW1HNkxBSXZX?=
 =?utf-8?Q?DvQ3hStlZg528/YEvHIPFHRKm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ddadc05-1f7c-4c77-23ac-08dc22f0ce66
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 06:41:23.2836
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XY0z4H4dwfHN/PMgx7nDf/PSxEs5maom2UYWocSIQ8mvQ9cyPLVRSde0uI2mWo/s
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8139

Hi Andrew, Krzysztof,


On 31/01/24 6:48 pm, Andrew Lunn wrote:
> On Wed, Jan 31, 2024 at 01:09:19PM +0530, Vineeth Karumanchi wrote:
>> Hi Andrew,
>>
>>
>> On 31/01/24 6:56 am, Andrew Lunn wrote:
>>> On Tue, Jan 30, 2024 at 04:18:44PM +0530, Vineeth Karumanchi wrote:
>>>> "wol-arp-packet" property enables WOL with ARP packet.
>>>> It is an extension to "magic-packet for WOL.
>>>
>>> It not clear why this is needed. Is this not a standard feature of the
>>> IP? Is there no hardware bit indicating the capability?
>>>
>>
>> WOL via both ARP and Magic packet is supported by the IP version on ZU+ and
>> Versal. However, user can choose which type of packet to recognize as a WOL
>> event - magic packet or ARP.
> 
> ethtool says:
> 
>             wol p|u|m|b|a|g|s|f|d...
>                    Sets Wake-on-LAN options.  Not all devices support this.  The argument to this  option  is  a
>                    string of characters specifying which options to enable.
>                    p   Wake on PHY activity
>                    u   Wake on unicast messages
>                    m   Wake on multicast messages
>                    b   Wake on broadcast messages
>                    a   Wake on ARP
>                    g   Wake on MagicPacket™
>                    s   Enable SecureOn™ password for MagicPacket™
>                    f   Wake on filter(s)
>                    d   Disable  (wake  on  nothing).  This option
>                        clears all previous options.
> 
> So why do we need a DT property?
> 

The earlier implementation of WOL (magic-packet) was using DT property.
We added one more packet type using DT property to be in-line with the 
earlier implementation.

However, I echo with you that this feature should be in driver (CAPS).
We will re-work the implementation with the below flow:

- Add MACB_CAPS_WOL capability to the supported platforms
- Advertise supported WOL packet types based on the CAPS in ethtool.
- Users can set packet type using ethtool.

Please let me know your thoughts/suggestions.

???? vineeth

> 	Andrew