Subject: Re: [PATCH] apm_event{,info}_t are userspace types.
From: Adam Jackson <ajax@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <20071212024700.19560b60.akpm@linux-foundation.org>
References: <1196452963295-git-send-email-ajax@redhat.com>
	 <20071212024700.19560b60.akpm@linux-foundation.org>
Content-Type: text/plain
Date: Wed, 19 Dec 2007 14:00:56 -0500
Message-Id: <1198090856.30771.236.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1021
Lines: 30

On Wed, 2007-12-12 at 02:47 -0800, Andrew Morton wrote:
> On Fri, 30 Nov 2007 15:02:43 -0500 Adam Jackson <ajax@redhat.com> wrote:
> > These types define the size of data read from /dev/apm_bios.  They
> > should not be hidden behind #ifdef __KERNEL__.
> 
> Missing info: what are the consequences of this fix?  What id broken when
> it it not applied?

The X server won't build.  Neither will apmd, but it's harder for me to
get worked up about that.

> > ---
> >  include/linux/apm_bios.h |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> Please include Signed-off-by:, as per Documentation/SubmittingPatches,
> thanks.

Blah.  Right, will remember git-format-patch -s next time.  In any
event:

Signed-off-by: Adam Jackson <ajax@redhat.com>

- ajax

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/