Received-SPF: pass (google.com: domain of linux-kernel+bounces-47843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: JiaJie Ho <jiajie.ho@starfivetech.com>
To: 'Herbert Xu' <herbert@gondor.apana.org.au>
CC: "'David S . Miller'" <davem@davemloft.net>, 'Rob Herring'
	<robh+dt@kernel.org>, 'Krzysztof Kozlowski'
	<krzysztof.kozlowski+dt@linaro.org>, 'Conor Dooley' <conor+dt@kernel.org>,
	"'linux-crypto@vger.kernel.org'" <linux-crypto@vger.kernel.org>,
	"'devicetree@vger.kernel.org'" <devicetree@vger.kernel.org>,
	"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 4/5] crypto: starfive: Add sm3 support for JH8100
Thread-Topic: [PATCH v2 4/5] crypto: starfive: Add sm3 support for JH8100
Thread-Index: AQHaSFqmtg6Zzl/qkUuu0ddSCEXpi7Drn0sAgAgJJNCAAWlFgIAACDkmgAAAhAA=
Date: Thu, 1 Feb 2024 06:40:09 +0000
Message-ID:
 <SHXPR01MB067059F064CD56ED58DE6F9A8A43A@SHXPR01MB0670.CHNPR01.prod.partner.outlook.cn>
References: <20240116090135.75737-1-jiajie.ho@starfivetech.com>
 <20240116090135.75737-5-jiajie.ho@starfivetech.com>
 <ZbNCKrTLXmPcsrSH@gondor.apana.org.au>
 <BJSPR01MB0659C3FE1262DF8CC7F7DA468A43A@BJSPR01MB0659.CHNPR01.prod.partner.outlook.cn>
 <Zbsu39gZn2cGrnew@gondor.apana.org.au>
 <SHXPR01MB0670720DD9EAB09EE8A1B13E8A43A@SHXPR01MB0670.CHNPR01.prod.partner.outlook.cn>
 <Zbs1xy4DesZDkFC4@gondor.apana.org.au>
In-Reply-To: <Zbs1xy4DesZDkFC4@gondor.apana.org.au>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?oR0Io1aye8+Y/7JfptN6c3Ly0MVEhmYmqAbyS0GcKUrBWu9BNKjnR9LFxCQv?=
 =?us-ascii?Q?zw+0DjMwpNZsIz0xKmHX6HAKDzjmZ9b3xB3o2cZic+aqrLMInQcXs41ZsonF?=
 =?us-ascii?Q?41jDLbXwOd6DgeZMhObEw4r1lCPkWkdoms5QE0V7OdqFGgGWcg1zOkJmH+6O?=
 =?us-ascii?Q?RIV2F5p7d9+gR9xfQZgQsa1JubIZfTYxYUzKFiVgq16u6iSRegjBHIk5s4JL?=
 =?us-ascii?Q?gAYTtWDVthUfUKN2X4c/86IXPgnq4MkFWT0Y144pA1IOu6zuv4F8Zq3sCHFy?=
 =?us-ascii?Q?DdttP0RAOytA1F5l1LdOx9hefth0c9u5VwJDLRLWGCs66qZJrbnc9Qs18WwS?=
 =?us-ascii?Q?+/1bTKL61kfWPGPDpKHg/t+WgkZx9AQ2Z+Eu1Y++ZX07dv+QZPagaR6mgt9B?=
 =?us-ascii?Q?l56OmDnYupa4e69fSzKgQBiUTdBvkXQEcC9GAR1d4J8ked8QPFIoBSb4rhJU?=
 =?us-ascii?Q?Vs4nnQokG1VVnpwWB0FhYazqZzgU22erJqYI8uQRjDLHzCLPH+tmJEegAdC/?=
 =?us-ascii?Q?C4WPdi00EY5ZaIGbF2DIA2hio9mqYZ2qiA12IEGYO7f/+f4sxLPVhReNXHDY?=
 =?us-ascii?Q?iMElVScnskdkSAmyc6uB+XoT/HipijqPBS6VoNM4iqj+IfppsXyZ0l7bpQ/V?=
 =?us-ascii?Q?pJDmU6NzfpAy6vuP0GHKDrxwyHN0r7k+rPSNCmdmwvB1ogEBU8LytbX7LqSc?=
 =?us-ascii?Q?2nEsui+IgGcNF8suFHJfxF/fLGBt/fDJX7D33kQq7UPRFhBXrewx8zlbXTIV?=
 =?us-ascii?Q?Zv086C2lqh1F+jMct0x7HKwFEWlrfbrITvpu1gi4xAHf4ehoWtNq9QF6Vq33?=
 =?us-ascii?Q?t6rTqr9JOxlTzzC54ZHvKKCKOS7pWcROBzeMuDhEd0TCW3XKne7bW5QIR8Qp?=
 =?us-ascii?Q?Mk5ZJfwdzXyWSa2cXsIatp/4fOv/CSCmcL0io8AE2gzwnme1oNXohOEqePcV?=
 =?us-ascii?Q?cqW3dMo0B1koj7KTTmrQcUXZWxGL3U6Wa+Nrfu0AwCpiAqaj/fT2m2YHK/aU?=
 =?us-ascii?Q?FnXpUjlKjEOW1iODsHnGdFIk1rZyBNNu2rRDiF7h3iE/6jxKHAW9M3ixMyo5?=
 =?us-ascii?Q?7S0H2Bx3EXsD4WVdtp3vIQBC7ZWxxnbMTiarinaurQqSHLz7pqgoHOcqa1Dq?=
 =?us-ascii?Q?IxfS/LI6F0eGWp98802injjsUQpPVn5q1QvB4dE+W35R5qDJ8WUSIPVi+IrW?=
 =?us-ascii?Q?WjXDq8XzDqJhBuihBbh3MXtjqPl208WG5fQTQBDYQiDxBVVx0mfgLixQza92?=
 =?us-ascii?Q?zVj1i2Rcjk3z4cyGxWGn/6ujFAomOPTTtGnLqJJ656W22AEmaL38NimyTAVb?=
 =?us-ascii?Q?CSSeT3uoFOl5z+GD/Q5P72kKjYF2wPmdUIK3kYys3x9ce6fWzPYX6X7+du+a?=
 =?us-ascii?Q?920DRa9ciQBkXn5KkyOFPa0e2x1F7yEf2K/YkRohtZ/1UYTS+1LKLQSnLZkI?=
 =?us-ascii?Q?iv9AvrRQVOhe+vzzaiXzVtg9vZdgtvkaRXRTIw/L0CkzsN65bzb4LCxT6+P0?=
 =?us-ascii?Q?NYtzH9rg3Mj6vScn1m5NrHz8QyybSP9g3fVOsZuEy4QFtxx9xmiFStCXg3uS?=
 =?us-ascii?Q?ENnXmvsswmyqwRQ1+ghHD6/dl/Vv1/IwHapNagssLVAiAS2or4Wtty08NWwX?=
 =?us-ascii?Q?Tw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: starfivetech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SHXPR01MB0670.CHNPR01.prod.partner.outlook.cn
X-MS-Exchange-CrossTenant-Network-Message-Id: 34391265-901b-49f9-adf4-08dc22f0a286
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2024 06:40:09.3195
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Y8ewIx5fbH6UFMFVuBD9rukieTODpVS5dr0ta9rmUvEpBjucaU2+vJ0U9s20+fdauqHiyI4Q4Z0xRifndbA1Ju3yClAPmXjNnEfpmMWGIec=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SHXPR01MB0880

> > Currently, the object files defining new algo register/unregister funct=
ions
> weren't included in Makefile for unsupported device.
> > Compiler will still check for these definitions if IS_ENABLED is used i=
nstead of
> ifdef causing build errors.
>=20
> Please point me to specific examples of something that's included in the
> output and shouldn't be.
>=20

When compiling both CRYPTO_DEV_JH7110 and CRYPTO_DEV_JH8100 as module,=20
the compiler flags the following functions as undefined even though they ar=
e folded in IS_REACHABLE

#if IS_REACHABLE(CONFIG_CRYPTO_DEV_JH8100)
int starfive_sm3_register_algs(void);
void starfive_sm3_unregister_algs(void);
int starfive_sm4_register_algs(void);
void starfive_sm4_unregister_algs(void);
void starfive_sm3_done_task(unsigned long param);
#endif

ERROR: modpost: "starfive_sm3_done_task" [drivers/crypto/starfive/jh7110-cr=
ypto.ko] undefined!
ERROR: modpost: "starfive_sm4_register_algs" [drivers/crypto/starfive/jh711=
0-crypto.ko] undefined!
ERROR: modpost: "starfive_sm3_unregister_algs" [drivers/crypto/starfive/jh7=
110-crypto.ko] undefined!
ERROR: modpost: "starfive_sm3_register_algs" [drivers/crypto/starfive/jh711=
0-crypto.ko] undefined!
ERROR: modpost: "starfive_sm4_unregister_algs" [drivers/crypto/starfive/jh7=
110-crypto.ko] undefined!

The object files defining these functions aren't included for CRYPTO_DEV_JH=
7110 in the Makefile.
obj-$(CONFIG_CRYPTO_DEV_JH7110) +=3D jh7110-crypto.o
jh7110-crypto-objs :=3D jh7110-cryp.o jh7110-hash.o jh7110-rsa.o jh7110-aes=
o

obj-$(CONFIG_CRYPTO_DEV_JH8100) +=3D jh8100-crypto.o
jh8100-crypto-objs :=3D jh7110-cryp.o jh7110-hash.o jh7110-rsa.o jh7110-aes=
o jh8100-sm3.o jh8100-sm4.o

Thanks,
Jia Jie