Received-SPF: pass (google.com: domain of linux-kernel+bounces-47889-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Simon Horman <horms@kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org"
	<kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "bcreeley@amd.com" <bcreeley@amd.com>,
        Subbaraya Sundeep Bhatta
	<sbhatta@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Hariprasad
 Kelam <hkelam@marvell.com>,
        Suman Ghosh <sumang@marvell.com>
Subject: RE: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.
Thread-Topic: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.
Thread-Index: AQHaU+79TbtFO2tBSUm3sTNVRXPo/7D1OvSAgAAAf0A=
Date: Thu, 1 Feb 2024 09:35:15 +0000
Message-ID: 
 <MWHPR1801MB1918CFDBEC70A298A3781945D3432@MWHPR1801MB1918.namprd18.prod.outlook.com>
References: <20240131024118.254758-1-rkannoth@marvell.com>
 <20240201093119.GB514352@kernel.org>
In-Reply-To: <20240201093119.GB514352@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?nZVykvJmWtyy3Jo0GMzXBywAM1gHBBkYoEnB/xOPYshJKWgiiA0PGy8eK02x?=
 =?us-ascii?Q?HpLSyNidprTEB1tp4cv2Zvr18a65/vRkPpp/NhU7WfDjmTj6gNfPp3sfSuvz?=
 =?us-ascii?Q?wsIeuhxVOvjN/75NF1alzSNueeOzXEwrs7nE4kFll/CTkYfteanjw5Dbacl5?=
 =?us-ascii?Q?yyHah6t880RZVq51j67QedcAuFzs5dDgk0TCFD98UAyaPYrXQPfPsR6BbqfB?=
 =?us-ascii?Q?gVUu+p0nnHhcysdIAzni2n6vOc41oXeScJyw5Vlzh4WjMFIMXOX0e7LIRe+x?=
 =?us-ascii?Q?RMgIyKYcALFVsG8xs74ftF8LFSErQGk8vVQZBDtzxsOU9w0fKv28enlVrKZP?=
 =?us-ascii?Q?yp8Umq0A5WrjNCNJ2FwvfrvBQr+TPEs7yuqgEzmgkgst4JRbcSgtK/h6rTOn?=
 =?us-ascii?Q?6R/sxKfDys5wRLPqw3thg0xZP6ouAAvTc5vQqcSTpnLduuDqcl3mH60gXS9K?=
 =?us-ascii?Q?Ym6ccE5rjzoAGr71S/QaVBYHBwYmBWe+yKrmt1y0jfn6TKeWf55gFgZ4F+qv?=
 =?us-ascii?Q?q0uuA3QCSHdKMio+HIYHFSHcLcqekXbA37UzQGs0Us66Mncoauvb3vjBzCSI?=
 =?us-ascii?Q?WQkr0Asym868uWbsyEgWohKAQWv6fUNwUpDdptssoJc2bSlvfSEokgr0gYug?=
 =?us-ascii?Q?sbGHPMR5iumyPaRXOywCBWWB8fuqhZveX4YErrpyBilL7pqCdhKJTBtXoeiO?=
 =?us-ascii?Q?6LK7UPqvYLDY59ETHqITAArNIBw8Xirz2k34G2GsJVGy6bxuzidfRDx1ZE4r?=
 =?us-ascii?Q?RlSW2nrBxQY8gX1YQGcuIf8jm5Uus/Esw/HdjSBcCGxUfazx+9r+BfOQ/HC8?=
 =?us-ascii?Q?aYluvWcgRSbxfiq6iix5vEifdKtEExF8jVXWpA2nf0ni3uyMx+bagMfcGewf?=
 =?us-ascii?Q?/ZVQalqy4IdcSsodwwjyS3i4G3gJbwd/k//y6BaneWKqbeLfTPqeuqzNQJHt?=
 =?us-ascii?Q?4bhtgF7GEBI5YjPnZ+yjEfPiw23si7NqktxbZUJPV1stc4qQcRLBqe6UDo6K?=
 =?us-ascii?Q?Prj8RGhUZHt/apTkDSvVtxvBhas3/GdZZh3rpbC8QhpXIuIsw0bcr1f7m07T?=
 =?us-ascii?Q?NDElZEwEt+LVfQ9CeSGT1mdBzMFx3YYKRUnkGeAxa3PnG/Pn1zcizt+dGdvP?=
 =?us-ascii?Q?Goq8dlLSNBU+3NoM8VysHSyGHBKJydhw2KTxlJr64asvm3UKQeFruSSWJb8G?=
 =?us-ascii?Q?TeveF7AxeznS66R7Qz0VYbMhnmJAundxoJouXf/RKAx3zojn3JMtnC60jz8B?=
 =?us-ascii?Q?SQweQ3ln00n6w6QLzchKGko7YeHJVpxoW4YJ5+YPtYvDxQ/Gj1akzynZUwMt?=
 =?us-ascii?Q?FGebN46XFuQrsx1eXO4Kh0aHiPlzgeCTqNrV800flsuacqwalGvk/FQRwDn8?=
 =?us-ascii?Q?qfVXN+mPhgZThlnrTegBVjBCYpdNvgRqeisbTiwv4Prx7k87BuSe2Uiy+9of?=
 =?us-ascii?Q?BCu5yJpyOp2wYLov4AQdyWUMLizYvKOdsCvWpbGHvPIEVAllb22Q9WoUh3lr?=
 =?us-ascii?Q?7vCbMZOz8vDRX4ANklljo+YTG23jx5voVL6RQqk+wl92eLuTivVnpP8Y7rWI?=
 =?us-ascii?Q?FORNvzxfKAt6SHlqX+ddKQR6wSj4bn9F5/lXtUmM?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1801MB1918.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4c0b0a5-1b0b-44d0-d7a7-08dc230918c9
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2024 09:35:15.7191
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wHQx19B4VADFrMZq+mEtjKDtjLERhjVXjLLKWVOe18dBiMjvtWiI0+qOpd7ZNLIby3wxDcppqXNlHUo1P91OIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3665
X-Proofpoint-GUID: x-7A1q1QixzquzywOwLYLkdtkXdDoUH7
X-Proofpoint-ORIG-GUID: x-7A1q1QixzquzywOwLYLkdtkXdDoUH7
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-31_10,2024-01-31_01,2023-05-22_02

> From: Simon Horman <horms@kernel.org>
> Subject: [EXT] Re: [PATCH net v3] octeontx2-af: Initialize maps.
> >  	/* Alloc memory for saving entry to RVU PFFUNC allocation mapping
> */
> >  	mcam->entry2pfvf_map =3D kmalloc_array(mcam->bmap_entries,
> > -					     sizeof(u16), GFP_KERNEL);
> > +					     sizeof(u16),
> > +					     GFP_KERNEL | __GFP_ZERO);
>=20
> Hi Ratheesh,
>=20
> The use of bitmap_zalloc()/bitmap_free() looks good to me.
> But for the kmalloc_array(..., GFP_KERNEL | __GFP_ZERO) cases I think
> kcalloc() is the way to go.
Kcalloc() is a wrapper around kmalloc_array().  Why do you think kcalloc()
Is better ?