Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp54658rdb; Thu, 1 Feb 2024 01:41:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IGKjuA9y23/Fu9No78cEQnTpTdPHX/D8qAU1nNLmIzLaiYqDcqc0n/a0Ugli0N+W/kS+DCH X-Received: by 2002:a05:622a:547:b0:42a:b313:e9e7 with SMTP id m7-20020a05622a054700b0042ab313e9e7mr4920158qtx.8.1706780485987; Thu, 01 Feb 2024 01:41:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706780485; cv=pass; d=google.com; s=arc-20160816; b=iXJvbINMLHhbLu6OyaMErhRAIVGfkkTXRYJJPSYRVfhCAkIbZ3hVH8n6SvZP3Yj4vI QKeHoEcU0REkDjbf0kL9EQv6CxvTz5EWtP3SmwlROZg8QlBek23apFSjYUmLEYwbzJ9K CVVc9rMZn2DSmKwoDoF43ITh5SrYvFhUnxGSzEok5P1xDwdSKcaJqNpvSFpTe3QlCQd8 1QkARpD11daG+VYB6t8oaGMeOgdT67XG/fx+A3vE8PUo8FpaSHN6OnxQxx30fSyWVjOB LdD2ReKz3dAiq8yt06KtlCilXJ8qN6wMT51bPIASA7QCweylLPG6Voh4kAxz0N4QMICq P7Ww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=L9Q5jjgLj7eKlaEplPRaPpJNFTv/wD2bvjRT6tpdFWY=; fh=V2E/wBqXahd5us+cekubYlrPO/ScLjoDAf4ClF4qshI=; b=EEiEaGb8jS2jwbX64Iw9ydz5z82Era93gt8/Mz/Fv8KH8rG246OI9iy0UWIYVOlU4T 0qPBmqR098ERMEvK2b8nzmPTDW2lgBPcLOuYTUa8+XSWymIn/bZ6tm+IZoJ34yPL76OV Qi9SGeKzYAx1Ytm+2bqZFOd53CwOjSYEQh+7xtr7rbopB1uZd2kvovIWUk+IQlYRbrko XPI/bq9mq4jIzcQrVHzv4czv2y2xEo1I/iwGQ30wLD0lGnZBVuasoGdnhYvQv5R/i3iD k5VO1yvjc/A45GIVUvnQ4Z5auhCsDLNGHjY4ajMVSzSojIramcJX8qt4jWGaVhqq77rU AykQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=bOdD5Fm5; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=vQerAkrn; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-47898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-47898-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de X-Forwarded-Encrypted: i=1; AJvYcCWUfun0NcayMCpR5C5zdIuOHcCc+EgTo6ccvb4L/g8L+/IXiT/bNiFIxw1RSiES9Q/TGxkixnzxwQqmdEKjgbAMpa7h8AOLh+6GvjDxSQ== Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f2-20020a05622a104200b0042bec7f516esi2439215qte.521.2024.02.01.01.41.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 01:41:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-47898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=bOdD5Fm5; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=vQerAkrn; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-47898-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-47898-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B9A9B1C21520 for ; Thu, 1 Feb 2024 09:41:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 181F74DA1C; Thu, 1 Feb 2024 09:40:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="bOdD5Fm5"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="vQerAkrn" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8724C4DA05 for ; Thu, 1 Feb 2024 09:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706780415; cv=none; b=nhN/foN6V66DBjMP392sOigJsuA92LoDqzQdMwYeONucsRc4vDluAhX9jpK3uIJ7ZJOIcYTZ1jccEEpV0BxjN2ngkvsB/MQrY9//3gji55gK/YyMIlu2PsrwYVL8a7jU2bSgx8bGWv+w/uH7NRS9GuHuVD8LL3RXCfqh1SxX7TU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706780415; c=relaxed/simple; bh=Yw6CwQJLniazKUtT+U8g4/MPXo7C7LOlF0oEgz0Hd6Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=joGn3dYdoWmB7o7q3FasXAOsHcjBTIR+QOxWYYfgV8HPbQFCAh6i61wEIjhY6iXTdtdNZJrutWULf1DyK+pHtDoyKXBPZs2f1wEQC9pLw+QxMIZeoHTLeb9oAIP7oJQxpnZBJWAJHYmHbYEsbe9oz9hOEKQ9dAZq0xDHo2yXGmA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=bOdD5Fm5; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=vQerAkrn; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Anna-Maria Behnsen DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1706780411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L9Q5jjgLj7eKlaEplPRaPpJNFTv/wD2bvjRT6tpdFWY=; b=bOdD5Fm52sMGMNvlYxz+G0SbuJ8CA7fxNcoLfj0XhHW56JEzbfm3ZZwM2h4vpz2eb4vbRj X22gG30mWHdPEVXdy+XhjqKCHsy5c+vZKngice0MF6GTqqG6vVSxGlPCxrP1VtnAxR2Pe8 7pqgyDmcCYx5rJFncWP4UKjC6P3TkQ9exOt19hU80zBNV3eIEoBlT0B8QNaFtnFhpvKZHk mL2FHM9YdZ1ZiZu6gndH+l5sDCNZv6EyBUKeroLXrU0NHim4pCvR0i5oqwKF10UQ9/9rwm UWd6WA9SPnANYTwnSs3gB3EPtMTuqEcUFZkIm8vFCZHWvjPc/lSchpw36JTVXQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1706780411; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L9Q5jjgLj7eKlaEplPRaPpJNFTv/wD2bvjRT6tpdFWY=; b=vQerAkrngqmJyay481fVBltJpflVSbLF5biadgNMh/Ff9sFj/XnNsfmXhNEQFMEnEJ9or8 QSrfr4Xkp5PP/JCQ== To: Frederic Weisbecker , LKML Cc: Frederic Weisbecker , Thomas Gleixner , Ingo Molnar , Peng Liu , Joel Fernandes Subject: Re: [PATCH 03/15] tick: Remove useless oneshot ifdeffery In-Reply-To: <20240131231120.12006-4-frederic@kernel.org> References: <20240131231120.12006-1-frederic@kernel.org> <20240131231120.12006-4-frederic@kernel.org> Date: Thu, 01 Feb 2024 10:40:10 +0100 Message-ID: <87ttmsikud.fsf@somnus> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Frederic Weisbecker writes: > tick-sched.c is only built when CONFIG_TICK_ONESHOT=y, which is selected > only if CONFIG_NO_HZ_COMMON=y or CONFIG_HIGH_RES_TIMERS=y. Therefore > the related ifdeferry in this file is needless and can be removed. > > Reviewed-by: Thomas Gleixner > Signed-off-by: Frederic Weisbecker It's a nitpick, but shouldn't the ordering of sob and reviewed-by be the other way round? Thanks, Anna-Maria