Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp71668rdb; Thu, 1 Feb 2024 02:21:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHvRmwmouD4cAqaAxsSmZXwc2EAPQpFB7tu7yQxS9BMKKV2E3panp0mR2CLDfqBar5zKsSt X-Received: by 2002:a05:6402:64f:b0:55f:3cb:9cfa with SMTP id u15-20020a056402064f00b0055f03cb9cfamr3182207edx.30.1706782892534; Thu, 01 Feb 2024 02:21:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706782892; cv=pass; d=google.com; s=arc-20160816; b=ZhsohArot4WELlQGGbQLUspF+ePLQqY3nUtwBr2ruSFKLKvM5utWj1/2RXDAhcIis3 1hjjgWu8tqLwUKlbFOOj+rk0nJbvjxEKGFaGMZjXycpfQjAkaCcSRBKkPpr+aAi3uosK Mohr8+RdkyWWBtMqoqXoQ5zowc0PWQaiBF2WLRU+WeRZHc87Nvx7Lu3qya6/r5leGyK4 8ULGYpLdE1WyJlhb2gG6m0Q2YfKNkg3Id6+uZ+XVvBcNkBH+2YLRKgv0/I93STzTYNRk /pzJNnWWIhN//sSMZ3FVZ+EJlfYgutOqyPgnFsvsoW5MFxe5/0Jz3XvC17RMWs5Sb8Qx J0hQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=MYDnbfsETKCELJuMed11V/BQVWPWtgTVNwmm/QZrLwY=; fh=G+fzlp7hcftCIEv3CgZ9LS2JTbrKIDvZ3nq9gfhdAtU=; b=B22otGXYke6SOoYIZWoqx7t5MmwS2q9eE/1PBHf6SaPTNrxs8oNAbHj7HM4uVelAEZ J/8cRw9uGU4dp1EXVVVROLgbR6xdeEGJv5fupd3qDZ7j9+IAY9K9kDryh3W1YlC0cU5W oSThDCtQSkpUlkD8/vwOHnGIz2kwoMSTXrFIIyq5MngH1xPxXSCLad5BNurg+JFiwGo9 FwNrwNizcfQMBgwlPnIJWZAedb+NNeqnft5QQijCB8ojgeVDFRZgMbW4/kiOubqO497z qzUOUuM42Y3EtSJ/KfRhw+/Dq2BjGgS7S49z30YSBJ+IisiW5g25DGPrDlvgkK4Px2+m erFA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Lwq0jZUI; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-47953-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-47953-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCXy3+gLerJjTZwlWHLDrLwmwgyjfcDKIRkJILwxlbnTk6hukyFxxtnKRQvfFkQP/UlNU6lJPu2QU9/QAOYTwqdO53EE8azlfy8Djt/yUw== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id c25-20020aa7df19000000b0055fc1ffcee1si313176edy.594.2024.02.01.02.21.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 02:21:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-47953-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Lwq0jZUI; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-47953-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-47953-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 449361F2DF66 for ; Thu, 1 Feb 2024 10:21:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 066AD15B96F; Thu, 1 Feb 2024 10:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Lwq0jZUI" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2419A4DA06; Thu, 1 Feb 2024 10:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706782876; cv=none; b=MNQ79MMmxh8WyHRpnBYRPdDIUPN2mQ03gGreHCl3a9tO7D45H/N4l3EcWs3B2CMMNSfCFrfRRWa46/VB8sV1KfNECQ7jawnfPluUtt9n8rCUaaTuNB4Fz6d+803HuRXOCARJA9wfCQzOMGdV8XHMBRztc1CLcWxbRCYbMP7MCbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706782876; c=relaxed/simple; bh=p7kLDUFLd7rjovPMsYMtGm/nnUJKbjK4ZofGZ628x0I=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=MQbJNXTJtzCSPJ0ICGT6PfBzZV8sCf/FX4ydWvZ7C0zt3ZZ5QW6hnt1Q4UJ+SwU0UbEg2N5p97q7QyN+nWgnItV3+BwmdObrr3J+ExuNJYyMsyBmNP+b9iEhGcc4oZbeNHvqvIJxn6g6NN0o4okqK3dQB0m06Yuc+BjUq7uabW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Lwq0jZUI; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 706CAC433F1; Thu, 1 Feb 2024 10:21:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706782876; bh=p7kLDUFLd7rjovPMsYMtGm/nnUJKbjK4ZofGZ628x0I=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=Lwq0jZUI+6qSM0K9t6B8VaFbzBEYKAf0CywnG68NDwn/9EZFB+Xa3pCdh54PhW3dd rofkx03iV1nGm++sTu6iazQGTtQ7npoh15RYzhkEzEnx63FSA7pp0XoROeAef74ggx nxRatuZgZWcy76gncBOF56OxJKTNd57vqiN6fsE7Bdb6dC67UX+hgMUNpOLZAs9K2i 0D/c0U2gszkQ4U3nYAl/+kJjPVA1XisknsRx7AdtVrk/PEKoZjQfb9bdLnyw6T8WfQ fXxFrjEb68ZosiRNILjvnjKvN37oR6qz3LRdW1zE7zMmTFDY/PwHKOxE+4WDE67+XI bf2EX0rXdtjQg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtl8xxxu: fix error messages From: Kalle Valo In-Reply-To: <7b144531-a8da-4725-8911-9b614a525a35@moroto.mountain> References: <7b144531-a8da-4725-8911-9b614a525a35@moroto.mountain> To: Dan Carpenter Cc: Martin Kaistra , Jes Sorensen , Ping-Ke Shih , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <170678287278.2736043.14378506532887522258.kvalo@kernel.org> Date: Thu, 1 Feb 2024 10:21:14 +0000 (UTC) Dan Carpenter wrote: > The first parameter of WARN_ONCE() is a condition so this code will end > up printing the function name instead of the proper message. > > Fixes: 3ff7a05996f9 ("wifi: rtl8xxxu: support setting bssid register for multiple interfaces") > Signed-off-by: Dan Carpenter > Reviewed-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 17903a283593 wifi: rtl8xxxu: fix error messages -- https://patchwork.kernel.org/project/linux-wireless/patch/7b144531-a8da-4725-8911-9b614a525a35@moroto.mountain/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches