Received-SPF: pass (google.com: domain of linux-kernel+bounces-47957-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <ad0b0ce4-3f20-4268-ab86-165a9e8bfbff@quicinc.com>
Date: Thu, 1 Feb 2024 15:53:48 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [V2] i2c: i2c-qcom-geni: Correct I2C TRE sequence
Content-Language: en-US
To: Bryan O'Donoghue <pure.logic@nexus-software.ie>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <andi.shyti@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <vkoul@kernel.org>,
        <quic_bjorande@quicinc.com>, <manivannan.sadhasivam@linaro.org>
CC: <quic_msavaliy@quicinc.com>, <quic_vtanuku@quicinc.com>
References: <20240129061003.4085-1-quic_vdadhani@quicinc.com>
 <b94c4c9f-a3dd-40fb-a80e-569199e93ee2@nexus-software.ie>
From: Viken Dadhaniya <quic_vdadhani@quicinc.com>
In-Reply-To: <b94c4c9f-a3dd-40fb-a80e-569199e93ee2@nexus-software.ie>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 1/30/2024 8:54 PM, Bryan O'Donoghue wrote:
> On 29/01/2024 06:10, Viken Dadhaniya wrote:
>> As per HPG(Hardware programming guide
> 
> Since you are doing a V3 here, please amend this too.
> 
> "As per HPG" means almost nothing outside of qcom.
> 
> "As per Qualcomm's internal Hardware Programming Guide"
> 
> Right thing to do to reference the document IMO but, you should make 
> clear its an internal silicon specification that's not public.
> 
> Also not sure the TRE description adds much.
> 
> Just give a high level description of the sequences being out-of-order 
> with respect to the hardware spec.
> 
> ---
> bod

Updated commit log and provided TRE description with sequence in V3.