Received-SPF: pass (google.com: domain of linux-kernel+bounces-47975-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <6872e9ea993633dff4e248f01cafd1ac32651355.camel@tsoy.me>
Subject: Re: [PATCH] ALSA: usb-audio: retry clock validate when it takes
 some times
From: Alexander Tsoy <alexander@tsoy.me>
To: vincenttew <vincenttew@google.com>, perex@perex.cz, tiwai@suse.com, 
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Date: Thu, 01 Feb 2024 13:36:11 +0300
In-Reply-To: <20240201070641.401684-1-vincenttew@google.com>
References: <20240201070641.401684-1-vincenttew@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.2 
Precedence: bulk
MIME-Version: 1.0
Sender: puleglot@puleglot.ru

=D0=92 =D0=A7=D1=82, 01/02/2024 =D0=B2 15:06 +0800, vincenttew =D0=BF=D0=B8=
=D1=88=D0=B5=D1=82:
> Behringer UMC202HD and UMC404HD take some times to validate the clock
> source. To prevent more DAC have the same delay which return the
> false
> in the first time, remove the USB id check to have a chance to retry
> the
> clock validate.
>=20
> Signed-off-by: vincenttew <vincenttew@google.com>

Thank you for the patch! My thought about this change:
- Retrying clock source validation probably make sense only in the case
of Internal clock. But I'm not sure.
- If we want to make this a standard driver behaviour, then the code
needs to be moved out of the quirk function IMO.