Received-SPF: pass (google.com: domain of linux-kernel+bounces-47989-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Carlos Song <carlos.song@nxp.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
CC: "broonie@kernel.org" <broonie@kernel.org>, "shawnguo@kernel.org"
	<shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>, dl-linux-imx
	<linux-imx@nxp.com>, "benjamin@bigler.one" <benjamin@bigler.one>,
	"stefanmoring@gmail.com" <stefanmoring@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-spi@vger.kernel.org"
	<linux-spi@vger.kernel.org>
Subject: Re: [PATCH v3] spi: imx: fix the burst length at DMA mode and CPU
 mode
Thread-Topic: [PATCH v3] spi: imx: fix the burst length at DMA mode and CPU
 mode
Thread-Index: AQHaVPwEME6t2WRuYE6Wft2lrEFNzA==
Date: Thu, 1 Feb 2024 10:47:14 +0000
Message-ID:
 <VI1PR04MB500557BCDB04B9385F20906BE8432@VI1PR04MB5005.eurprd04.prod.outlook.com>
References: <20240201100115.503296-1-carlos.song@nxp.com>
 <20240201-resupply-doorframe-feb41940155f-mkl@pengutronix.de>
In-Reply-To: <20240201-resupply-doorframe-feb41940155f-mkl@pengutronix.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-1?Q?ZT9r/0u6yMmWvs/VDu+N373vuUBDqfhmCYnIlnidRKBvmXVSsFeT8AeRje?=
 =?iso-8859-1?Q?8Umg26gTgsiUTeLZVF87Krc6t39ZhFz8JHrae/SNaf3dm43FgiXAZGjaOE?=
 =?iso-8859-1?Q?wKUs46eux5Ftbt4/MrHh1JsCsjJLMD0cFpcUZl8p5wMk+mG8mhLix9gVTK?=
 =?iso-8859-1?Q?zaZGPSomNJYhzelP0S09LTxnH9SqNH6toUmi6A/fyvXm7nYhnkvicjixjc?=
 =?iso-8859-1?Q?ncwtUB3pg2TVSWe4YQwIMPQk66GxMJOC2KWsvvOjeboUuDE9DnV/gCxBfv?=
 =?iso-8859-1?Q?/cIZ/5MWx0jSza4L4UDfYesUZg8H1YtMYLlcb+gIHS7TgJvisbgv/OQGWy?=
 =?iso-8859-1?Q?6O/89rDKkbBk2n3LF7EOAdqvLX5PiI2jat3EjWjFwiMk1sTdGAmC2nCuLw?=
 =?iso-8859-1?Q?5k5lDjap7dpUxhZ5suR5aSE7PC9rE+h2HMYLHJeeKGbxAWz1WmdQAVkT0p?=
 =?iso-8859-1?Q?hFFlVlUDwENDJouAYAB29OTa/KCUpY/J0biMMDOjkPs3/D+oYMNzCE3mzX?=
 =?iso-8859-1?Q?jhRs2vhrKvUYk0Zg4ARc/+bJqAVBrWZmkeNirPZi6YJWaCf2398E0tV8/5?=
 =?iso-8859-1?Q?f02XnwbLaZRaOaWVRy/StOGxVWLx1knS9NbQp9MQ1s/P8WEs4/NeRA2m8H?=
 =?iso-8859-1?Q?tBflHEmAgVTfrYuBDyzviZ7C8Wpsy6fjM8NUI6tXUel/FngJyCA3/GzYc3?=
 =?iso-8859-1?Q?bI0a78yb8BESwLHnh6CUPVvwcce/QbwE7MrVYom/COEWA6eeOvej4OORV/?=
 =?iso-8859-1?Q?19KRzwLMsRHDeBPvdUJURbHffd0VGqEi7/CEhUbk8kGmi7fr++UFL35wIX?=
 =?iso-8859-1?Q?vrQderKY+75olZrYoYFL968bwXxMPdWXoAleteqtfjnkJDLChGkZNtOWSc?=
 =?iso-8859-1?Q?IeiAF9JYhhGqJ0jkjZ4ov03gNhXzvsTchDhagUmJa9UnG/BcHm15qFUW8G?=
 =?iso-8859-1?Q?XYqbG0tqJaA7w2u+/77wOV564D0A8SGl3fG6PtRdmH1sP1kWhJAco3TCtc?=
 =?iso-8859-1?Q?HiWpJaQclltgvlZOmgoN8ZcJeRE+Nj50/59cJRgO81LfYoPf7ckspWRO43?=
 =?iso-8859-1?Q?+d914Gv/siyWYiyppAIfXCcib+dEjGcdiFIPow3pAucsLBL7qThXLS//9T?=
 =?iso-8859-1?Q?dKBJvgTc/tyoBxXu4HqeBwc+dSx4I70MjyLlXMxloi5TtDFa/ZcaBQHTuJ?=
 =?iso-8859-1?Q?PQQdxIi/Wjn/QRY0F8UQ+41394hx6e9Sc+7ofxnaS97l1CK+Hm2hfSYF9a?=
 =?iso-8859-1?Q?oHhx6kqF4MIYRezDmY4r9WjPk6v6MYRz5u1ccCZmABCw8IQTv4w0vvBpbG?=
 =?iso-8859-1?Q?abqy6CEIrf+gLHtV6piKcPxM+EwZrKXjCffLZfhN9H1qN/XHpHg0/Twfqb?=
 =?iso-8859-1?Q?8OVx4FOFYXaiogI7Hsmcj1a3wIok0yspcX2TcQwRIze9n142O5ZLSwM8Hx?=
 =?iso-8859-1?Q?mlZBG+c5UiBh80l70tnqh4d/08dlKXc7jXg0O3UMVdbqWenCcUbqdLY+B6?=
 =?iso-8859-1?Q?xIZIAQPSxjbP8C2t4MYYoDjtRd/00NBhDAG4xb4Gd5CPMEoqlrNjiO3Bja?=
 =?iso-8859-1?Q?yFHlkDEew0WRnZ32sX4zT1BbV1BC2upSj9ah31M4NCDvU+RM5RyikSlVuE?=
 =?iso-8859-1?Q?kCPzqOupqrKSsttXpAX/SBd6mYeqqt3V2X?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5005.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a85fdcb9-e17d-44ef-9d7b-08dc23132745
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2024 10:47:14.9461
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WtgYZhvXjjAb09pMI9N+8NBGadaMEpdN1UHKBZ19nqPQZuyg+ksjHFY1KgxNn5TZJwsWHuke6S9aT8SDoXweSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7718


> -----Original Message-----
> From: Marc Kleine-Budde <mkl@pengutronix.de>
> Sent: Thursday, February 1, 2024 6:06 PM
> To: Carlos Song <carlos.song@nxp.com>
> Cc: broonie@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> kernel@pengutronix.de; dl-linux-imx <linux-imx@nxp.com>; benjamin@bigler.=
one;
> stefanmoring@gmail.com; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-spi@vger.kernel.org
> Subject: [EXT] Re: [PATCH v3] spi: imx: fix the burst length at DMA mode =
and CPU
> mode
>
> Caution: This is an external email. Please take care when clicking links =
or opening
> attachments. When in doubt, report the message using the 'Report this ema=
il'
> button
>
>
> On 01.02.2024 18:01:15, carlos.song@nxp.com wrote:
> > From: Carlos Song <carlos.song@nxp.com>
> >
> > For DMA mode, the bus width of the DMA is equal to the size of data
> > word, so burst length should be configured as bits per word.
> >
> > For CPU mode, because of the spi transfer len is in byte, so burst
> > length should be configured as bits per byte * spi_imx->count.
> >
> > Signed-off-by: Carlos Song <carlos.song@nxp.com>
> > Reviewed-by: Clark Wang <xiaoning.wang@nxp.com>
> > Fixes: e9b220aeacf1 ("spi: spi-imx: correctly configure burst length
> > when using dma")
> > Fixes: 5f66db08cbd3 ("spi: imx: Take in account bits per word instead
> > of assuming 8-bits")
> > ---
> > Changes for V3:
> > - include <linux/bits.h>
> > ---
> >  drivers/spi/spi-imx.c | 9 ++++-----
> >  1 file changed, 4 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index
> > 546cdce525fc..2a1ae7b00760 100644
> > --- a/drivers/spi/spi-imx.c
> > +++ b/drivers/spi/spi-imx.c
> > @@ -21,7 +21,7 @@
> >  #include <linux/types.h>
> >  #include <linux/of.h>
> >  #include <linux/property.h>
> > -
> > +#include <linux/bits.h>
>
> nitpick:
> Please keep the includes sorted alphabetically.
>
> >  #include <linux/dma/imx-dma.h>
>
Hi,

Hhh, thank you!
I will try my best to strictly adhere to the code format in the future!
This is a good habit and I couldn't agree more! V4 will be sent.

BR
Carlos


> Marc
>
> --
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   |
> https://www.pen/
> gutronix.de%2F&data=3D05%7C02%7Ccarlos.song%40nxp.com%7C53112bdae1e4
> 478f5fff08dc230d69fb%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%
> 7C638423787724098671%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&s
> data=3D33MzYSg%2Fq5ciMNGJmbrUcprP%2BH%2F%2FNl0IPNcUO%2BHoeF4%3D
> &reserved=3D0 |
> Vertretung N=FCrnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |