Received-SPF: pass (google.com: domain of linux-kernel+bounces-48053-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f4c6a0a1-e02b-4668-b3b3-0ba04fa079a6@gmail.com>
Date: Thu, 1 Feb 2024 19:58:07 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] samples: mei: remove unused parameter
Content-Language: en-US
To: alexs@kernel.org, Tomas Winkler <tomas.winkler@intel.com>,
 linux-kernel@vger.kernel.org
References: <20240119040012.2925013-1-alexs@kernel.org>
From: kuiliang Shi <seakeel@gmail.com>
In-Reply-To: <20240119040012.2925013-1-alexs@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

ping

On 1/19/24 12:00 PM, alexs@kernel.org wrote:
> From: Alex Shi <alexs@kernel.org>
> 
> The timeout parameter isn't used in func mei_send_msg(), better to
> remove it.
> 
> Signed-off-by: Alex Shi <alexs@kernel.org>
> To: linux-kernel@vger.kernel.org
> To: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  samples/mei/mei-amt-version.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/samples/mei/mei-amt-version.c b/samples/mei/mei-amt-version.c
> index 867debd3b912..bf14d8a819b9 100644
> --- a/samples/mei/mei-amt-version.c
> +++ b/samples/mei/mei-amt-version.c
> @@ -195,8 +195,7 @@ static ssize_t mei_recv_msg(struct mei *me, unsigned char *buffer,
>  	return rc;
>  }
>  
> -static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer,
> -			ssize_t len, unsigned long timeout)
> +static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer, ssize_t len)
>  {
>  	ssize_t written;
>  	ssize_t rc;
> @@ -391,8 +390,7 @@ static uint32_t amt_host_if_call(struct amt_host_if *acmd,
>  	memset(*read_buf, 0, in_buf_sz);
>  	msg_hdr = (struct amt_host_if_resp_header *)*read_buf;
>  
> -	written = mei_send_msg(&acmd->mei_cl,
> -				command, command_sz, acmd->send_timeout);
> +	written = mei_send_msg(&acmd->mei_cl, command, command_sz);
>  	if (written != command_sz)
>  		return AMT_STATUS_INTERNAL_ERROR;
>