Received-SPF: pass (google.com: domain of linux-kernel+bounces-48078-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <b4d8649c-5cda-42da-8b6c-058bd42b3484@astralinux.ru>
Date: Thu, 1 Feb 2024 15:01:20 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: RuPost Desktop
Subject: Re: [PATCH] qnx4: add upcasting to avoid overflow
Content-Language: ru
To: Anders Larsen <al@alarsen.net>
Cc: linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org
References: <20231123100627.20739-1-abelova@astralinux.ru>
From: =?UTF-8?B?0JDQvdCw0YHRgtCw0YHQuNGPINCb0Y7QsdC40LzQvtCy0LA=?=
 <abelova@astralinux.ru>
In-Reply-To: <20231123100627.20739-1-abelova@astralinux.ru>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Just a friendly reminder.

23/11/23 13:06, Anastasia Belova пишет:
> To avoid possible integer overflow in qnx4_statfs
> cast literal to unsigned long. Otherwise multiplication
> of two u32 may give a value that is outside of the range.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
> ---
>   fs/qnx4/inode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/qnx4/inode.c b/fs/qnx4/inode.c
> index 6eb9bb369b57..4be8dba60567 100644
> --- a/fs/qnx4/inode.c
> +++ b/fs/qnx4/inode.c
> @@ -133,7 +133,7 @@ static int qnx4_statfs(struct dentry *dentry, struct kstatfs *buf)
>   
>   	buf->f_type    = sb->s_magic;
>   	buf->f_bsize   = sb->s_blocksize;
> -	buf->f_blocks  = le32_to_cpu(qnx4_sb(sb)->BitMap->di_size) * 8;
> +	buf->f_blocks  = le32_to_cpu(qnx4_sb(sb)->BitMap->di_size) * 8ul;
>   	buf->f_bfree   = qnx4_count_free_blocks(sb);
>   	buf->f_bavail  = buf->f_bfree;
>   	buf->f_namelen = QNX4_NAME_MAX;