Received-SPF: pass (google.com: domain of linux-kernel+bounces-48139-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b1994cfa-8ddc-407a-9f72-84ce3d4ba787@collabora.com>
Date: Thu, 1 Feb 2024 17:32:44 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>, kernel@collabora.com,
 linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/mm: on-fault-limit: run test without root
 privileges otherwise skip
Content-Language: en-US
To: Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org>
References: <20240201071307.592317-1-usama.anjum@collabora.com>
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <20240201071307.592317-1-usama.anjum@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Please disregard this patch. I'll send another patch to fix another thing.

On 2/1/24 12:13 PM, Muhammad Usama Anjum wrote:
> The mmap() respects rlimit only for normal users. This test should be
> run as normal user, without root privileges.
> 
> Fixes: b6221771d468 ("selftests/mm: run_vmtests: remove sudo and conform to tap")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
>  tools/testing/selftests/mm/on-fault-limit.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/mm/on-fault-limit.c b/tools/testing/selftests/mm/on-fault-limit.c
> index 0ea98ffab3589..431c1277d83a1 100644
> --- a/tools/testing/selftests/mm/on-fault-limit.c
> +++ b/tools/testing/selftests/mm/on-fault-limit.c
> @@ -21,7 +21,7 @@ static void test_limit(void)
>  	map = mmap(NULL, 2 * lims.rlim_max, PROT_READ | PROT_WRITE,
>  		   MAP_PRIVATE | MAP_ANONYMOUS | MAP_POPULATE, -1, 0);
>  
> -	ksft_test_result(map == MAP_FAILED, "Failed mmap\n");
> +	ksft_test_result(map == MAP_FAILED, "The map failed respecting mlock limits\n");
>  
>  	if (map != MAP_FAILED)
>  		munmap(map, 2 * lims.rlim_max);
> @@ -33,8 +33,8 @@ int main(int argc, char **argv)
>  	ksft_print_header();
>  	ksft_set_plan(1);
>  
> -	if (getuid())
> -		ksft_test_result_skip("Require root privileges to run\n");
> +	if (!getuid())
> +		ksft_test_result_skip("The test must be run from a normal user\n");
>  	else
>  		test_limit();
>  

-- 
BR,
Muhammad Usama Anjum