Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp136908rdb; Thu, 1 Feb 2024 04:37:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IFdNOUqVWw+13cTF/Gt6jFIdLWOUE1+21HFcPSJRxvjR3TftDKp3LOMdPdZTKblr72Bd7H6 X-Received: by 2002:a9d:7341:0:b0:6e0:fdc1:e66d with SMTP id l1-20020a9d7341000000b006e0fdc1e66dmr4423638otk.32.1706791029138; Thu, 01 Feb 2024 04:37:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706791029; cv=pass; d=google.com; s=arc-20160816; b=f2XtV9lkuNAwl00VCr+hRx7O6oSuJzTNJ8czDF5iv7yl/kspq3xU4KtpElpLQ3licC RcPM90aJDcsal6F9M79jKsXBQT/cjKv/w6lxxmfBMoR9oIjPhNe2I7iN+YWiB6kx4kHQ Fv/dsyErAhO3LC7YGGnA4HK9OmxKzoiFCRT2+FutKBXBwehDZmUY72Et2ffBSKUz3Gpe OGOlghn9R0iso/wA/0uIIuv8KKZeRYwrWZ7pdwEZGaT03ttrjShwv+84uX/9DB0nD+ZF aFaDKkVYOYkGHcIPtQ7RcpalxU0vmo2WgxIGPlv7g7L2fLMnHMeWtzInkoegdc/UxBUB /PqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=E4A5iVgzE715w//0CLgtkuodzITNIqD3Gz7PVnBh6zw=; fh=S2uiCux905rBJqbEVnQnJftWuxuracXZ+Sbcje+f+K4=; b=nHc9QOgWDIobeqyN8K+hivSwApo2kZCiHuiUE89ZNr4P/bDybrdQW8ArFEorTZq0bX ZtFXuhVhmSLL1JWc9CroYYOplZ3pcNVfojgiu96tTTUeg1b8VjaAjGyDGig2ws6Ie451 imF0ClT2cR4jeftvcJHXD3AlnZBYUnMujssHAvyWcNOfufm4oYfVBL0GC4/R1WqPD+1A OONukLRdfgQi4KiNsZz0tVObfwOYBZ8zhVDS5iFb1JEmJ6vQhXca5bqdZq/09iDJ9P03 I7E5SZGjjAJU34WnVm/w0S4irBmp2f4tpaUljXcZfn4dqBiZHOI86aIIigmK3T136p3i G54Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="KU06cK6/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48137-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCWPOGN5Vi0HFEEq4BG5FtMH5blorXyZdg3/5hELNviBbTWXB9tx/B5X6ZAfyvQbOkVFuoCdaAjtmhiYyuvKuBd+hsXCOhEdTzuKOnyvbw== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id m68-20020a632647000000b005d6d6f8cbddsi12018856pgm.360.2024.02.01.04.37.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 04:37:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="KU06cK6/"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-48137-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48137-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7E43F29129A for ; Thu, 1 Feb 2024 12:33:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A016B5CDDF; Thu, 1 Feb 2024 12:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KU06cK6/" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBBFE2135B; Thu, 1 Feb 2024 12:31:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706790674; cv=none; b=ohOLkJSSvvzHwAbqp8OOYwRlHdUQtkpdDZ3qOBoFeG49MyZ5AH+IbjlfrjsHjNrQGv2OC4SPHMnqWl8uiNfDGBONC/QGLAsU1VsnROZ2/vWkwcawkXxO2q5CKQwYqIRpRFxdkGNqCR+mnHD0L66m02yPp+gRau5d5W7bebIwDOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706790674; c=relaxed/simple; bh=E4A5iVgzE715w//0CLgtkuodzITNIqD3Gz7PVnBh6zw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CRREpvPs8mLKWR7GyZSRFyDhzVhPOHod20FhD687A3+bGRfrE+89xVY/430x7SEqG07snSO/EnuLv8yQnqs6HF83wyuotM1tq6okXBobgE9P0PEJi0D+U4vgqhFR3bpliyyQS491WQIdQEx4dYA06clBwuItyZnxe+TsU/B/Ijo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KU06cK6/; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78931C433F1; Thu, 1 Feb 2024 12:31:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706790674; bh=E4A5iVgzE715w//0CLgtkuodzITNIqD3Gz7PVnBh6zw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KU06cK6/KJppk6C5DXCgRbg1tp1NHfzoP7v8JNCDbSrsBCiCe4mQIY68WxUzAfgQD 3ek8+x4ofpQiuNkFaRqCHIvI8WfbENNBUbp2KRqgSL2JUfNmUvRMD1KoyeLhRI8O8c 5Ywg58ONGGezToU/D1im0u4OiT6MkodmcyP9QdW2Usb8/+0tVWd9pX0PLiuDgEzp3V AFGRz6nSkzQTW7ROALNurhfindo+YAQmOMPuFL7s32w0LI8wWVvIUteYSoTiJZ/8RY phkN9ziIj1ROCTTj/7OBVU21SkfOQEV+1LqE2LPLgxqdHHJvghEcf46Blg1H0ueDXw PGc1RT3Hvh8iw== Date: Thu, 1 Feb 2024 12:31:09 +0000 From: Mark Brown To: Amadeusz =?utf-8?B?U8WCYXdpxYRza2k=?= Cc: srinivas.kandagatla@linaro.org, bgoswami@quicinc.com, tiwai@suse.com, Fullway Wang , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, fullwaywang@tencent.com Subject: Re: [PATCH] sound: soc: wcd934x: fix an incorrect use of kstrndup() Message-ID: References: <170662942110.37296.1277489815994094565.b4-ty@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QR8WRBmfgmn/QwRS" Content-Disposition: inline In-Reply-To: X-Cookie: You can't cheat the phone company. --QR8WRBmfgmn/QwRS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 01, 2024 at 10:04:23AM +0100, Amadeusz S=C5=82awi=C5=84ski wrot= e: > Mark, my other comment was meant to stop this patch from being applied ;), > perhaps I could have been more clear? kmemdup_nul() in this case will copy Your comment appeared to be a complaint about the existing code being bad which sure but not a blocker to a minor fix. --QR8WRBmfgmn/QwRS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmW7jwwACgkQJNaLcl1U h9DlAAf/Zkwb92UAMo+KF0xiS0ypCUfcY7H54ga9UK2UMV6RT3C/R/Kt+2N1bC/j rq43Inynq2gpcVx+iL77Rjpfx7jKMjeMruG8nXQ5vwn44X8hGqT3Xes4IMpNrG/K PNjKmgjAyM1cQ/y0NxXpA7CoQuSMnMZ6VDupwkMp6RNs5h9Kngf40spTLc9n15Yf Z0eKgvR/cTfGlhtLgtj9C06LmmFV7mvk9px1ffUg0SLMaLBIJmTYyO0mFoy1TPtw SsmdiyTJ4VzchWwOgBBBQiHsOGHC1ePRaGqj2F1g3gu4OeHSzncWr4YhTyXeHiS3 jRQGOxrEIe6bh0DTo9bgRDqEhRGRjA== =HfjQ -----END PGP SIGNATURE----- --QR8WRBmfgmn/QwRS--