Received-SPF: pass (google.com: domain of linux-kernel+bounces-48181-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <fa2636b8-de7c-494a-bb9c-d1a8cc97f6c8@oracle.com>
Date: Thu, 1 Feb 2024 12:57:16 +0000
User-Agent: Mozilla Thunderbird
From: John Garry <john.g.garry@oracle.com>
Subject: Re: [PATCH RFC 3/4] net: ethtool: Use uts_release
To: Jakub Kicinski <kuba@kernel.org>
Cc: mcgrof@kernel.org, russ.weight@linux.dev, gregkh@linuxfoundation.org,
        rafael@kernel.org, rostedt@goodmis.org, mhiramat@kernel.org,
        mathieu.desnoyers@efficios.com, davem@davemloft.net,
        edumazet@google.com, pabeni@redhat.com, keescook@chromium.org,
        masahiroy@kernel.org, nathan@kernel.org, nicolas@fjasle.eu,
        linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
        netdev@vger.kernel.org, linux-kbuild@vger.kernel.org
References: <20240131104851.2311358-1-john.g.garry@oracle.com>
 <20240131104851.2311358-4-john.g.garry@oracle.com>
 <20240131112432.5133bcaa@kernel.org>
Content-Language: en-US
Organization: Oracle Corporation
In-Reply-To: <20240131112432.5133bcaa@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?RzY4R0dnWTdlTjhtalJWa0w2amVxZVdnN0FsOUR5TTJWN3Y4em12djdVUmFP?=
 =?utf-8?B?UE1oK0hzOFRaaS85aHYzalhyK0JDNjlEUUdkbDhySVVtTndQUHB2SjV4TXdn?=
 =?utf-8?B?ZllaS09uYXAwWkh2eHV1UElwNkxvT0R5TVhleTJSTkQ3S3JGcHZZTE9oS20r?=
 =?utf-8?B?OG9RQWhaUURDSFlsOGlsSm1iWkdkUGI5ZU83ZGludlJvc1Z6eTdwL3ZLNjE4?=
 =?utf-8?B?U2g4N2E4YkVYbytWeVBHUVBGdjg3VXBjRFBIdEZFTU1KUHZvRWVDUzJWMjZN?=
 =?utf-8?B?cUx6V3BMZ0Z1NmNVTnM3M05KZ3kvendyL2QzcmNBZ0FTYWZJRjErU2JWdWhO?=
 =?utf-8?B?dnhWVEJab2tia3N5bjE4ZWxzVkp0bzZPWWFNdkRBamF0L3JYcHNWaGNNNm9R?=
 =?utf-8?B?dkliVEtzQ3NTa0V6MzltcTVGYVY5elN2Y1hSV3BCcVAyYjdpZ3hRelVZMDZR?=
 =?utf-8?B?VURCTEZucml1UVppYTM5THhCc1NlUlNMN2pROStRQ2RyTldtMFU0K3RZaUda?=
 =?utf-8?B?WkRpMVY2bGFpR3Zwb25SZnRsY1VBcldSMTFqa0kybktpeXVlYXhlODd1V1FG?=
 =?utf-8?B?dzVkMFZ1TlhXdnBCekFGMmgrdldBT2RHZlNpcGRiQ1RWcVZPa0NiQzZSV2E3?=
 =?utf-8?B?SG5mbmZmc3NZSzZKYUpTYW5oa1dOeDcxK3hVeUtvUkRpWUltNmtWL3NMTXRB?=
 =?utf-8?B?bXVkOG5uUVJMRHJPVDF3TnVZVG9HK2F2Nk1wM0pWWVFhN1dhamhXRVNtRnh3?=
 =?utf-8?B?c2VRSEtWL1ViN1FYZkFjdnFXZFpHa2ZmM1NKV1dwSVhsMTgwSkJmMTFoaUFV?=
 =?utf-8?B?SWFmUjNHUEFuSjhGWm90a3hLcHo2dUtsM2VrRHZuY1dtYVBuTjBYeDNleHRa?=
 =?utf-8?B?Mk0zcEJpNG53NDM4N3FhWUpNc0s0bW1IWndKeC9UbG9jS1NLTVMrNUtwWE5o?=
 =?utf-8?B?R3NsMGgrQjFnL1p1VURtaXFtbjRsTUxEQndNb1NVZE9Sc1N1Z0FGQS9iQWUx?=
 =?utf-8?B?MS9ra2dsT2FGS1JrcFJpTjl2S1Zmc29SS215RWtkVVh6Q3hIQVE0dC9YUG1q?=
 =?utf-8?B?c3lGSC9mWXpZNVkvNTU0WkRnTm9MWWI2UnBlb25OQkNya0FESDBPcWthUDRR?=
 =?utf-8?B?ZlYvaVBmUTd5SHlxUDBaeUQya0dnN0VKTkVNVHhxN1BxcTVYaTRabW1ZL0Uy?=
 =?utf-8?B?TzhYUWpPYlZFVk9sb0NDdjhMS0l3YWJ5TWt2K0xjTmwxdnhoTDVUUFNtV1dU?=
 =?utf-8?B?SGhJallTRm84Qkw0YTEzQS9VNGNzWUQ3OXhtbVB2YUZ0bnFvSFRKcUIwK1ZX?=
 =?utf-8?B?eVY5L2dRZUZ4ZnVXQXo5b0ZMVEJ6bGVSQTlEeFluZlRVZnRvSWZhb3M1ZHVS?=
 =?utf-8?B?aUdxWkNWS2VmZUZpNXdLRXJXb1Z4S3BiMGVrMXZGVmpab25MYVM0NXFkSVJo?=
 =?utf-8?B?SlU1U1Mxc1VvUGc1dTJ5MlhGY1d1TWJCQi9TQ2hBUEdOdjRCS2FLaVVRSGlO?=
 =?utf-8?B?c29COE10b3BnOTJHU1YrdW5RQW1FYnlRdG9wWnN0aWVaQ05BMVIxUDdPallx?=
 =?utf-8?B?ZlpoYVFiL2d2TSt6dU1JNStWK2ZKbHI1Q3ZzcnZXaWZmR0ltUCtML1FrOElE?=
 =?utf-8?B?bmc5aXEwNHI5UkVyaDlDOGhKOFFFUno3Z1ZxNUxWQVUxYjhFQjMrSTZsdU1Q?=
 =?utf-8?B?OE0wU3hmZC9NOXhDelFDRUFpNkZnQjRpODBmU0VLb0w5NExDSzJITG0xaTg3?=
 =?utf-8?B?VVMzL2ZTZFJUNUE2Rmh1cE1kSnM1RldBd3E5QWtyNHc1cTlKOWJacWM2QWRx?=
 =?utf-8?B?b0IyNC9ON1NDemd2Wmh4dFhsK212K3drakh0TEhHZlA2QWZ5ditrL0wwajlK?=
 =?utf-8?B?aVdRUGdoVy93ZmJMcmpkZHVMUTV3dFdqMEc1OEdyRkNzTlBieHpVaDAyRzkr?=
 =?utf-8?B?VFFoRVo2MVhOVUdmVEFRWXdySVBjVGl2cUpMQ05pc2RBV3dGSy91UUFTNGxB?=
 =?utf-8?B?VUsxRjlSTEJSelJhMUxVeGlZMUxaSmlQVnd2dlQ2Wk5CWGdkTGpFMXNaRGUv?=
 =?utf-8?B?V1lkZFVCYW5pVGt5V1JCOGwxNW9TcjA3Uno1Ym9yT3BJTVBLL3l4bEhVN28x?=
 =?utf-8?Q?sUuzEn+79Xurh/LOq4GKjRJIN?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	XhVBMEI3nuNAlQHWtUbFHPCr8ANXyr2t/ZFP5vHvntlusNF6oK2srPymPJM0BPOLWNqQjF4aJNIXWxeYzk0WDqPoUCf+zGV6aoO+H4hLCXNWx4poFKQ8/G7dQLdkAcMjprGEtNef/vjPM9GFVqyAR9N0rGU7YMatk4tO6bb9tXRbHN9JQSbGK9nWuV/tPKs1xpmlRSiFx6s17B7X0L4jWQAkYTikNdKbEKL8EdmS3rsLuwmlZHD53xT+aeW0qHYr06dmpE5rkTXHjMdqV0E17GQGszFOuRnu1qHpcNiF1mXpYuWO+C1SJA2ky6yRo7RmPajB5ACOrSTnznIvl1LQd7ARXIGNcOEOsaYNpxuSBbFFNfp+i/DyuXxmqk1K6YxYDditl4kjo33OADg5XvLFXI4h2G+FYeQ5UUEtgeDqpn3Z9Vh4nzSGVsCy8vJG+jpOvVZURZP5Pr4HPWgk0lTuEIj8O3dUThRC3PCpzk/ykJTHvtNSE8G9gNFKGZEsgr1L5oTKgBTgRIwxOOvmF/UbJpGArLKeldi8OI8T45kwm+slry5P0Xpp7iWgsqkerxLXKge5WPn57K35CAH/MkAhhsRhenjCT8/zM0uOdpX7eCo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4e35f3f-222d-493a-c149-08dc232553ff
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 12:57:21.1896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 61s3hOn1Dd5DUhlmrDTm0bie2Fh0o/Ey+xwlOIxOp4lFrat5jsw4owmbVCoa6igF4nOAWs9DFzB+1G26j6vZPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6407
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-01_02,2024-01-31_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402010102
X-Proofpoint-ORIG-GUID: 07GHyVhXbwjjeDkVqGgjhdwdBZBmCt4V
X-Proofpoint-GUID: 07GHyVhXbwjjeDkVqGgjhdwdBZBmCt4V

On 31/01/2024 19:24, Jakub Kicinski wrote:
> On Wed, 31 Jan 2024 10:48:50 +0000 John Garry wrote:
>> Instead of using UTS_RELEASE, use uts_release, which means that we don't
>> need to rebuild the code just for the git head commit changing.
>>
>> Signed-off-by: John Garry<john.g.garry@oracle.com>
> Yes, please!
> 
> Acked-by: Jakub Kicinski<kuba@kernel.org>

Cheers

BTW, I assume that changes like this are also ok:

--------8<---------

    net: team: Don't bother filling in ethtool driver version

    The version is same as the default, as don't bother.

    Signed-off-by: John Garry <john.g.garry@oracle.com>

diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
index f575f225d417..0a44bbdcfb7b 100644
--- a/drivers/net/team/team.c
+++ b/drivers/net/team/team.c
@@ -25,7 +25,6 @@
#include <net/genetlink.h>
#include <net/netlink.h>
#include <net/sch_generic.h>
-#include <generated/utsrelease.h>
#include <linux/if_team.h>

#define DRV_NAME "team"
@@ -2074,7 +2073,6 @@ static void team_ethtool_get_drvinfo(struct
net_device *dev,
                                     struct ethtool_drvinfo *drvinfo)
{
        strscpy(drvinfo->driver, DRV_NAME, sizeof(drvinfo->driver));
-       strscpy(drvinfo->version, UTS_RELEASE, sizeof(drvinfo->version));
}

-------->8---------

right?

John