Received-SPF: pass (google.com: domain of linux-kernel+bounces-48215-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 1 Feb 2024 14:16:58 +0100
From: Frederic Weisbecker <frederic@kernel.org>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@kernel.org>, Peng Liu <liupeng17@lenovo.com>,
	Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH 03/15] tick: Remove useless oneshot ifdeffery
Message-ID: <ZbuZyu2XmRO-UVCY@localhost.localdomain>
References: <20240131231120.12006-1-frederic@kernel.org>
 <20240131231120.12006-4-frederic@kernel.org>
 <87ttmsikud.fsf@somnus>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87ttmsikud.fsf@somnus>

Le Thu, Feb 01, 2024 at 10:40:10AM +0100, Anna-Maria Behnsen a ?crit :
> Frederic Weisbecker <frederic@kernel.org> writes:
> 
> > tick-sched.c is only built when CONFIG_TICK_ONESHOT=y, which is selected
> > only if CONFIG_NO_HZ_COMMON=y or CONFIG_HIGH_RES_TIMERS=y. Therefore
> > the related ifdeferry in this file is needless and can be removed.
> >
> > Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
> 
> It's a nitpick, but shouldn't the ordering of sob and reviewed-by be the
> other way round?

I've seen it both ways here and there, I'm not sure if there is a strict rule
for it...

> Thanks,
> 
> 	Anna-Maria
>