Received-SPF: pass (google.com: domain of linux-kernel+bounces-48183-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 01 Feb 2024 14:02:16 +0100
Message-ID: <87frycz6av.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Alexander Tsoy <alexander@tsoy.me>
Cc: vincenttew <vincenttew@google.com>,
	perex@perex.cz,
	tiwai@suse.com,
	linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb-audio: retry clock validate when it takes some times
In-Reply-To: <6872e9ea993633dff4e248f01cafd1ac32651355.camel@tsoy.me>
References: <20240201070641.401684-1-vincenttew@google.com>
	<6872e9ea993633dff4e248f01cafd1ac32651355.camel@tsoy.me>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: 8bit

On Thu, 01 Feb 2024 11:36:11 +0100,
Alexander Tsoy wrote:
> 
> ? ??, 01/02/2024 ? 15:06 +0800, vincenttew ?????:
> > Behringer UMC202HD and UMC404HD take some times to validate the clock
> > source. To prevent more DAC have the same delay which return the
> > false
> > in the first time, remove the USB id check to have a chance to retry
> > the
> > clock validate.
> > 
> > Signed-off-by: vincenttew <vincenttew@google.com>
> 
> Thank you for the patch! My thought about this change:
> - Retrying clock source validation probably make sense only in the case
> of Internal clock. But I'm not sure.

It's an interesting point.

> - If we want to make this a standard driver behaviour, then the code
> needs to be moved out of the quirk function IMO.

I'm a bit afraid of applying this unconditionally to all cases.  At
first, we can start with the vendor matching (e.g. MOTU and Behringer)
to apply it...


thanks,

Takashi