Received-SPF: pass (google.com: domain of linux-kernel+bounces-48184-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 01 Feb 2024 14:05:04 +0100
Message-ID: <87eddwz667.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Ivan Orlov <ivan.orlov0322@gmail.com>
Cc: perex@perex.cz,
	tiwai@suse.com,
	linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: core: Fix dependencies for SND_CORE_TEST
In-Reply-To: <20240201094604.1347793-1-ivan.orlov0322@gmail.com>
References: <20240201094604.1347793-1-ivan.orlov0322@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Thu, 01 Feb 2024 10:46:04 +0100,
Ivan Orlov wrote:
> 
> Add the CONFIG_SND_PCM dependency for CONFIG_SND_CORE_TEST config entry
> as the test uses symbols from 'pcm_misc.c'.
> 
> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>

It should rather select instead of depends-on.  User can't enable
CONFIG_SND_PCM explicitly, but it's selected by the top-level
drivers.

Also, please add Fixes tag.  It's a clear regression fix.


thanks,

Takashi