Received: by 2002:a05:7412:bbc7:b0:fc:a2b0:25d7 with SMTP id kh7csp168359rdb; Thu, 1 Feb 2024 05:29:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFkIVelrscI6lX5iVKkrG7m9Jh+KiCh9WPoqbgn1776jS3Pt+6gbhp+GIE0Ig5jQMh902Wy X-Received: by 2002:a17:90b:1052:b0:295:d2b5:699b with SMTP id gq18-20020a17090b105200b00295d2b5699bmr4795037pjb.9.1706794152609; Thu, 01 Feb 2024 05:29:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706794152; cv=pass; d=google.com; s=arc-20160816; b=xOci3nW6rgmwwWKTh+eGKpbSVKqQ+DmVHbLdNFmpxojK2jLiIdOzIcr4IAk5hHJ68t +W01MxOy+ZFIRlawHndSBD7tFgdd1sGqryRUmPTx+PdYS/pQBsVKgvu6Lnp3ZLYC/70d sCvcToldfztFRF25ATdq8Nzu0C4qjn9uECYuP6h+vhh5pAEDp6N647FRl4xHN6s+lZYd 9ELe8Eqe7o/zJPUDfvSibEjbBizJSqPMRc7pOnyMF7bqRZ0yQVXATDaBdCdAgWLarNIF Et03wrHffjrJebbLLW9NVZB5T/UX6BdKPFWrv+iyLZb3he7ozI3sWxvPNZUtM/K+B2TU /bOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zjpeycqnVI85EQN7sDqSOxS/I+t8ZWH69ZG5XBfe+hM=; fh=dZMDcDYTn+vtXjLB7AKRI1FTwAF4rXuEqEKHzyQkXLA=; b=vXNAxXll7atTKV0RbKye/R+psbPZWngnnZ6SeMjeXzUnjOw088yR4zyPrqkF5Asskw fVt1g4k+wjpOA6t/r9WBdZRYNImdJAa6z0X1wNxbCs+MdCipseKuQPk/ds2sT+6vNNJa L5aMOGmOW2aI2VQuLyAe4+GA7EVJhRp4sfZSTKIT88vG2UtohmtGco3m5vu5rg+zNqMc DYRB1E0abd+M7nu05P0RqmpX0axxnNtrLzuO08qFJXiSp6Z+0tIylcWI+LVlerUlvCEN bfRuxvCPfSzyA78qTU0W75ZVYwVWqmBzPVxJ8ZcL4l7k5kaLwPfBlGhKMG7BlvuOZ7vt IgfA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=GOBvCrf6; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-48231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48231-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch X-Forwarded-Encrypted: i=1; AJvYcCVwQ89mAwl/VIQIS6V0ghYrqUn1LXVA8KHRa+6kQbF6JNYdCZlg/lCRutLHNXZqZwtw6CA2wkq94oEH2nZ3OGw9OvAGnTeBP2gqn22moA== Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id h7-20020a17090ac38700b002909c51fb3csi3692390pjt.62.2024.02.01.05.29.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Feb 2024 05:29:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-48231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=GOBvCrf6; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-48231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-48231-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 17557285658 for ; Thu, 1 Feb 2024 13:27:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CC83453399; Thu, 1 Feb 2024 13:27:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="GOBvCrf6" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F8AC5336E; Thu, 1 Feb 2024 13:27:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706794064; cv=none; b=sWdvML+B6GoGEMBCd8Yv7xLoKeGptzvy9RRPmCJbcUQgSv/Cxv29CMjYW0Y/ZTlFzgXR+ne/GoMNaCFO+Tg8633WKMhFigmcnHTPJxV/gvzxMPbzHB2fPttLtzOs9DIEJLQzdWb0vHL3BMPfNP6Z0jDGzFBxPB8LigxhPYY00rM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706794064; c=relaxed/simple; bh=Eg9W3NSA9s6osL6RP2fEHXmCU98GnHHKlYaGBUQfKk4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DzMxLtY4XEITosXCcDNHiyndsVfd2v6JAlGHgzHHHG7D1bdsJvpa4aEIFq0IlV+FljzXqLIYPEiav16BZrsIEV6MuKPWmyJxZxyJmf5mDHarecE1SAVKMF1x9r0RCXwY79EL/8n2dXX+XhzxitEdsNUDXp6NNdCnMl7rn++H8SA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=GOBvCrf6; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=zjpeycqnVI85EQN7sDqSOxS/I+t8ZWH69ZG5XBfe+hM=; b=GOBvCrf6MlGPgkU0qKHXY8Xic1 UtjA5kdkn775QjBvCaGI5WkgYsh2FLU7yS5RyllVeSR/rTXtNFx/9pbtg+hFEWsfWhlWI/7l0zOOb 5L3LLrlXxK3+yuoysWEaRayqd+OxlQ65p3Sdtleq4W0Xpw7/2bOM/DSQKhXeUvnfiRW0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rVX6G-006g11-27; Thu, 01 Feb 2024 14:27:28 +0100 Date: Thu, 1 Feb 2024 14:27:28 +0100 From: Andrew Lunn To: Guenter Roeck Cc: Dimitri Fedrau , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jean Delvare , Stefan Eichenberger , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org Subject: Re: [PATCH v5 net-next 08/13] net: phy: marvell-88q2xxx: add support for temperature sensor Message-ID: References: <20240122212848.3645785-1-dima.fedrau@gmail.com> <20240122212848.3645785-9-dima.fedrau@gmail.com> <88a60be9-083b-4618-845c-6983bcad3540@roeck-us.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88a60be9-083b-4618-845c-6983bcad3540@roeck-us.net> > > +#ifdef CONFIG_HWMON > > HWMON is tristate, so this may be problematic if the driver is built > into the kernel and hwmon is built as module. There should be Kconfig in addition to this, e.g. config MAXLINEAR_GPHY tristate "Maxlinear Ethernet PHYs" select POLYNOMIAL if HWMON depends on HWMON || HWMON=n help Support for the Maxlinear GPY115, GPY211, GPY212, GPY215, GPY241, GPY245 PHYs. So its forced to being built in, or not built at all. Andrew