Received-SPF: pass (google.com: domain of linux-kernel+bounces-47811-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <b8761b25-9754-45be-9025-e03c474b955b@linux.intel.com>
Date: Thu, 1 Feb 2024 09:54:39 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/3] ALSA: pcm: Add missing formats to formats list
Content-Language: en-US
To: Ivan Orlov <ivan.orlov0322@gmail.com>, perex@perex.cz, tiwai@suse.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240125223522.1122765-1-ivan.orlov0322@gmail.com>
 <3b5bf4b7-a4ec-44be-975b-04590777a965@linux.intel.com>
 <c4498c59-cf64-4a8b-82b9-01d0571779c7@gmail.com>
From: =?UTF-8?Q?Amadeusz_S=C5=82awi=C5=84ski?=
 <amadeuszx.slawinski@linux.intel.com>
In-Reply-To: <c4498c59-cf64-4a8b-82b9-01d0571779c7@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 1/31/2024 6:41 PM, Ivan Orlov wrote:
> On 1/26/24 09:01, Amadeusz Sławiński wrote:
>> On 1/25/2024 11:35 PM, Ivan Orlov wrote:
>>> Add 4 missing formats to 'snd_pcm_format_names' array in order to be
>>> able to get their names with 'snd_pcm_format_name' function.
>>>
>>> Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
>>> ---
>>>   sound/core/pcm.c | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/sound/core/pcm.c b/sound/core/pcm.c
>>> index a09f0154e6a7..d0788126cbab 100644
>>> --- a/sound/core/pcm.c
>>> +++ b/sound/core/pcm.c
>>> @@ -211,6 +211,10 @@ static const char * const snd_pcm_format_names[] 
>>> = {
>>>       FORMAT(DSD_U32_LE),
>>>       FORMAT(DSD_U16_BE),
>>>       FORMAT(DSD_U32_BE),
>>> +    FORMAT(S20_LE),
>>> +    FORMAT(S20_BE),
>>> +    FORMAT(U20_LE),
>>> +    FORMAT(U20_BE),
>>>   };
>>>   /**
>>
>> Maybe we can also add some kind of static_assert to check at compile 
>> time that all formats are handled, something like:
>> static_assert(ARRAY_SIZE(snd_pcm_format_names) == 
>> SNDRV_PCM_FORMAT_LAST + 1);
>>
>> Although looking at definitions there is a hole between 
>> SNDRV_PCM_FORMAT_U20_BE & SNDRV_PCM_FORMAT_SPECIAL, which will cause 
>> this idea to fail.
>>
>> Perhaps with comment:
>> static_assert(ARRAY_SIZE(snd_pcm_format_names) == 
>> SNDRV_PCM_FORMAT_LAST + 1 - 2); /* -2 for formats reserved for future 
>> use */
>> ?
> 
> Hi Amadeusz,
> 
> Thank you for the review and sorry for the late answer. Yes, I believe 
> it could be a nice improvement! Could I send a patch and specify you in 
> Suggested-by tag?
> 

Hi,

yes, go for it!

Amadeusz