Received-SPF: pass (google.com: domain of linux-kernel+bounces-48283-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Anna-Maria Behnsen <anna-maria@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Thomas Gleixner
 <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>, Peng Liu
 <liupeng17@lenovo.com>, Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH 03/15] tick: Remove useless oneshot ifdeffery
In-Reply-To: <ZbuZyu2XmRO-UVCY@localhost.localdomain>
References: <20240131231120.12006-1-frederic@kernel.org>
 <20240131231120.12006-4-frederic@kernel.org> <87ttmsikud.fsf@somnus>
 <ZbuZyu2XmRO-UVCY@localhost.localdomain>
Date: Thu, 01 Feb 2024 15:04:59 +0100
Message-ID: <87il38i8l0.fsf@somnus>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Frederic Weisbecker <frederic@kernel.org> writes:

> Le Thu, Feb 01, 2024 at 10:40:10AM +0100, Anna-Maria Behnsen a =C3=A9crit=
 :
>> Frederic Weisbecker <frederic@kernel.org> writes:
>>=20
>> > tick-sched.c is only built when CONFIG_TICK_ONESHOT=3Dy, which is sele=
cted
>> > only if CONFIG_NO_HZ_COMMON=3Dy or CONFIG_HIGH_RES_TIMERS=3Dy. Therefo=
re
>> > the related ifdeferry in this file is needless and can be removed.
>> >
>> > Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
>> > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
>>=20
>> It's a nitpick, but shouldn't the ordering of sob and reviewed-by be the
>> other way round?
>
> I've seen it both ways here and there, I'm not sure if there is a strict =
rule
> for it...
>

As it is for the tip maintainers, they have some rules - I don't know
how strictly they are used :)

  Documentation/process/maintainer-tip.rst