Received-SPF: pass (google.com: domain of linux-kernel+bounces-48310-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <0c990c7d-4df9-45c1-8c03-980d9842b963@intel.com>
Date: Thu, 1 Feb 2024 22:22:18 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 3/4] x86/kexec(): Reset TDX private memory on platforms
 with TDX erratum
Content-Language: en-US
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>, Dave Hansen
	<dave.hansen@intel.com>
CC: <linux-kernel@vger.kernel.org>, <x86@kernel.org>, <tglx@linutronix.de>,
	<bp@alien8.de>, <mingo@redhat.com>, <hpa@zytor.com>, <luto@kernel.org>,
	<peterz@infradead.org>, <thomas.lendacky@amd.com>, <chao.gao@intel.com>,
	<bhe@redhat.com>, <nik.borisov@suse.com>, <pbonzini@redhat.com>
References: <cover.1706698706.git.kai.huang@intel.com>
 <b52ed259e0d487b3a968b98da91cb4f55a28ae82.1706698706.git.kai.huang@intel.com>
 <12a927df-e437-40ff-ba4d-ceca5446c5b1@intel.com>
 <l3uo3n3li27czehll2wz34xxkcv5j2vcshgp5a6w7u4h4aidpu@4oe2cwye2e6z>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <l3uo3n3li27czehll2wz34xxkcv5j2vcshgp5a6w7u4h4aidpu@4oe2cwye2e6z>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWFBMm9sdGxYU0NRRkpXM2t2UHNFc3hyM3kwZjlxVkVlMmkwK1NacEhINEZJ?=
 =?utf-8?B?dnMwK1BYdFc4OUZkdmNQZ29HNWx3bkJIdmprdVV1Y0JsTkx5Ty9LTGpsZkho?=
 =?utf-8?B?cmQvQ2NPMElMSWVEc3lGR2JWeUpxREo1d2NSZzM3NGZ4dlE1NUVQWjQ2YXFm?=
 =?utf-8?B?OUxhVHpqNDZEdERINGx1UEUrUzRVOHJmY0lHRXhjc1YwOWl0eDJoOEF2TnJh?=
 =?utf-8?B?T3YycnJnaGRFTWthMHd1OWREQWN1ZHJwT1R0T2UzSEZ4dUJEQmp3T2owZWpi?=
 =?utf-8?B?TWdveExpQ1h6aS96VklnenVZZVNUdnc0d2NYSDU4RzhKRC9nM0Qya2FxN1FK?=
 =?utf-8?B?Ti9zd1BBYVVLL0tPdzJ1bUJEMFB0MHNidmtmQTdPdjRDNnRaSjBjbThXWWN0?=
 =?utf-8?B?dVJLd3U4R1ZuL1ZETTYzWGY0MXpYSW9lYklpbWlTUTROa3BCZjhtcGJ1bUZm?=
 =?utf-8?B?Yi9ISGZSeVN4dVRCNFBmTlJtd2k4NUpQT3pSckZvdExmQ0tvL29Ydkc5UW1u?=
 =?utf-8?B?Q1lMK1RmK2lnU2h4bXRBVGY2VGY4S1czZ1plU2ZYb2k5ZXlOM1k2MkN4Qnk5?=
 =?utf-8?B?UmpIOVBkWjk1b1V0YjlHL0dwSUlzOEIwb3dWaVVkM1pzSFZHd25tdytDUGVz?=
 =?utf-8?B?WGIrWWNBMGdaRHhIbHVUaHROeUdnaVBobkRjMzhkaVR3eERQd05nM2JRbnlS?=
 =?utf-8?B?ellRdHZxMkJJWG0zMi9ObnZWOFF5engzL0RLN1o1SE5MSlU4VGFYNXdKMCtG?=
 =?utf-8?B?QklyZ2FhUDlpWlcyc1RTcHhiT0cyMjRXTkdJQnZKZHQ2eHplUTBGb1N3bWxE?=
 =?utf-8?B?UzA1S2NwanZLNWRlM0lwQVZuZWVNaytUcGJHUnJZSWNHdTZRTlhMakVDdDA5?=
 =?utf-8?B?MlJsVjBmTUhROVBVc2xXa2pLYUZKV3psWDdBbVVvazdianRLczJkWVIzRWtp?=
 =?utf-8?B?MnJDTjJtSmpUaXk4bmU2ZXI2TTN6aTVKbi9GcTEzY0RRV2MzbGxkdWJhd1p4?=
 =?utf-8?B?TUNGZzZzcVdVa0JiMktIWnBEM3VyUUpzNG1QSWg2UlhvTEFLYnVFdWhhcDZP?=
 =?utf-8?B?c0RyQnNFVlRIUjM0Z3UzRkpvZXpVakxtRkhTQk5LQlkzQ3B1dVoyMG5wT1lp?=
 =?utf-8?B?d29vUkVaam0xc1BXdEVLQW5KNStiTDg5UThHL29lZmNxcFp3OHBrQWs0bzZS?=
 =?utf-8?B?dnZPQWQzWVNqbmNNbWdOa25DcUxHUFIxQzRxTk5vUEFUVGtuWEh2VE9aNlIz?=
 =?utf-8?B?QlNWeDlmS0lpZHFtUTdNTDVTczdBSlpkSlVUc1dQeGorMm52MjhSYnZrQWtE?=
 =?utf-8?B?T3ZIQnVxUCs4Nm84QWhQeExnQm1PUVViSG41b0dtOEYrWE5kZWpMZDlQZ0Z5?=
 =?utf-8?B?TEtMaUc1aVVnTHBFVFN6aWlnT2FadWZBVVNkNENmMmlSVXh4dUhuNXoxa2JU?=
 =?utf-8?B?SmZGSXlpZStpT2xWbnpQMU5zS0lMZExGNFdkckdRVHRVeWgxSCtsbUhXV3gw?=
 =?utf-8?B?dFBLVW01Sm52L216OUZab0txaENYaGU2eUpxeHdVVnRxNTk4UUpaNlBwdSta?=
 =?utf-8?B?eUlTcys5bWxramtqbm9LcE1YUzRWN2NRVG5QTjROUHFuQVM3UlFNcVRLYkV5?=
 =?utf-8?B?U0xIa21GRnRnT3VoUDEwSUxRNDZDRXZqMUhSK3hlTzBZWDJrWEo5Tko4TEor?=
 =?utf-8?B?MDdsVDBjUVdoSXVHSUlqZTRlTmJSditRdmRhSC9IL0VXdWFWNlZqZkxEQ09a?=
 =?utf-8?B?c09uVG1iLzIwZG1sbE84UkJLNTRRam5RQWRHdDJ2RmtOclh2ZFNMR3hLNWp3?=
 =?utf-8?B?SkJ6bWtJcG91N3A5cVF6WU1DUWJWSWVRSTZZUktNdmg1VGg3VlpGYVIwVVla?=
 =?utf-8?B?NWtYRy9UdGttd1A2NWRpNzVqNWgyQ3c5L0ZTZjF6eGxjbmxWbENzaXNuM0Ns?=
 =?utf-8?B?YUxLWGhlakU3ZVBrSi8wZFlST2pTWE5NUlFLem9CdzQ5TUtTK0t4R0N3bEN5?=
 =?utf-8?B?T2pVelEyU3JYL29LdFJVcmNTdFNhSlkreGczTG9pV01WNm9DMGt5MDZ1SGdS?=
 =?utf-8?B?KzJLVTR1TDNDcHVJdGFEQjg5YjEyU2RXbXZEV1EvODF0WlY1emJtbVFaYUlk?=
 =?utf-8?Q?EbOEST3uG/RHTNere+ND7sos5?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c46c8dd-dd1b-4bd7-11c4-08dc233139de
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 14:22:31.6521
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SXXgfGE+IQZbj/V5LgN9/ucd2wM+XgsSwSryqKJggrYoulMTCRYO4vSi3oTKiEova1byF5mq0Nh97IMlV2gT2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7874
X-OriginatorOrg: intel.com


On 1/02/2024 6:03 am, Kirill A. Shutemov wrote:
> On Wed, Jan 31, 2024 at 01:21:39PM -0800, Dave Hansen wrote:
>>>   #ifdef CONFIG_KEXEC_JUMP
>>>   	if (image->preserve_context)
>>>   		save_processor_state();
>>> +	else
>>> +		tdx_reset_memory();
>>> +#else
>>> +	tdx_reset_memory();
>>>   #endif
>>
>> Wow, that's awfully hard to read.  I really wish folks' gag reflex would
>> kick in when they see stuff like this to get them to spend an additional
>> 15 seconds to turn this into:
>>
>> 	if (IS_ENABLED(CONFIG_KEXEC_JUMP) && image->preserve_context)
>> 		save_processor_state();
>> 	else
>> 		tdx_reset_memory();
> 
> save_processor_state() is declared under CONFIG_PM_SLEEP, so I guess your
> variant might break build in some cases without updated suspend.h.

I tried.  If I turn off both SUSPEND and HIBERNATION in the Kconfig I 
got build error：

arch/x86/kernel/machine_kexec_64.c:325:17: error: implicit declaration 
of function ‘save_processor_state’ [-Werror=implicit-function-declaration]
   325 |                 save_processor_state();
       |                 ^~~~~~~~~~~~~~~~~~~~