Received-SPF: pass (google.com: domain of linux-kernel+bounces-48325-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <132e22b9-2e42-4d8d-a2ea-14023bd5dae1@amd.com>
Date: Thu, 1 Feb 2024 09:35:13 -0500
User-Agent: Mozilla Thunderbird
Cc: yazen.ghannam@amd.com, tony.luck@intel.com, linux-edac@vger.kernel.org,
 linux-kernel@vger.kernel.org, avadhut.naik@amd.com, john.allen@amd.com,
 muralidhara.mk@amd.com
Subject: Re: [PATCH] RAS/AMD/ATL: Add MI300 DRAM to Normalized address
 translation support
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
References: <20240131165732.88297-1-yazen.ghannam@amd.com>
 <20240201092148.GBZbtirOfNAR3SYmht@fat_crate.local>
From: Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20240201092148.GBZbtirOfNAR3SYmht@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YytqUndwZ3N6ejlYcUNKaHg5aWwxajZzTm0wL04wWmJOTFd4Vkl3YzAyYmpL?=
 =?utf-8?B?aUp2aUsrMGpnMU9WcjlZSTJITnZYd01JcTBzcy9idmN1T2lMbHVxcm5CTFVv?=
 =?utf-8?B?NjJ6TEdhMFUrdkFZaGc1UnBpOVFSWlhJUnFRMml6ZDZ0REJ6aXNOTXZFdkZa?=
 =?utf-8?B?akxYUzE3ZU9SRTAyZ3gwN0c5VG9jbmRtZXJTK0JjcEF1TU5uczZyMXBmWmdU?=
 =?utf-8?B?M1k4cTR5VWg1SGtmQWtGNERYaUVhQ21yazh6YTNvRC9VYzBNVE9qZ3pNcWla?=
 =?utf-8?B?Y1RvR2s0UUJDVHMrYjczdnhjTU0zSVpTSDlkVklGK21qTjBtSUFXcEVZYnZ3?=
 =?utf-8?B?eko4NTJuWk5kNzF3TUhkSkpxUnZtOE0yaFJOTmoxSkt4ZUZSMFdwZFYrOFNW?=
 =?utf-8?B?ZXI0MTJyek41ek1XQXZTSlBPblpuN3Fzb2szakkyOGV4VnBhU05JWnpZVXZO?=
 =?utf-8?B?bEtCMG5vNjRNSUtleHA3eUd1SWNSd1ZLWlBVclB2cUVxRVJ5YXNXL1BmRERV?=
 =?utf-8?B?T1Q3WVhTMHozQUxUSVk0SnZtYlB3QVk5emlRd2JBSW9YNjdmcmZpOWgwNmow?=
 =?utf-8?B?Z1g0MW1sMDlVUEJidmtJbm4wYkJvb3Z4VGdkM0NUVGg5Q2hPekl4MmpnRWMx?=
 =?utf-8?B?VFZ3SVlaMEYwSFJBSTM3QWdtOHBid3J3NC9weVdEbHZsMFd5Yy94WGswS0d3?=
 =?utf-8?B?cVI5Tkw0dC9Mdmk2ODZHMkJYNEs3clVCejVVNC9USmxmWkJtcFpPY0xISjJk?=
 =?utf-8?B?ZDg0RlJJaTV6TE9yQ3IvMXc4VmFHUGI2VmlPbWZHcENKZGhsWUJEcGRZWW1F?=
 =?utf-8?B?L3FUcWYxalhLdDFkMzQ5dGRMV1RuUUtlcmhIZ05CcjdBU3laYTI0VjhzY01v?=
 =?utf-8?B?SmNlNlc0SGJBcXBvenhERWY1cGtqVlBxRy95R0pWbEllNkErQTg1V0R2dzlj?=
 =?utf-8?B?OTlMRzdyem1LaHllZ3ZhSlFzK0QwWE1aYWZvdHd0eFFScHVKZ0d3eFZVS0R1?=
 =?utf-8?B?OHo0QUtxLzA3amlVMkNDU2l2d2RPTENRZWdITzduWkhHaUFDMDE4T09peVBK?=
 =?utf-8?B?bXg3VHY1S29MM3d4V0NjTEg2THJsZngvcm9WcEFybEt5MEpoR2tETW1EN1hz?=
 =?utf-8?B?UGppWGxwNEVzT2tWbGxYbEdLSjcwSnhJSU5HMGw1dEdmRWxUUU45c3Bqb0V2?=
 =?utf-8?B?YWdaRldmejQydUZnZFRMc0VxMEtoV2JjcU85Sjc5WjU0cWFtRGhrQ2Z3QTQw?=
 =?utf-8?B?TXZxV2NZRlJJNHBYa01NVnVjTXlEdlZXQTlibUJrUUtwK05acFErZjkvMTVv?=
 =?utf-8?B?OHZMWkRJaXVicTR1ckJ4alNJbnFyTytFdThkZlhiRG9WZzJvOC8xOXlFdDFs?=
 =?utf-8?B?T3lNcHp1QXNMN1FFYkdMMlBEZEFHbDhBU2p3c3hqaiszYnFNSzgrZ2UxTWkv?=
 =?utf-8?B?YjZnaDhGWldHRWttaE1RaWhwUk5KbFV1ZWp5d3FldlcwSnBGNGttWjh6c2tz?=
 =?utf-8?B?aytvMlFWM3V6ZTRVVjlHU1JqY0IxL2NKQzh6RzdPbTVVMi83VlNOUUFFVXhB?=
 =?utf-8?B?a1ZNNFdhK3dvTTNZQWE0dFZUU0p6WWNSVWhxSDR4d1dFRVI5b2ZTK3ZRU0Fs?=
 =?utf-8?B?YmxoZ0kxZ1dabXFtbk1KcWJueG5YeVRFN2RHcTFDVE5vdFlpUWhXak5KRWUx?=
 =?utf-8?B?K05GcTlxVTZNbStyVzZSWGJsTWxNaG12dVV2Rk5WakNRL2tJN3l1T0pIbHU4?=
 =?utf-8?B?NXFTSkEwaUhhU0JseFpISkFOMDE1Rml2aERTVExOTkdoODZTWWlVR1hEclpn?=
 =?utf-8?B?UzNFcVlSRTE5cWZHbjJLVW12ZnVPdHdid0NmUzdSbGg0TmExUGs4TUVtQUl1?=
 =?utf-8?B?SzVmOW5zZnNGK2piYkwyK3Z6Qzg1alNwS1Ixek03SGFpdStDN1JkMjU1SWVV?=
 =?utf-8?B?Rk5PYzBGRUlpUmhjVk5BTHcyaEtWYWxQTjZBaWNCTFFIdWlXS082a24yaWJT?=
 =?utf-8?B?VXppZ1hkWER4T09ORWZ6bXhaaDlqVmxuQmdYV1V3encvRWYxdDMzZHZja29J?=
 =?utf-8?B?NzhwSGR4Snh0a0htd2tFNWFteCs0dGs0UHpJQkZUSWpXQVBiaU1OZ2pOYmRN?=
 =?utf-8?Q?EmL/HlPM7uxFDaWu65RVx1r0h?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b932c36-f903-482a-c281-08dc23330164
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 14:35:15.5156
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ANw6DRZ+p1qEI8MVOBRKSicFLKriIxwmYQoP2rBqMOYJAFsA2drR6bhNxCI15T2CHgvGy+VtQdg+6XwXnBNKoA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB5672

On 2/1/2024 4:21 AM, Borislav Petkov wrote:
> On Wed, Jan 31, 2024 at 10:57:32AM -0600, Yazen Ghannam wrote:
>> diff --git a/drivers/ras/amd/atl/umc.c b/drivers/ras/amd/atl/umc.c
>> index 7bfa21a582f0..816c2c5c683f 100644
>> --- a/drivers/ras/amd/atl/umc.c
>> +++ b/drivers/ras/amd/atl/umc.c
>> @@ -49,6 +49,203 @@ static u8 get_coh_st_inst_id_mi300(struct atl_err *err)
>>   	return i;
>>   }
>>   
>> +static u16 internal_bitwise_xor(u16 val)
> 
> Why are we calling it "internal"?
> 


It's an operation on the bits within a value rather than between two values.

BTW, I looked up "internal" in a thesaurus, and nothing seemed much better to me.

Maybe something like "xor_bits_in_value()"? This has the verb-first style too.

Thanks,
Yazen