Received-SPF: pass (google.com: domain of linux-kernel+bounces-48329-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <d2474522-9e0d-4e72-af82-e849146f1541@intel.com>
Date: Thu, 1 Feb 2024 22:42:17 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/4] x86/virt/tdx: Advertise the
 CC_ATTR_HOST_MEM_INCOHERENT for TDX host
Content-Language: en-US
To: Dave Hansen <dave.hansen@intel.com>, <linux-kernel@vger.kernel.org>
CC: <x86@kernel.org>, <kirill.shutemov@linux.intel.com>, <tglx@linutronix.de>,
	<bp@alien8.de>, <mingo@redhat.com>, <hpa@zytor.com>, <luto@kernel.org>,
	<peterz@infradead.org>, <thomas.lendacky@amd.com>, <chao.gao@intel.com>,
	<bhe@redhat.com>, <nik.borisov@suse.com>, <pbonzini@redhat.com>
References: <cover.1706698706.git.kai.huang@intel.com>
 <ebbc67eb2c6052dd56fda31cd22bb830d3d290ef.1706698706.git.kai.huang@intel.com>
 <ccc94ede-4934-407f-883a-cd47079d2318@intel.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <ccc94ede-4934-407f-883a-cd47079d2318@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFhuNVI4c05GLzd4L1RCZ2VTMXVYNCt4U0taY21OUVIzd3dSSVJCQXE1dlV2?=
 =?utf-8?B?cVphZVJidGJaTW02aFFvM0MraXdhRnl3SlFENE00c2hFQUtlSFZ5R2d3YzBh?=
 =?utf-8?B?eStjTk9IS1c5S0ZvenhEN2IveFlwWkZ6Tmt1NHFNNUZIdWQ4RDFBT3o5b2h3?=
 =?utf-8?B?a1JKdFBTN1M0bE15M0p5UUhLS1ZWS1VQVlllWUJDZ2xTRWpJeVpVc2NrY2hn?=
 =?utf-8?B?eUdYcG9xb3NvV3Yyekh1WTFjM1pOUStPSmMrckx5SGJvSGlSK1BFUFBLZDFM?=
 =?utf-8?B?SHovMTZkbDl2MWhWTi80ZmRBdnZlN0ZyUVJmb2VxNGFsUkExK1RWQnFkNFJq?=
 =?utf-8?B?NzdSVHlWY3p3TW1KOENrazNkU2VqaDJRSm9UNUZYaGtUenNFK2k3WmRHeCtI?=
 =?utf-8?B?WkRpbk9xbHpBeHpULzBySWl4VUMvSFlxOW40YXVTZStXaVF6SEhZSkJySG1h?=
 =?utf-8?B?ZUpoQlZWNElYeTJUNXZlb3BZeFM3L0hkYmljQlFwRXFYUUtJdnZYSnYxNnkx?=
 =?utf-8?B?N0p4OGpaQTJFUTJ6Y0Q1Zk5POHBpTnNqcCtnbjJEZCt6eFNQZ3JIbnlQTjJt?=
 =?utf-8?B?bk9wR2xMMFBGcEk5clpWc29mTjJpVTNXTE9nMzBjVzVJdjJsYkxMTHZDTTlU?=
 =?utf-8?B?OXpROFhHNUU1QXdqWU9hcWFMVW1qNFhOOVBIRE5kUGo1OUMwVnYxempPTFN3?=
 =?utf-8?B?RFhLTnByeGsvS0pqV1NMdVJCSW5BUDNUTGUwUi9GWjZIKzZBSDYrL1hwelZl?=
 =?utf-8?B?MHVEYjMrdEM3ZHUxdjRrMkhWS0ozUWF3ZDZra1ltb0dGTjRjcHlTQnd1K1Vm?=
 =?utf-8?B?eGUvME01aFV5UUF2MHhnREZlaDI2UDdHQ1IwU29OOXpzUWxTcEhobWxHRE5F?=
 =?utf-8?B?VWprRHdJaEFCTGdpYkU3UU1idEhBTkZaNy9LWk15UUpkamhMWUhGMFpTUTVE?=
 =?utf-8?B?UmJYcTlRcXdPcThvM1JDOStBeUNtWkkrQllySTd3eU1RaWpna3ovcVVML01E?=
 =?utf-8?B?eVJkTnJtTmhRSVVSRzVsNnEwZTZPQWdXSVdQYUpwL0MzUVViMnZvb1haMERP?=
 =?utf-8?B?VkZ4bTdYaXBUeUN5YnBFODRPSEV1Q0MxNEFwWkc5OERpQUo5NVBJT1ZJWHN6?=
 =?utf-8?B?N1RDS0hadTh0NnpJck5pOUJKMDB0WlFXWU1QWGlzc1I2YnUzYTJwSHF4VmRY?=
 =?utf-8?B?MnFtcFA5L25QTkZYR2FCNElmTVhBVWZmUDc1TmN5SXZjSC9RU3NxVVBPLzIx?=
 =?utf-8?B?dzU5TnZBdURNaDZoR21ZMDgxWld6eUlKNU01bXNhNDAxYU81U0EwVE9mSXYw?=
 =?utf-8?B?VnVVK0ZuWWs5MlUzSnFaWUE0WjB0cFF1dGFUOWRxQ1p2V0k0RXVlcGVVNEF5?=
 =?utf-8?B?bzB1MzY3dGdtMVdCMFhIRDErZzBQd3Z6WXVXZWJoVWw1ekpBQkp2bUZ1cG5C?=
 =?utf-8?B?Wi9HSEpMOHVIVkZhbUhjelc3U3RLdDR2REVWTE1BR2N0TFNUSy9xSWM2L3BV?=
 =?utf-8?B?NWJES0ZtRG5xdEpaWi9rSHRjV01OVjlCeWhCcjVwUjdYZ1ZvRlYxdmVnOWFm?=
 =?utf-8?B?bmxuK2laVmcwaEd2cmxnUkxpTEp6YStkclUwcHBaK2diNjA0a3ZwUmM2dENo?=
 =?utf-8?B?TzVnZ21YQUlvYlVIN2NPR0xSUGRmUnRBRGdOZEwyLy9kOTNhMFNNa1hDNnpJ?=
 =?utf-8?B?T2NyZy9aQkNVVTYxZENlNUVRMnh0WDRPRnRyYjhGNmgrZlNHTUJPUVkvWHRh?=
 =?utf-8?B?eW1yYVp0RFhzWEVoQmRGOXcyTFFiMVVOMzVxaFhEaFlGMHAwYzRZS2VBN25O?=
 =?utf-8?B?d2I5V2FqbmxPNWNCVE1BUXFrUVkrNlpKOW1ScHFscEtxOU5NbGlldlAvTkZt?=
 =?utf-8?B?MDVEMjFoQUh6TW5PTFVXS0xpQW5Bb1FRVTVtRlFZcjNDWWYwUEh0eG1BeEpx?=
 =?utf-8?B?d0dlUGpvdk8zVWt6Q0JOdkdQZmFpejlFZzNFWFBpcDVFY2c4aTdoaTNRbENB?=
 =?utf-8?B?Mm1yRE1hS3lwTmJNQ1Qza0NKVlQxeEZuaFI0bFErdlBkRmE3cmpZL3VIVlBl?=
 =?utf-8?B?WXRpcG0xdmppWDRLTitSSXphcnJvWkpJekliRVdpeUh0YktuM1JXUHR4TTF4?=
 =?utf-8?Q?Nrkd7Fr/sEDUEg6IZNDDCwERO?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c067007-9972-4981-160e-08dc233404c3
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 14:42:30.8699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zwn8Q1N6cQ8/5UBoZdCGV7K+ruRripEUWbrxTW4smqaHQBCfw1aEsMvzE1BJJen57r7PCETHdL9/OwoPeklMcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4691
X-OriginatorOrg: intel.com


On 1/02/2024 1:11 am, Dave Hansen wrote:
> On 1/31/24 03:31, Huang, Kai wrote:
>> From: Kai Huang <kai.huang@intel.com>
>>
>> On the TDX capable platform, during kexec() the old kernel needs to
>> flush dirty cachelines of all TDX private memory otherwise they may
>> silently corrupt the new kernel's memory.
>>
>> Advertise the new introduced CC_ATTR_HOST_MEM_INCOHERENT attribute for
>> TDX host platform so the cache will be flushed during kexec().
> 
> So, you're setting a new bit, CC_ATTR_HOST_MEM_INCOHERENT.  The way I
> like to deal with these is to go back and look at the definition of
> CC_ATTR_HOST_MEM_INCOHERENT and see whether the changelog here convinces
> me that CC_ATTR_HOST_MEM_INCOHERENT is being set appropriately.  Bonus
> points if this changelog uses the same nomenclature as the comment
> describing CC_ATTR_HOST_MEM_INCOHERENT.
> 
> How well does this match the comment above CC_ATTR_HOST_MEM_INCOHERENT?

I will try to improve the changelog: explain what does 
CC_ATTR_HOST_MEM_INCOHERENT mean, and why it is suitable for TDX host.

Please let me know if you have more comments.  Thanks.

> 
>> Note theoretically cache flush is only needed when TDX module is
>> initialized, but the module initialization is done at runtime so just
>> advertise the CC attribute when the platform has TDX enabled.
> 
> I find this really hard to parse.  Here's a rewrite, as usual:
> 
> 	A TDX-host-capable system might not actually have any incoherent
> 	memory.  This can occur if a TDX module was never initialized or
> 	if the caches have been flushed since the last time TDX was
> 	used.  Ignore that case.  Eliminate the need for any locking and
> 	assume that any TDX-host-capable system might have incoherent
> 	memory by always setting CC_ATTR_HOST_MEM_INCOHERENT.

I appreciate, as usual.  :-)